From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1AA7C433E0 for ; Tue, 7 Jul 2020 10:44:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0E44206E2 for ; Tue, 7 Jul 2020 10:44:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="i+8zrHE/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727871AbgGGKoT (ORCPT ); Tue, 7 Jul 2020 06:44:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727096AbgGGKoS (ORCPT ); Tue, 7 Jul 2020 06:44:18 -0400 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57714C08C5E1 for ; Tue, 7 Jul 2020 03:44:18 -0700 (PDT) Received: by mail-oi1-x243.google.com with SMTP id h17so34504377oie.3 for ; Tue, 07 Jul 2020 03:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7QgWKK4RTXLZo2mZ8LP12+iEtRAYWukejbIygBOzwIw=; b=i+8zrHE/fs2Y8R0mSJSYG3HjDe8DMVO33zE9s8G+U3bPlySiM1KMfVq7FQZXMQAhf1 1otQWa3z0Vo7rjF4WrjRMSTIn13HVhr/JHalXoGUunpOX7WHRLB3zlFjoS1E2nKKej2L wWpZzxVUx8xWAMhvXDyMkaCaV3SfS6vGC00xyBcxsE3DhCqezURHXrD0RavIKX0oj+sp /oPMgxrv/HUucbo5d4BmjphhcwAKuEq5xOk51hTZk2do4F4w3ppJDidPfTL+qFOXKgk2 BplIYO3/hCX+Qvdwhdxy7PAM/Rm0Np0kp7ad9ua2RSY+KL50IHQX2mnutETcFSLaBndV Gpvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7QgWKK4RTXLZo2mZ8LP12+iEtRAYWukejbIygBOzwIw=; b=gZYjeUBbVJwVgy6xz9e0d+3VpkOKJQSBDEp6fQRi91jojn8kHW/pv0JQJXBsv1pmQw r7Kl+0SGQnO6LP1IhBJs7jWQ01aWLJKHYGbqoNrSmyU8v8YqXxumoTANekDyVnRBUAKW FhDsrUHmfxuTg1pcyKlISyfZsjaBqs3Izpwx2fH5ZAJXIEw3ZB1Si7DnJq0GNGQvgIeU AKL85qe0hHoYgYOhQxcVPfJxO6+cy8Cj5JIJmdmPCPTw89QAxMmdjAw3tXTkdTu4oI1x Tbrpxr3dQ6m5XdvxqhHMEPJzKiOcylcnVNsYwdRrTgTttq0UFP2svWLz18evbb+PJJ99 MUdQ== X-Gm-Message-State: AOAM5300DQiHzv2ETDoUVhnyKofl5Jk9sZ02mBCaBAZcIdu+1NCcMyRz BrjYHqq1KwlHiBKZmgUCELNVwaSyzYvOQpyemQ1fQg== X-Google-Smtp-Source: ABdhPJz+TeWph34DQmuzU5/HwXijA0+NDY97HXcO97SKerniK7b3Ulr3aDgUOA25daDJjAs5gvkPux2OD9AQjmHA6HA= X-Received: by 2002:a05:6808:a19:: with SMTP id n25mr2626139oij.84.1594118657366; Tue, 07 Jul 2020 03:44:17 -0700 (PDT) MIME-Version: 1.0 References: <20200624043341.33364-1-drosen@google.com> <20200624043341.33364-5-drosen@google.com> <877dvxggsl.fsf@collabora.com> In-Reply-To: <877dvxggsl.fsf@collabora.com> From: Daniel Rosenberg Date: Tue, 7 Jul 2020 03:44:06 -0700 Message-ID: Subject: Re: [PATCH v9 4/4] ext4: Use generic casefolding support To: Gabriel Krisman Bertazi Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, Alexander Viro , Richard Weinberger , linux-mtd@lists.infradead.org, Andreas Dilger , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Jun 23, 2020 at 10:43 PM Gabriel Krisman Bertazi wrote: > > Daniel Rosenberg writes: > > > - > > const struct dentry_operations ext4_dentry_ops = { > > - .d_hash = ext4_d_hash, > > - .d_compare = ext4_d_compare, > > + .d_hash = generic_ci_d_hash, > > + .d_compare = generic_ci_d_compare, > > }; > > #endif > > Can you make the structure generic since it is the same for f2fs and > ext4, which let you drop the code guards? Unless that becomes a problem for > d_revalidate with fscrypt, it is fine like this. > > -- > Gabriel Krisman Bertazi I unify them in a later patch, since I end up having to deal with fscrypt's d_revalidate. With that patch I'd end up undoing the export I'd add for this, so I'll skip that for the moment. -Daniel