From: Sedat Dilek <sedat.dilek@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Randy Dunlap <rdunlap@infradead.org>,
Kees Cook <keescook@chromium.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH v2] Documentation/llvm: add documentation on building w/ Clang/LLVM
Date: Wed, 26 Feb 2020 13:29:07 +0100 [thread overview]
Message-ID: <CA+icZUWcW3+9QdZcACCXP6Yun__Sm_s4+qM4rALdFf=hGBt3FQ@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNAQJuF__26R+fEsdfYH1SAJuo3-8grGQAE4htjxzEG-nqw@mail.gmail.com>
On Wed, Feb 26, 2020 at 12:31 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Hi.
>
>
> On Wed, Feb 26, 2020 at 6:02 AM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> >
> > Added to kbuild documentation. Provides more official info on building
> > kernels with Clang and LLVM than our wiki.
> >
> > Suggested-by: Randy Dunlap <rdunlap@infradead.org>
> > Reviewed-by: Kees Cook <keescook@chromium.org>
> > Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> > Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> > ---
> > Changes V1 -> V2:
> > * s/On going/ongoing/
> > * add Randy's Suggested-by
>
>
> I do not understand this tag update.
>
> As far as I saw the review process,
> I do not think Randy deserves to have Suggested-by
> because he just pointed out a typo (on going -> ongoing) :
> https://patchwork.kernel.org/patch/11401189/#23179575
>
> (or, was there off-line activity I had missed?)
>
Hi Masahiro,
I got some credits from Nick for a review by seeing a typo - not on a
review of the code - and H. Peter Anvin asked why.
I am not sure what is here the correct credit to give.
Depends a "Reviewed-by" and/or "Suggested-by" on a technical review?
My POV: When people take time to look over patches they should get
credits - sort of esteem.
Regards,
- Sedat -
P.S.: Tipp: Use codespell to find typos :-).
[1] https://git.kernel.org/linus/0e2e160033283e20f688d8bad5b89460cc5bfcc4
"x86/asm: Add _ASM_ARG* constants for argument registers to <asm/asm.h>"
next prev parent reply other threads:[~2020-02-26 12:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 17:41 [PATCH] Documentation/llvm: add documentation on building w/ Clang/LLVM Nick Desaulniers
2020-02-24 21:20 ` Randy Dunlap
2020-02-25 0:33 ` Masahiro Yamada
2020-02-25 20:52 ` Nick Desaulniers
2020-02-26 12:00 ` Masahiro Yamada
2020-02-26 12:33 ` Sedat Dilek
2020-02-27 4:38 ` Nathan Chancellor
2020-02-25 4:08 ` Kees Cook
2020-02-25 4:16 ` Nathan Chancellor
2020-02-25 4:25 ` Kees Cook
2020-02-25 20:59 ` Nick Desaulniers
2020-02-25 21:56 ` Kees Cook
2020-02-25 22:20 ` Joe Perches
2020-02-26 23:18 ` Nick Desaulniers
2020-02-26 23:23 ` Joe Perches
2020-02-27 4:44 ` Nathan Chancellor
2020-02-25 6:33 ` Sedat Dilek
2020-02-25 21:02 ` [PATCH v2] " Nick Desaulniers
2020-02-26 11:30 ` Masahiro Yamada
2020-02-26 12:29 ` Sedat Dilek [this message]
2020-02-26 12:38 ` Masahiro Yamada
2020-02-26 13:02 ` Sedat Dilek
2020-02-26 15:45 ` Randy Dunlap
2020-02-26 23:23 ` [PATCH v3] " Nick Desaulniers
2020-02-27 3:58 ` Masahiro Yamada
2020-02-27 16:11 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+icZUWcW3+9QdZcACCXP6Yun__Sm_s4+qM4rALdFf=hGBt3FQ@mail.gmail.com' \
--to=sedat.dilek@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=corbet@lwn.net \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).