From: Joonsoo Kim <js1304@gmail.com>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Vlastimil Babka <vbabka@suse.cz>,
corbet@lwn.net, linux-doc@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
lmark@codeaurora.org
Subject: Re: [PATCH v3] mm/page_owner: Record timestamp and pid
Date: Fri, 11 Dec 2020 11:31:32 +0900 [thread overview]
Message-ID: <CAAmzW4My=Abdv+GAe-nOdM0kbFFc28oQBxAM-hWfDLpj1AocdA@mail.gmail.com> (raw)
In-Reply-To: <20201210160357.27779-1-georgi.djakov@linaro.org>
2020년 12월 11일 (금) 오전 1:04, Georgi Djakov <georgi.djakov@linaro.org>님이 작성:
>
> From: Liam Mark <lmark@codeaurora.org>
>
> Collect the time for each allocation recorded in page owner so that
> allocation "surges" can be measured.
>
> Record the pid for each allocation recorded in page owner so that the
> source of allocation "surges" can be better identified.
>
> The above is very useful when doing memory analysis. On a crash for
> example, we can get this information from kdump (or ramdump) and parse it
> to figure out memory allocation problems.
>
> Please note that on x86_64 this increases the size of struct page_owner
> from 16 bytes to 32.
>
> Vlastimil: it's not a functionality intended for production, so unless
> somebody says they need to enable page_owner for debugging and this
> increase prevents them from fitting into available memory, let's not
> complicate things with making this optional.
>
> Signed-off-by: Liam Mark <lmark@codeaurora.org>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> Cc: Jonathan Corbet <corbet@lwn.net>
Acked-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
This is useful. Our company already has an in-house patch to store
pid since a few years ago.
Thanks.
prev parent reply other threads:[~2020-12-11 2:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 16:03 [PATCH v3] mm/page_owner: Record timestamp and pid Georgi Djakov
2020-12-11 2:31 ` Joonsoo Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAmzW4My=Abdv+GAe-nOdM0kbFFc28oQBxAM-hWfDLpj1AocdA@mail.gmail.com' \
--to=js1304@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=georgi.djakov@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lmark@codeaurora.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).