From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C379BC433B4 for ; Tue, 20 Apr 2021 01:12:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8767F6127C for ; Tue, 20 Apr 2021 01:12:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233087AbhDTBNH (ORCPT ); Mon, 19 Apr 2021 21:13:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231612AbhDTBNG (ORCPT ); Mon, 19 Apr 2021 21:13:06 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D9FBC06174A; Mon, 19 Apr 2021 18:12:36 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id t14so1806517lfe.1; Mon, 19 Apr 2021 18:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pCUafHxo7zwOCFRvS2ayIuzN+F/t+3Ifch7UyWe1pSE=; b=Py1ReygCSFEIYHBUTukA+AjqKp1bmuCn4AIa+SrBYJDezzqEh7QwRrpkzVOpoHT3QF GGMw3QICdVBdzOdCimNS0oVC8pbwut3Y0cm593lf8JzDY/egRgFHEWG4RbBO8VC9zh5o ZnvZUuuKOTl4W+LqDNpw8k8DIL4TwIZeYX0Vr6CsszkdJUOBrlWOh57CTl6qegnB7Fes NJRiMwNyDLymyPU65hAjC2QpqeR6pOZWqYVHE+mmB/+8rlw5v7adBQvRMbOUBxxMolzX 2NtrwK0iHMOklxsm1HDLIVXVpghWT4LQfArHsFRqBHq8r5DMDIvXtt9VT1lvum/Rz9GO XjKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pCUafHxo7zwOCFRvS2ayIuzN+F/t+3Ifch7UyWe1pSE=; b=izpUejNEMiur2GoP/tsQmHjccXQ0GaWBcGJqW1N1Uioa6GecAVEBSD3ZYB3vGpLUik 2DFAJKLFl9EU0sIFufl2E0hoUVdQZdMCH7KyA42cTO+KiH6rRHWPXYkL8zMmr5MdszkI jvfOeCHP6du0h8ETia4+Kn+qxmIwfMvfKLXcwVkkxKkhc98FwrQ6HWWTRG333m/4HQ0E fp2YhK4/Hzk5RVWZxO609BpVaacMuvMeB6kPzKMOfszTObLINnLKFcgvSL75Mc9eetsu LbqZvJ+cWz8GWxPHVaxSWfkr8rA1KZrja3R7jJI5msC5/j6rRCZYV6VpU5Uoob1G7z+M psGg== X-Gm-Message-State: AOAM530Fw0j4wqmhN6qkRHs160nzFN4Dzg5XtuHrFfv/h/0wmf76xRjC vPLAt9CuYC23gSrf+meBkdk7Vu71AaKxuUtBEjg= X-Google-Smtp-Source: ABdhPJy4QbZq6GpKOJR0Ui4FhbpWaBxUjIDZQtruRSxDc1mairsjSEzvBmJRHssRJ2cChC2T6OwozChm0iHqM5wGGmY= X-Received: by 2002:a05:6512:2256:: with SMTP id i22mr6740073lfu.651.1618881154808; Mon, 19 Apr 2021 18:12:34 -0700 (PDT) MIME-Version: 1.0 References: <20210316054727.25655-1-foxhlchen@gmail.com> <20210316054727.25655-2-foxhlchen@gmail.com> <20210419021730.GV2531743@casper.infradead.org> <20210419032513.GW2531743@casper.infradead.org> <87fszmaxl4.fsf@meer.lwn.net> In-Reply-To: <87fszmaxl4.fsf@meer.lwn.net> From: Fox Chen Date: Tue, 20 Apr 2021 09:12:23 +0800 Message-ID: Subject: Re: [PATCH v2 01/12] docs: path-lookup: update follow_managed() part To: Jonathan Corbet Cc: Matthew Wilcox , Neil Brown , vegard.nossum@oracle.com, Al Viro , rdunlap@infradead.org, grandmaster@al2klimov.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Greg KH Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Apr 20, 2021 at 3:22 AM Jonathan Corbet wrote: > > Fox Chen writes: > > > On Mon, Apr 19, 2021 at 11:25 AM Matthew Wilcox wrote: > >> > >> On Mon, Apr 19, 2021 at 10:33:00AM +0800, Fox Chen wrote: > >> > On Mon, Apr 19, 2021 at 10:17 AM Matthew Wilcox wrote: > >> > > You can drop ``..`` from around function named which are followed with > >> > > (). d74b0d31ddde ("Docs: An initial automarkup extension for sphinx") > >> > > marks them up automatically. > >> > > > >> > > >> > Got it, thanks for letting me know. But I will still use them in this > >> > patch series to keep consistency with the remaining parts of the > >> > document. > >> > >> Well, you weren't. For example: > >> > >> +As the last step of ``walk_component()``, ``step_into()`` will be called either > >> +directly from walk_component() or from handle_dots(). It calls > >> +``handle_mount()``, to check and handle mount points, in which a new > >> > >> Neither of the functions on the second line were using ``. > > > > Oh, That was a mistake, They should've been wrapped with ``. > > Thanks for pointing it out. I will go through the whole patch set and > > fix this type of inconsistency in V3. > > Please, if possible, go toward the bare function() form rather than > using literals...it's easier to read and the docs system will > automatically create cross references for you. > > Thanks, > > jon Ok, If you have no problem with that inconsistency, I will go with the bare one in v3. thanks, fox