From: Stephen Boyd <swboyd@chromium.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>,
Evan Green <evgreen@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-doc@vger.kernel.org, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v6 05/13] module: Add printk formats to add module build ID to stacktraces
Date: Tue, 11 May 2021 09:51:54 -0700 [thread overview]
Message-ID: <CAE-0n522Oy1B3W3gpnShFM3YhRDXU_4nt6NTvBETmDJ9EL-Ddw@mail.gmail.com> (raw)
In-Reply-To: <YJpr+T616Wki2542@alley>
Quoting Petr Mladek (2021-05-11 04:35:21)
> On Mon 2021-05-10 17:38:37, Stephen Boyd wrote:
> > Let's make kernel stacktraces easier to identify by including the build
> > ID[1] of a module if the stacktrace is printing a symbol from a module.
>
> > --- a/include/linux/module.h
> > +++ b/include/linux/module.h
> > @@ -11,6 +11,7 @@
> >
> > #include <linux/list.h>
> > #include <linux/stat.h>
> > +#include <linux/buildid.h>
> > #include <linux/compiler.h>
> > #include <linux/cache.h>
> > #include <linux/kmod.h>
> > @@ -364,6 +365,11 @@ struct module {
> > /* Unique handle for this module */
> > char name[MODULE_NAME_LEN];
> >
> > +#ifdef CONFIG_STACKTRACE_BUILD_ID
> > + /* Module build ID */
> > + unsigned char build_id[BUILD_ID_SIZE_MAX];
> > +#endif
> > +
> > /* Sysfs stuff. */
> > struct module_kobject mkobj;
> > struct module_attribute *modinfo_attrs;
> > @@ -627,7 +633,7 @@ void *dereference_module_function_descriptor(struct module *mod, void *ptr);
> > const char *module_address_lookup(unsigned long addr,
> > unsigned long *symbolsize,
> > unsigned long *offset,
> > - char **modname,
> > + char **modname, const unsigned char **modbuildid,
>
> Nit: It would have been better to follow the existing style and put only one
> parameter per-line.
>
> Please, fix it in the next version if there is any. But no need
> to resend it just because of this unless Jessica asks for it.
Thanks. akpm already picked this series up and fixed this problem.
next prev parent reply other threads:[~2021-05-11 16:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 0:38 [PATCH v6 00/13] Add build ID to stacktraces Stephen Boyd
2021-05-11 0:38 ` [PATCH v6 05/13] module: Add printk formats to add module " Stephen Boyd
2021-05-11 11:35 ` Petr Mladek
2021-05-11 16:51 ` Stephen Boyd [this message]
2021-05-11 11:48 ` [PATCH v6 00/13] Add " Petr Mladek
2021-05-11 12:36 ` David Laight
2021-05-11 12:52 ` Steven Rostedt
2021-05-11 12:58 ` David Laight
2021-05-11 14:21 ` Petr Mladek
2021-05-11 14:31 ` David Laight
2021-05-11 14:35 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n522Oy1B3W3gpnShFM3YhRDXU_4nt6NTvBETmDJ9EL-Ddw@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ast@kernel.org \
--cc=evgreen@chromium.org \
--cc=hsinyi@chromium.org \
--cc=jeyu@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).