From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 694FCC433C1 for ; Tue, 30 Mar 2021 16:27:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27A0F619CE for ; Tue, 30 Mar 2021 16:27:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231579AbhC3Q1U (ORCPT ); Tue, 30 Mar 2021 12:27:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232032AbhC3Q04 (ORCPT ); Tue, 30 Mar 2021 12:26:56 -0400 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D19EC061765 for ; Tue, 30 Mar 2021 09:26:56 -0700 (PDT) Received: by mail-yb1-xb31.google.com with SMTP id x189so18035153ybg.5 for ; Tue, 30 Mar 2021 09:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E84xiuP96qdI7CJTKEoKUbx5Tud8k1cz/vlbjHEw4u0=; b=NhyyBx3rsxS/8TIMF2Ga2ndhdkfALclaVvdMgUn9VzeEDA9vjUxsU0hrmepA76TfLt u0X4694RTY7cucG2E7Ff8cg8WyEZtc72CatSnkWj4BIkSv+WQ56l3wybCFVpC7oO8/aY n7JuOd68AJouHOTeOvP+UeSvFZ0DzJGOerJU8QYdsQ3N1WYHN/oNfRba5OmHqlCHvH3X O+u1FJyU6EET1HxP051/l4PrUVO0W7xz7dyvd7Eu54lhSOAPhAsK3Kb11A1ssyc9J65P MH/b7aHeZJaLunKWbnTsmaRedKpwTDaFc9GgNUVHXYtTbKTaLcBqisSEGID/TuBZAjHG wbPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E84xiuP96qdI7CJTKEoKUbx5Tud8k1cz/vlbjHEw4u0=; b=Z+93+fBtVVJQonESKsfPl7+wL6bGaR8pQNnH4M1N6zKcKaK7bGb5+b5of14mq11nCt VmOBhGzGSjOeKxsgfbCczYnGXVHA4ORgOAdm8XH5R/dTV4xXls0NioWlUe/vl4Go9tgQ PymA5bErDkbiYRas2qV+K8xUmcAB07ZGWKMJ9s97Rg7dkccKH7IEIJ9BjjZyXDeu2ZTn a1JSTYkIszmZ4v9DTpwL29CkFejVh56gslT4XjJCu3DxwUfVeo5/EZdMjN5iTgHJwKXW Ab3tC6Cz7aJ7jaly2rWkeAPzH7WOmT+VvNotIqSmUGfFIPhKwnaU3+pyhILtJNMjoR/x k3kg== X-Gm-Message-State: AOAM530Dy9PW1a8iVlTgQ86p9JsEd9H4vEvQuDGvOqgdLX1eu4rDKOMU YazsftxmgEPv/MPS6H3QpJEaEpiAdbduOrcBOZUFlw== X-Google-Smtp-Source: ABdhPJzRju2GzsjyNoiA4fXciYHN4xAXYF+zjvtaWtSDSt0ofrTYQWng9+AP3dlitSrOgxr9jUO9qbtBbt2EI9ZSqHM= X-Received: by 2002:a25:d3cf:: with SMTP id e198mr45556943ybf.228.1617121615342; Tue, 30 Mar 2021 09:26:55 -0700 (PDT) MIME-Version: 1.0 References: <20210205222644.2357303-9-saravanak@google.com> <20210210114435.122242-1-tudor.ambarus@microchip.com> <20210330154222.GA5411@roeck-us.net> In-Reply-To: <20210330154222.GA5411@roeck-us.net> From: Saravana Kannan Date: Tue, 30 Mar 2021 09:26:19 -0700 Message-ID: Subject: Re: [PATCH] clk: Mark fwnodes when their clock provider is added To: Guenter Roeck Cc: Tudor Ambarus , Jonathan Corbet , Greg Kroah-Hartman , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , "Brown, Len" , Len Brown , Pavel Machek , Michael Turquette , Stephen Boyd , Rob Herring , Frank Rowand , Marc Zyngier , Thomas Gleixner , Nicolas Ferre , Claudiu Beznea , Linux Doc Mailing List , LKML , Linux PM , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ACPI Devel Maling List , Marek Szyprowski , Geert Uytterhoeven , Android Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Mar 30, 2021 at 8:42 AM Guenter Roeck wrote: > > On Wed, Feb 10, 2021 at 01:44:34PM +0200, Tudor Ambarus wrote: > > This is a follow-up for: > > commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed") > > > > The above commit updated the deprecated of_clk_add_provider(), > > but missed to update the preferred of_clk_add_hw_provider(). > > Update it now. > > > > Signed-off-by: Tudor Ambarus > > Reviewed-by: Saravana Kannan > > --- > > drivers/clk/clk.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > index 27ff90eacb1f..9370e4dfecae 100644 > > --- a/drivers/clk/clk.c > > +++ b/drivers/clk/clk.c > > @@ -4594,6 +4594,8 @@ int of_clk_add_hw_provider(struct device_node *np, > > if (ret < 0) > > of_clk_del_provider(np); > > > > + fwnode_dev_initialized(&np->fwnode, true); > > + > > This causes a crash when booting raspi2 images in qemu. > > [ 22.123618] Unable to handle kernel NULL pointer dereference at virtual address 00000028 > [ 22.123830] pgd = (ptrval) > [ 22.123992] [00000028] *pgd=00000000 > [ 22.124579] Internal error: Oops: 5 [#1] SMP ARM > ... > [ 22.141624] [] (of_clk_add_hw_provider) from [] (devm_of_clk_add_hw_provider+0x48/0x80) > [ 22.141819] [] (devm_of_clk_add_hw_provider) from [] (raspberrypi_clk_probe+0x25c/0x384) > [ 22.141976] [] (raspberrypi_clk_probe) from [] (platform_probe+0x5c/0xb8) > [ 22.142114] [] (platform_probe) from [] (really_probe+0xf0/0x39c) > [ 22.142246] [] (really_probe) from [] (driver_probe_device+0x68/0xc0) > [ 22.142377] [] (driver_probe_device) from [] (bus_for_each_drv+0x84/0xc8)... > > np can (and will) be NULL here. See of_clk_set_defaults(). Thanks for the report. It was reported earlier by Marek and there's a discussion going on about it in the thread. -Saravana