From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 210B6C433DF for ; Tue, 4 Aug 2020 00:31:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2595E22B42 for ; Tue, 4 Aug 2020 00:31:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XSTwLSZ1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729312AbgHDAbO (ORCPT ); Mon, 3 Aug 2020 20:31:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729226AbgHDAbO (ORCPT ); Mon, 3 Aug 2020 20:31:14 -0400 Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13C3CC061757 for ; Mon, 3 Aug 2020 17:31:13 -0700 (PDT) Received: by mail-qv1-xf43.google.com with SMTP id s15so13825842qvv.7 for ; Mon, 03 Aug 2020 17:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Keb4Jl8eGTMNDh85x/MoXRXdhRswB8awzn31D2vbMj0=; b=XSTwLSZ1mADWjStO1ZNWRlwInkzdfEkyVSUc8QZ7UMJD2/JREd2lztc/i9omVInOj6 3gK1qEvMEiseqAKq/F384o3Yp/u51Vrx+lJWgkgq+uqyUlsqbTOPCV4Sg43QaJhFvr+Z c7Okotqw3+F9HP7Eh5oNxhVKmZCce3oOW6E5SzaUDtdWQl+Lkt2tnu9kmHllfPWwkoId 9eaNI28lQOQ738moL42u723ahUZXoYVNrr/aTxt/QKjkG1idXCYYTCyoO3Wk3f4gxFls 0Zkn7AL88C5G8qpmrudx7OXgchljK+Tb6n1IliP0Mz6AP/ahxAJIogxWdgdfRFsGEfQv ulFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Keb4Jl8eGTMNDh85x/MoXRXdhRswB8awzn31D2vbMj0=; b=KaHxnv8sxgxBJF83mSOHk3TKlktwWeY1uy6kOnczAcsqdQOxI4cZR4ygKhXTYLwoId G5MC24UmkY84/0wck1ivrMW5UrN3b6kGiZ+4VlLsEvJALc1RLAVo1e9BhWqzBQIc87CH XTLDK6nIRcjKrXWwUXmKLobY5QsBPp2aRxyEn+0mYN8xFZjW5mAOCsu+JXn61Q0caQYw JVzqBDcUA90tpuYyfgntwosKcXOz2ko8bCOIZfwH+QILImeHP494Z+kT509GzEa+vETO GOAyh+IYTmWjYmuLf6QXnTtn8wgAzkuX5+/IFrDVK1Soa8/VfhQiNgluLFH1KIBiNCvt QMBQ== X-Gm-Message-State: AOAM532rKeAD94X3pz1oa5z3/g+nuxt0FUPF2+yAdD3ac/JCeg+uQiCR A2a23Zzi4w6sSlshtiKiqIdpsKMZj3ciz8qQR6coLQ== X-Google-Smtp-Source: ABdhPJwzMvPWvyBxmyaZCvmqJjM3a+Az+ZwSYEPaUKkscBswzjvkcy7RYCd4ipv9IlL5fWfBRoT2auKF3Vsb/KH734w= X-Received: by 2002:a0c:9b96:: with SMTP id o22mr10770174qve.213.1596501071827; Mon, 03 Aug 2020 17:31:11 -0700 (PDT) MIME-Version: 1.0 References: <20200803144719.3184138-1-kaleshsingh@google.com> <20200803144719.3184138-2-kaleshsingh@google.com> In-Reply-To: <20200803144719.3184138-2-kaleshsingh@google.com> From: Joel Fernandes Date: Mon, 3 Aug 2020 20:30:59 -0400 Message-ID: Subject: Re: [PATCH 1/2] fs: Add fd_install file operation To: Kalesh Singh Cc: Jonathan Corbet , Sumit Semwal , Alexander Viro , Steven Rostedt , Ingo Molnar , "open list:DOCUMENTATION" , LKML , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-fsdevel@vger.kernel.org, Suren Baghdasaryan , Hridya Valsaraju , Ioannis Ilkos , John Stultz , "Cc: Android Kernel" Content-Type: text/plain; charset="UTF-8" Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Aug 3, 2020 at 10:47 AM 'Kalesh Singh' via kernel-team wrote: > > Provides a per process hook for the acquisition of file descriptors, > despite the method used to obtain the descriptor. > Hi, So apart from all of the comments received, I think it is hard to understand what the problem is, what the front-end looks like etc. Your commit message is 1 line only. I do remember some of the challenges discussed before, but it would describe the problem in the commit message in detail and then discuss why this solution is fit. Please read submitting-patches.rst especially "2) Describe your changes". thanks, - Joel > Signed-off-by: Kalesh Singh > --- > Documentation/filesystems/vfs.rst | 5 +++++ > fs/file.c | 3 +++ > include/linux/fs.h | 1 + > 3 files changed, 9 insertions(+) > > diff --git a/Documentation/filesystems/vfs.rst b/Documentation/filesystems/vfs.rst > index ed17771c212b..95b30142c8d9 100644 > --- a/Documentation/filesystems/vfs.rst > +++ b/Documentation/filesystems/vfs.rst > @@ -1123,6 +1123,11 @@ otherwise noted. > ``fadvise`` > possibly called by the fadvise64() system call. > > +``fd_install`` > + called by the VFS when a file descriptor is installed in the > + process's file descriptor table, regardless how the file descriptor > + was acquired -- be it via the open syscall, received over IPC, etc. > + > Note that the file operations are implemented by the specific > filesystem in which the inode resides. When opening a device node > (character or block special) most filesystems will call special > diff --git a/fs/file.c b/fs/file.c > index abb8b7081d7a..f5db8622b851 100644 > --- a/fs/file.c > +++ b/fs/file.c > @@ -616,6 +616,9 @@ void __fd_install(struct files_struct *files, unsigned int fd, > void fd_install(unsigned int fd, struct file *file) > { > __fd_install(current->files, fd, file); > + > + if (file->f_op->fd_install) > + file->f_op->fd_install(fd, file); > } > > EXPORT_SYMBOL(fd_install); > diff --git a/include/linux/fs.h b/include/linux/fs.h > index f5abba86107d..b976fbe8c902 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1864,6 +1864,7 @@ struct file_operations { > struct file *file_out, loff_t pos_out, > loff_t len, unsigned int remap_flags); > int (*fadvise)(struct file *, loff_t, loff_t, int); > + void (*fd_install)(int, struct file *); > } __randomize_layout; > > struct inode_operations { > -- > 2.28.0.163.g6104cc2f0b6-goog > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >