From: Masahiro Yamada <masahiroy@kernel.org>
To: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Michal Marek <michal.lkml@markovi.net>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: remove wrong documentation about mandatory-y
Date: Fri, 21 Feb 2020 01:28:16 +0900 [thread overview]
Message-ID: <CAK7LNARuqSDxc1=pMQXUF942TSBeDeB0NosS-n0_hhiWhQZhQw@mail.gmail.com> (raw)
In-Reply-To: <20200219011519.22148-1-masahiroy@kernel.org>
On Wed, Feb 19, 2020 at 10:15 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> This sentence does not make sense in the section about mandatory-y.
>
> This seems to be a copy-paste mistake of commit fcc8487d477a ("uapi:
> export all headers under uapi directories").
>
> The correct description would be "The convention is to list one
> mandatory-y per line ...".
>
> I just removed it instead of fixing it. If such information is needed,
> it could be commented in include/asm-generic/Kbuild and
> include/uapi/asm-generic/Kbuild.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Applied to linux-kbuild.
> ---
>
> Documentation/kbuild/makefiles.rst | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild/makefiles.rst
> index 0e0eb2c8da7d..4018ad7c7a11 100644
> --- a/Documentation/kbuild/makefiles.rst
> +++ b/Documentation/kbuild/makefiles.rst
> @@ -1379,9 +1379,6 @@ See subsequent chapter for the syntax of the Kbuild file.
> in arch/$(ARCH)/include/(uapi/)/asm, Kbuild will automatically generate
> a wrapper of the asm-generic one.
>
> - The convention is to list one subdir per line and
> - preferably in alphabetic order.
> -
> 8 Kbuild Variables
> ==================
>
> --
> 2.17.1
>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2020-02-20 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 1:15 [PATCH] kbuild: remove wrong documentation about mandatory-y Masahiro Yamada
2020-02-20 16:28 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNARuqSDxc1=pMQXUF942TSBeDeB0NosS-n0_hhiWhQZhQw@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).