From: Masahiro Yamada <masahiroy@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
Jonathan Corbet <corbet@lwn.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] kconfig: fix documentation typos
Date: Fri, 17 Jan 2020 11:17:15 +0900 [thread overview]
Message-ID: <CAK7LNASYynBVaaGROEjy1PC7+9xatO7gf2LTRGG1UOpiXtzENw@mail.gmail.com> (raw)
In-Reply-To: <20200113232212.138327-1-helgaas@kernel.org>
On Tue, Jan 14, 2020 at 8:22 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Fix a couple typos in kconfig-language documentation.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> Documentation/kbuild/kconfig-language.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/kbuild/kconfig-language.rst b/Documentation/kbuild/kconfig-language.rst
> index 74bef19f69f0..f547720bd82d 100644
> --- a/Documentation/kbuild/kconfig-language.rst
> +++ b/Documentation/kbuild/kconfig-language.rst
> @@ -594,7 +594,7 @@ The two different resolutions for b) can be tested in the sample Kconfig file
> Documentation/kbuild/Kconfig.recursion-issue-02.
>
> Below is a list of examples of prior fixes for these types of recursive issues;
> -all errors appear to involve one or more select's and one or more "depends on".
> +all errors appear to involve one or more "selects" and one or more "depends on".
I think "selects" is strange here.
"select" is a Kconfig keyword.
select's is intentional, I guess.
Keep it as-is, or perhaps change it into "select" (singular) ?
>
> ============ ===================================
> commit fix
> @@ -656,7 +656,7 @@ the use of the xconfig configurator [1]_. Work should be done to confirm if
> the deduced semantics matches our intended Kconfig design goals.
>
> Having well defined semantics can be useful for tools for practical
> -evaluation of depenencies, for instance one such use known case was work to
> +evaluation of dependencies, for instance one such case was work to
> express in boolean abstraction of the inferred semantics of Kconfig to
> translate Kconfig logic into boolean formulas and run a SAT solver on this to
> find dead code / features (always inactive), 114 dead features were found in
> @@ -683,7 +683,7 @@ abstraction the inferred semantics of Kconfig to translate Kconfig logic into
> boolean formulas and run a SAT solver on it [5]_. Another known related project
> is CADOS [6]_ (former VAMOS [7]_) and the tools, mainly undertaker [8]_, which
> has been introduced first with [9]_. The basic concept of undertaker is to
> -exract variability models from Kconfig, and put them together with a
> +extract variability models from Kconfig and put them together with a
> propositional formula extracted from CPP #ifdefs and build-rules into a SAT
> solver in order to find dead code, dead files, and dead symbols. If using a SAT
> solver is desirable on Kconfig one approach would be to evaluate repurposing
> --
> 2.25.0.rc1.283.g88dfdc4193-goog
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2020-01-17 2:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 23:22 [PATCH] kconfig: fix documentation typos Bjorn Helgaas
2020-01-16 19:52 ` Jonathan Corbet
2020-01-17 2:27 ` Masahiro Yamada
2020-01-17 2:17 ` Masahiro Yamada [this message]
2020-01-17 3:54 ` Randy Dunlap
2020-01-17 4:07 ` Bjorn Helgaas
2020-01-17 14:50 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASYynBVaaGROEjy1PC7+9xatO7gf2LTRGG1UOpiXtzENw@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=helgaas@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).