From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A645DC433ED for ; Sat, 17 Apr 2021 19:36:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7640261354 for ; Sat, 17 Apr 2021 19:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236755AbhDQTgm (ORCPT ); Sat, 17 Apr 2021 15:36:42 -0400 Received: from conssluserg-02.nifty.com ([210.131.2.81]:24947 "EHLO conssluserg-02.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236212AbhDQTgm (ORCPT ); Sat, 17 Apr 2021 15:36:42 -0400 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (authenticated) by conssluserg-02.nifty.com with ESMTP id 13HJZqmc013042; Sun, 18 Apr 2021 04:35:52 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com 13HJZqmc013042 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1618688153; bh=hkh5YwuJBIOBjPiu6hBZE5+OCCrOzZnlnU6cXAwLvTY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZK3XIqNT/fCa8ImCuvX+cDcQTtmH4rQ6sXxD0QhdjI25bmRu04tR4OVAc2CdfXoLp 99YVsJ97jUfNaIdFiYrOAEFpaicKwL8uaDTpjraqcAdATICBoKKKzMgSbxDlWKYeRZ kMxLeGMHd1jUSAusYNcS7YdgGX1MwqQY1bPiOO84tOwwGAFkRSgAmzPtOReD5Vmzy2 YQApshMt9mKZxriuipk1nQCa6f+94TVRZYDORtb1iIWaZKZwV4co3hNVX7Pp5+QheH P/uBSjooCqTmifCZUTC1cwtHjTjeG02fVk/fgva+K4VtrAQoG/GFJxwNaf8zIOXLN+ wlCOiZZ7QqYAg== X-Nifty-SrcIP: [209.85.216.43] Received: by mail-pj1-f43.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so18196308pjh.1; Sat, 17 Apr 2021 12:35:52 -0700 (PDT) X-Gm-Message-State: AOAM530kXdrOvGw6ylR/jxCph0fN9fsHTD1Yx7YmjCuz+DSeTReO62Bd YR4CyGkb3gu2jAtjBYL6S/SfomziXD3XEsyWGww= X-Google-Smtp-Source: ABdhPJyiH91xXT+6zU7vn+mvPE0jUTNiMhDdgt0LZHv/4PQBIi/IYiCHtOLaUUe6kYHvSR01SInIGyrud/tn7vU1GTQ= X-Received: by 2002:a17:90a:1056:: with SMTP id y22mr15383723pjd.153.1618688151869; Sat, 17 Apr 2021 12:35:51 -0700 (PDT) MIME-Version: 1.0 References: <20210414184604.23473-1-ojeda@kernel.org> <20210414184604.23473-5-ojeda@kernel.org> In-Reply-To: From: Masahiro Yamada Date: Sun, 18 Apr 2021 04:35:15 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/13] Kbuild: Rust support To: Miguel Ojeda Cc: Nick Desaulniers , Miguel Ojeda , Linus Torvalds , Greg Kroah-Hartman , rust-for-linux@vger.kernel.org, Linux Kbuild mailing list , Linux Doc Mailing List , LKML , Alex Gaynor , Geoffrey Thomas , Finn Behrens , Adam Bratschi-Kaye , Wedson Almeida Filho , Michael Ellerman Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, Apr 15, 2021 at 9:43 AM Miguel Ojeda wrote: > > On Thu, Apr 15, 2021 at 1:19 AM Nick Desaulniers > wrote: > > > > Rather than check the origin (yikes, are we intentionally avoiding env > > vars?), can this simply be > > ifneq ($(CLIPPY),) > > KBUILD_CLIPPY := $(CLIPPY) > > endif > > > > Then you can specify whatever value you want, support command line or > > env vars, etc.? > > I was following the other existing cases like `V`. Masahiro can > probably answer why they are done like this. You are asking about this code: ifeq ("$(origin V)", "command line") KBUILD_VERBOSE = $(V) endif You can pass V=1 from the Make command line, but not from the environment. KBUILD_VERBOSE is intended as an environment variable, but you can use it from the Make command line. Work: - make V=1 - make KBUILD_VERBOSE=1 - KBUILD_VERBOSE=1 make Not work: - V=1 make The behavior is like that before I became the maintainer. In my best guess, the reason is, V=1 is a useful shorthand of KBUILD_VERBOSE=1, but it is too short. It should not accidentally pick up an unintended environment variable. -- Best Regards Masahiro Yamada