From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B871C433B4 for ; Tue, 18 May 2021 15:28:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C42E61285 for ; Tue, 18 May 2021 15:28:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243120AbhERP3n (ORCPT ); Tue, 18 May 2021 11:29:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240624AbhERP3n (ORCPT ); Tue, 18 May 2021 11:29:43 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38FC3C061756 for ; Tue, 18 May 2021 08:28:24 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id f12so12093719ljp.2 for ; Tue, 18 May 2021 08:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lpRvF+xJ/4IcCek+cggWbs10JI8lkpvOBQ+cLldKIIU=; b=Q1Xn+dOVy2cUeeM8Q6YEGcIaBmPSenlSExzNe2VV+Ln/RroRbTMnsUCBvrEa/4S8Kp P3LjSGgIiWdAnedCndCWvTmNhyI87HcaxrqU8ZpeKW8TuQo1fM5Gnhh4pC34MYbg0TYb HbTEL+hzqTlFdDlvjpvcsnkjp5uzkmNDy5aFP8Cftwi4ZCywZK0gYCmfeGR0Kooi3v1R vnPb+61q6NDDFoPO7PIMziu5DMaTjRae5PR+l+pobPndB43tBo2pI6sVhAURhcvX/cgj HJNpSggF6E+TaIOPX2LPVNoTjGs0NJhQoY5VILW0Dma5Hye49UvG8I92oxc9Al28YWu4 sSlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lpRvF+xJ/4IcCek+cggWbs10JI8lkpvOBQ+cLldKIIU=; b=ujpoo5gm3dFfHVUYxXXaF2Vo3q7AmDfULS0/EcsriUTzCOZa7Qp9Qneg4y56XJfn6h HS9ym4C7Woy2LoXIiK95o03VJj4kmDxomQrD1PdAkCttZd8Osjxeh9hDy5kwaL7ycoDv SXSacqZADk9ezTxQDopS/jvA7bK3tYqPj9cT39MhT74frNpH9tg+jMGZOI3R866lkdeQ XN+G0ACADdyIllvt5AYCOjc/839IyCf/n6yccLwQt+XIXo6dKFphQP8jppc2IYh3OO7/ AFbRgtC0io3C1R37/8dgjDRSc83B25600cXv44NJgcMdtSA2RbGHyWa9DY+umWpcTMsh W70w== X-Gm-Message-State: AOAM533uinOW1S80Z0Re/AZMZz5tuJhJqW79vVvVflV0xbBpfEZ4fdLA 0ujtzwXmUZY4RGvUMNBTo5/Y8ZdlBEnBsYtaAOYymQ== X-Google-Smtp-Source: ABdhPJymDaoBvxC1m+UFkPfPnTNc2aZzsYMub514jj8ualntwMLqVJIB2cXHIjK6mmXgmFBrDkEtHJNe3rGDCU93VC8= X-Received: by 2002:a2e:9211:: with SMTP id k17mr4620637ljg.284.1621351702710; Tue, 18 May 2021 08:28:22 -0700 (PDT) MIME-Version: 1.0 References: <1621239831-5870-1-git-send-email-beata.michalska@arm.com> <1621239831-5870-2-git-send-email-beata.michalska@arm.com> <20210518142746.GA3993@e120325.cambridge.arm.com> <20210518150947.GC3993@e120325.cambridge.arm.com> In-Reply-To: <20210518150947.GC3993@e120325.cambridge.arm.com> From: Vincent Guittot Date: Tue, 18 May 2021 17:28:11 +0200 Message-ID: Subject: Re: [PATCH v4 1/3] sched/core: Introduce SD_ASYM_CPUCAPACITY_FULL sched_domain flag To: Beata Michalska Cc: linux-kernel , Peter Zijlstra , Ingo Molnar , Juri Lelli , Valentin Schneider , Dietmar Eggemann , "corbet@lwn.net" , Randy Dunlap , Linux Doc Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, 18 May 2021 at 17:09, Beata Michalska wrote: > > On Tue, May 18, 2021 at 04:53:09PM +0200, Vincent Guittot wrote: > > On Tue, 18 May 2021 at 16:27, Beata Michalska wrote: > > > > > > On Tue, May 18, 2021 at 03:39:27PM +0200, Vincent Guittot wrote: > > > > On Mon, 17 May 2021 at 10:24, Beata Michalska wrote: > > > > > > > > > > Introducing new, complementary to SD_ASYM_CPUCAPACITY, sched_domain > > > > > topology flag, to distinguish between shed_domains where any CPU > > > > > capacity asymmetry is detected (SD_ASYM_CPUCAPACITY) and ones where > > > > > a full range of CPU capacities is visible to all domain members > > > > > (SD_ASYM_CPUCAPACITY_FULL). > > > > > > > > I'm not sure about what you want to detect: > > > > > > > > Is it a sched_domain level with a full range of cpu capacity, i.e. > > > > with at least 1 min capacity and 1 max capacity ? > > > > or do you want to get at least 1 cpu of each capacity ? > > > That would be at least one CPU of each available capacity within given domain, > > > so full -set- of available capacities within a domain. > > > > Would be good to add the precision. > Will do. > > > > Although I'm not sure if that's the best policy compared to only > > getting the range which would be far simpler to implement. > > Do you have some topology example ? > > An example from second patch from the series: > > DIE [ ] > MC [ ][ ] > > CPU [0] [1] [2] [3] [4] [5] [6] [7] > Capacity |.....| |.....| |.....| |.....| > L M B B The one above , which is described in your patchset, works with the range policy > > Where: > arch_scale_cpu_capacity(L) = 512 > arch_scale_cpu_capacity(M) = 871 > arch_scale_cpu_capacity(B) = 1024 > > which could also look like: > > DIE [ ] > MC [ ][ ] > > CPU [0] [1] [2] [3] [4] [5] [6] [7] [8] [9] > Capacity |.....| |.....| |.....| |.....| |.....| > L M B L B I know that that HW guys can come with crazy idea but they would probably add M instead of L with B in the 2nd cluster as a boost of performance at the cost of powering up another "cluster" in which case the range policy works as well > > Considering only range would mean loosing the 2 (M) CPUs out of sight > for feec in some cases. Is it realistic ? Considering all the code and complexity added by patch 2, will we really use it at the end ? Regards, Vincent > > --- > BR. > B > > > > > > > > > > > > > > > > > > --- > > > BR > > > B. > > > > > > > > > > > > > > > > > > With the distinction between full and partial CPU capacity asymmetry, > > > > > brought in by the newly introduced flag, the scope of the original > > > > > SD_ASYM_CPUCAPACITY flag gets shifted, still maintaining the existing > > > > > behaviour when one is detected on a given sched domain, allowing > > > > > misfit migrations within sched domains that do not observe full range > > > > > of CPU capacities but still do have members with different capacity > > > > > values. It loses though it's meaning when it comes to the lowest CPU > > > > > asymmetry sched_domain level per-cpu pointer, which is to be now > > > > > denoted by SD_ASYM_CPUCAPACITY_FULL flag. > > > > > > > > > > Signed-off-by: Beata Michalska > > > > > Reviewed-by: Valentin Schneider > > > > > --- > > > > > include/linux/sched/sd_flags.h | 10 ++++++++++ > > > > > 1 file changed, 10 insertions(+) > > > > > > > > > > diff --git a/include/linux/sched/sd_flags.h b/include/linux/sched/sd_flags.h > > > > > index 34b21e9..57bde66 100644 > > > > > --- a/include/linux/sched/sd_flags.h > > > > > +++ b/include/linux/sched/sd_flags.h > > > > > @@ -91,6 +91,16 @@ SD_FLAG(SD_WAKE_AFFINE, SDF_SHARED_CHILD) > > > > > SD_FLAG(SD_ASYM_CPUCAPACITY, SDF_SHARED_PARENT | SDF_NEEDS_GROUPS) > > > > > > > > > > /* > > > > > + * Domain members have different CPU capacities spanning all unique CPU > > > > > + * capacity values. > > > > > + * > > > > > + * SHARED_PARENT: Set from the topmost domain down to the first domain where > > > > > + * all available CPU capacities are visible > > > > > + * NEEDS_GROUPS: Per-CPU capacity is asymmetric between groups. > > > > > + */ > > > > > +SD_FLAG(SD_ASYM_CPUCAPACITY_FULL, SDF_SHARED_PARENT | SDF_NEEDS_GROUPS) > > > > > + > > > > > +/* > > > > > * Domain members share CPU capacity (i.e. SMT) > > > > > * > > > > > * SHARED_CHILD: Set from the base domain up until spanned CPUs no longer share > > > > > -- > > > > > 2.7.4 > > > > >