From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FB51C47255 for ; Mon, 11 May 2020 23:52:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CEAE2070B for ; Mon, 11 May 2020 23:52:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="f/iY0vx2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727792AbgEKXwH (ORCPT ); Mon, 11 May 2020 19:52:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726077AbgEKXwH (ORCPT ); Mon, 11 May 2020 19:52:07 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13D41C05BD09 for ; Mon, 11 May 2020 16:52:07 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id f4so5504352iov.11 for ; Mon, 11 May 2020 16:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E0ufWGYomYJh/CRjPmWsKjyHaGblzMVR+WH0oCRkU7E=; b=f/iY0vx2TUE477Mbf6Hol0ZEB/geLQUWTBNLPH99rC4gbt8DEL0wyNqLPFi7DoGFZr 7ilzXRx1RjxnU4M6u/agvEQzIfHZW6rcOaLec7iRZfgdIs5es+hT/nY8/8XCkUuiSJCX 1/Xo/s8W0u9nQcPmXTW+yClHZJpEfzP09WjThC38iJaPtMInIRKGDIW64VPwup1usYnG AKTAxx1ZlgIGoPscs5F0u5camKL1ghBq3FWoUTRWNGwRUydM7qXX5aa3q2mQfCE2lQvm QvM7wHQRSeTAI/OwdDkvYruA7jQMIm50ltwqi7LpJEkvov6e9xGs54dTSluoov5M6i7F Kggg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E0ufWGYomYJh/CRjPmWsKjyHaGblzMVR+WH0oCRkU7E=; b=mi0m0tsBqCUZGXotqrGiXWefZBPzmX99JToUaxKki5g+4R9pgfYNLIaY2HMQRav+xG vSa4zI47vtWHQEcqVy6TzYznsmISh32K8GrWYeBZw2hzfFZHqOjwz/OXHtAm/AgqzKXD BlLnhdC/ff1CT9RLHHdkqAsTDWdCK3h+vNITuCGyw20KQaTvzCvD838IgxY4ph6qHtx0 L0YRyrAh3jKCdYu/hee6QY/g7SyXwKSEQQVJI0nlcCK7gK7bZhzWSgQ3tpF4Y1Pui9mN 2Q7hSMnqT7W4VmkRi/LH4FblCI2h9Pu+ZLR0UVtUKXFu/7NNF5rnAa7D50COD0EHTvcj 2jCA== X-Gm-Message-State: AGi0Pua/c6bTsXYLGv+IfalYpRvnvqLglifO8g18SN3JiKdR1zaXgTPs gw0rEkQ98LRzWUWSfDsq0OubUvlIdZKTfYYn63zdYg== X-Google-Smtp-Source: APiQypIE6swexZI94wnqzlV1sfe5g/6LxPhc7dA+0DPciSA53MnNiKcoJyfwwEW85sZRfHbRaVKSPPW19M6MPYvWcsY= X-Received: by 2002:a02:a60f:: with SMTP id c15mr7562634jam.24.1589241125957; Mon, 11 May 2020 16:52:05 -0700 (PDT) MIME-Version: 1.0 References: <158923982830.20128.14580309786525588408.stgit@naples-babu.amd.com> <158923999440.20128.4859351750654993810.stgit@naples-babu.amd.com> In-Reply-To: <158923999440.20128.4859351750654993810.stgit@naples-babu.amd.com> From: Jim Mattson Date: Mon, 11 May 2020 16:51:54 -0700 Message-ID: Subject: Re: [PATCH v3 3/3] KVM: x86: Move MPK feature detection to common code To: Babu Moger Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Paolo Bonzini , Sean Christopherson , "the arch/x86 maintainers" , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , Dave Hansen , Andy Lutomirski , Peter Zijlstra , mchehab+samsung@kernel.org, changbin.du@intel.com, Nadav Amit , Sebastian Andrzej Siewior , yang.shi@linux.alibaba.com, Anthony Steinhauser , anshuman.khandual@arm.com, Jan Kiszka , Andrew Morton , steven.price@arm.com, rppt@linux.vnet.ibm.com, peterx@redhat.com, Dan Williams , Arjun Roy , logang@deltatee.com, Thomas Hellstrom , Andrea Arcangeli , justin.he@arm.com, robin.murphy@arm.com, ira.weiny@intel.com, Kees Cook , Juergen Gross , Andrew Cooper , pawan.kumar.gupta@linux.intel.com, "Yu, Fenghua" , vineela.tummalapalli@intel.com, yamada.masahiro@socionext.com, sam@ravnborg.org, acme@redhat.com, linux-doc@vger.kernel.org, LKML , kvm list Content-Type: text/plain; charset="UTF-8" Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, May 11, 2020 at 4:33 PM Babu Moger wrote: > > Both Intel and AMD support (MPK) Memory Protection Key feature. > Move the feature detection from VMX to the common code. It should > work for both the platforms now. > > Signed-off-by: Babu Moger > --- > arch/x86/kvm/cpuid.c | 4 +++- > arch/x86/kvm/vmx/vmx.c | 4 ---- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c > index 901cd1fdecd9..3da7d6ea7574 100644 > --- a/arch/x86/kvm/cpuid.c > +++ b/arch/x86/kvm/cpuid.c > @@ -278,6 +278,8 @@ void kvm_set_cpu_caps(void) > #ifdef CONFIG_X86_64 > unsigned int f_gbpages = F(GBPAGES); > unsigned int f_lm = F(LM); > + /* PKU is not yet implemented for shadow paging. */ > + unsigned int f_pku = tdp_enabled ? F(PKU) : 0; I think we still want to require that OSPKE be set on the host before exposing PKU to the guest.