From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DATE_IN_PAST_12_24, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF7BAC388F7 for ; Thu, 29 Oct 2020 00:19:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 448D4207DE for ; Thu, 29 Oct 2020 00:19:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732813AbgJ2ATA (ORCPT ); Wed, 28 Oct 2020 20:19:00 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:44093 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389212AbgJ1WpC (ORCPT ); Wed, 28 Oct 2020 18:45:02 -0400 Received: by mail-ot1-f66.google.com with SMTP id m26so630838otk.11; Wed, 28 Oct 2020 15:45:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+XN02PSejXD+FeqWTrgwKvG1TTSDYTM2yrZb6ygptq8=; b=CVTjna5g2XVGfGso31JoRpR07nQGR1+pt3N1oUBEC3lOAK+ejuNtguI896SRlUKoEe OlTsqTpasI16TzoW4+oF7UhbhIlkiOFHiVz2HUPn7J1xOONJnRpB8fnC4j7zYrfXTvT7 kamRM6QaiwLy5mNoE5XDdayATyai8Of5DS47OF9jhUkOtRqX4yTJI2XNH+rbJ1KE89/A sqlgmdSdRyJ4gMKXJnsLDwBOUOlvhaO0GpgHtH2dvWkwp9pWszdr4H+S1aVLHmxcthF+ kQF3KJrVqm7w9vSYCVtT77kMiKHWr8JgYbcw1m806wTYPzDkkAx1VKhkPGCBJ3Mp9GLE +fTg== X-Gm-Message-State: AOAM533RWsrc+p1DMUBcfN0cdBltY7Dc8+xwUahhPoFjpalh1aqdVeA3 HzDJ+0QrthseXpLO4O/gZxIxMj49XxaMysz7OImzPIFzXYsMhQ== X-Google-Smtp-Source: ABdhPJwVZzki+tgZs/Q8WXcxtVj9dxZr8/KAouxapBQlbbCT10SMVoqLjSjBsdSeiewzamwEvqLH3hEqv+123K4FYD8= X-Received: by 2002:a4a:5d84:: with SMTP id w126mr4993384ooa.1.1603877160928; Wed, 28 Oct 2020 02:26:00 -0700 (PDT) MIME-Version: 1.0 References: <20201027112955.14157-1-rppt@kernel.org> <20201027112955.14157-12-rppt@kernel.org> In-Reply-To: <20201027112955.14157-12-rppt@kernel.org> From: Geert Uytterhoeven Date: Wed, 28 Oct 2020 10:25:49 +0100 Message-ID: Subject: Re: [PATCH 11/13] m68k/mm: make node data and node setup depend on CONFIG_DISCONTIGMEM To: Mike Rapoport Cc: Andrew Morton , Alexey Dobriyan , Catalin Marinas , Greg Ungerer , John Paul Adrian Glaubitz , Jonathan Corbet , Matt Turner , Meelis Roos , Michael Schmitz , Mike Rapoport , Russell King , Tony Luck , Vineet Gupta , Will Deacon , alpha , Linux ARM , "open list:DOCUMENTATION" , Linux FS Devel , "linux-ia64@vger.kernel.org" , Linux Kernel Mailing List , linux-m68k , Linux MM , arcml Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Mike, On Tue, Oct 27, 2020 at 12:31 PM Mike Rapoport wrote: > From: Mike Rapoport > > The pg_data_t node structures and their initialization currently depends on > !CONFIG_SINGLE_MEMORY_CHUNK. Since they are required only for DISCONTIGMEM > make this dependency explicit and replace usage of > CONFIG_SINGLE_MEMORY_CHUNK with CONFIG_DISCONTIGMEM where appropriate. > > The CONFIG_SINGLE_MEMORY_CHUNK was implicitly disabled on the ColdFire MMU > variant, although it always presumed a single memory bank. As there is no > actual need for DISCONTIGMEM in this case, make sure that ColdFire MMU > systems set CONFIG_SINGLE_MEMORY_CHUNK to 'y'. > > Signed-off-by: Mike Rapoport Thanks for your patch! > --- > arch/m68k/Kconfig.cpu | 6 +++--- > arch/m68k/include/asm/page_mm.h | 2 +- > arch/m68k/mm/init.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) Is there any specific reason you didn't convert the checks for CONFIG_SINGLE_MEMORY_CHUNK in arch/m68k/kernel/setup_mm.c and arch/m68k/include/asm/virtconvert.h? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds