From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D0AC2BB1D for ; Tue, 17 Mar 2020 08:42:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 057532071C for ; Tue, 17 Mar 2020 08:42:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725868AbgCQImB (ORCPT ); Tue, 17 Mar 2020 04:42:01 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:39126 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbgCQImB (ORCPT ); Tue, 17 Mar 2020 04:42:01 -0400 Received: by mail-ot1-f65.google.com with SMTP id r2so5370266otn.6; Tue, 17 Mar 2020 01:41:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8KAPg4bTos1rY9vws0C/xCO+F9oh55hyP0CnonU852I=; b=iubqMyUjFGwNTCeuykhwnWPzi4ZrZ5EAUPhIabkVYgSTUKLyhu0/Oq8Ej1wsSQ+Lhr FVEjQixNIRRE46dW4+rFtOr1cutw+RabudP3D52+hPUkpmrTxBDJisfA/yJwx1f6rmLO X4vETRYEpsYWPE0GWBbd4kUyPXL8wnq/9vnUZyKo7qF1awioM9aH7npPywhmNMcDvx73 2ZU4QqcbSUSzl8d/iQWMAUjo2Mu4K+5TCNS1PXNn06R7/mKjAL5HRELuqimlg19z8yk4 d11x4D3uhpfK6WSjEwagBzsIYNMpZQWEbdPFsdFspkT4keJXCGDRM4eYBH8AyrciIcaq NBwQ== X-Gm-Message-State: ANhLgQ26eX7G394qQtfH2C+Y4ZRrRj+jDJHMnLERKIzaUsN8u5SW7faW Dg48UiVckW6MyEJqHVrHGM7QUC/OqdhE0lTVY7g= X-Google-Smtp-Source: ADFU+vvJp0nv92HoVayJxMdw/lQoVKJfhGofeOWGjeWQZ4VsyHP2OYzQFJDW/aLh70OIkdl5GYBag7ZinGzuIjBpa74= X-Received: by 2002:a9d:8d0:: with SMTP id 74mr2800645otf.39.1584434518599; Tue, 17 Mar 2020 01:41:58 -0700 (PDT) MIME-Version: 1.0 References: <20200218151812.7816-1-geert+renesas@glider.be> <20200218151812.7816-2-geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 17 Mar 2020 09:41:47 +0100 Message-ID: Subject: Re: [PATCH v5 1/5] gpiolib: Add support for gpiochipN-based table lookup To: Linus Walleij Cc: Bartosz Golaszewski , Jonathan Corbet , Harish Jenny K N , Eugeniu Rosca , Alexander Graf , Peter Maydell , Paolo Bonzini , Phil Reid , Marc Zyngier , Christoffer Dall , Magnus Damm , Rob Herring , Mark Rutland , "open list:GPIO SUBSYSTEM" , Linux Doc Mailing List , Linux-Renesas , "linux-kernel@vger.kernel.org" , QEMU Developers Content-Type: text/plain; charset="UTF-8" Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Linus, On Thu, Mar 12, 2020 at 3:23 PM Linus Walleij wrote: > On Tue, Feb 18, 2020 at 4:18 PM Geert Uytterhoeven > wrote: > > > Currently GPIO controllers can only be referred to by label in GPIO > > lookup tables. > > > > Add support for looking them up by "gpiochipN" name, with "N" the > > corresponding GPIO device's ID number. > > > > Signed-off-by: Geert Uytterhoeven > > Reviewed-by: Ulrich Hecht > > Reviewed-by: Eugeniu Rosca > > Tested-by: Eugeniu Rosca > > Just like with patch 2/5 I have the same problem here that > the commit message doesn't state the technical reason why > we need to change this and support the device name in these > tables and not just labels. As these "gpiochipN" names are not stable, I will drop this patch, and the related support. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds