From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Saravana Kannan <saravanak@google.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Jonathan Corbet <corbet@lwn.net>,
Frank Rowand <frowand.list@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
Kevin Hilman <khilman@kernel.org>,
Len Brown <len.brown@intel.com>, Len Brown <lenb@kernel.org>,
Marc Zyngier <maz@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Pavel Machek <pavel@ucw.cz>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ulf Hansson <ulf.hansson@linaro.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
DOCUMENTATION <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
<devicetre e @vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>,
linux-rpi-kernel" <linux-rpi-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: Mark fwnodes when their clock provider is added
Date: Wed, 31 Mar 2021 09:05:00 +0200 [thread overview]
Message-ID: <CAMuHMdXMhiOBSSwrC2A_ijXCaekBMfC8h9PFhqLtNGhtPDba=A@mail.gmail.com> (raw)
In-Reply-To: <161715734080.2260335.881350237641202575@swboyd.mtv.corp.google.com>
Hi Stephen,
On Wed, Mar 31, 2021 at 4:22 AM Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Geert Uytterhoeven (2021-03-29 23:58:23)
> > On Tue, Mar 30, 2021 at 3:53 AM Stephen Boyd <sboyd@kernel.org> wrote:
> > > Quoting Saravana Kannan (2021-03-29 16:28:20)
> > > > On Mon, Mar 29, 2021 at 2:25 PM Stephen Boyd <sboyd@kernel.org> wrote:
> > > > > Quoting Geert Uytterhoeven (2021-03-26 11:29:55)
> > > > > > On Fri, Mar 26, 2021 at 7:13 PM Stephen Boyd <sboyd@kernel.org> wrote:
> > > > > > > Quoting Nicolas Saenz Julienne (2021-03-25 11:25:24)
> > > > > > > > >
> > > > > > > > > This patch mainly revealed that clk/bcm/clk-raspberrypi.c driver calls
> > > > > > > > > devm_of_clk_add_hw_provider(), with a device pointer, which has a NULL
> > > > > > > > > dev->of_node. I'm not sure if adding a check for a NULL np in
> > > > > > > > > of_clk_add_hw_provider() is a right fix, though.
> > > > > > > >
> > > > > > > > I believe the right fix is not to call 'devm_of_clk_add_hw_provider()' if
> > > > > > > > 'pdev->dev.of_node == NULL'. In such case, which is RPi3's, only the CPU clock
> > > > > > > > is used, and it's defined and queried later through
> > > > > > > > devm_clk_hw_register_clkdev().
> > > > > > > >
> > > > > > > > @Marek, I don't mind taking care of it if it's OK with you.
> > > > > > > >
> > > > > > >
> > > > > > > Ah I see this is related to the patch I just reviewed. Can you reference
> > > > > > > this in the commit text? And instead of putting the change into the clk
> > > > > > > provider let's check for NULL 'np' in of_clk_add_hw_provider() instead
> > > > > > > and return 0 if there's nothing to do. That way we don't visit this
> > > > > > > problem over and over again.
> > > > > >
> > > > > > I'm not sure the latter is what we reall want: shouldn't calling
> > > > > > *of*_clk_add_hw_provider() with a NULL np be a bug in the provider?
> > > > > >
> > > > >
> > > > > I don't have a strong opinion either way. Would it be useful if the
> > > > > function returned an error when 'np' is NULL?
> > > >
> > > > I lean towards returning an error. Not a strong opinion either.
> > >
> > > Does it have any use?
> >
> > of_clk_del_provider() removes the first provider found with node == NULL.
> > If there are two drivers calling of_clk_add_hw_provider(), and one of
> > hem calls of_clk_del_provider() later, the wrong provider may be
> > removed from the list.
> >
>
> So you're saying we shouldn't add a NULL device node pointer to the list
> so that this can't happen? That doesn't mean returning an error from
> of_clk_add_hw_provider() would be useful though.
> of_clk_add_hw_provider() can return 0 if np == NULL and
> of_clk_del_provider() can return early if np == NULL too.
I don't know if I grasp all meanings of the above.
The main question is if it is valid for a driver to call
of_clk_add_hw_provider()
with np == NULL.
- If yes, should that register the provider?
- If yes, how to handle two drivers calling of_clk_add_hw_provider()
with np = NULL, as their unregistration order is not guaranteed to
be correct.
If no, is that something to ignore (0), or a bug (error)?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-03-31 7:05 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210205222651eucas1p28ef87073dea33c1c5224c14aa203bec5@eucas1p2.samsung.com>
2021-02-05 22:26 ` [PATCH v4 0/8] Make fw_devlink=on more forgiving Saravana Kannan
2021-02-05 22:26 ` [PATCH v4 1/8] driver core: fw_devlink: Detect supplier devices that will never be added Saravana Kannan
2021-02-05 22:26 ` [PATCH v4 2/8] of: property: Don't add links to absent suppliers Saravana Kannan
2021-02-09 21:25 ` Rob Herring
2021-02-05 22:26 ` [PATCH v4 3/8] driver core: Add fw_devlink.strict kernel param Saravana Kannan
2021-02-05 22:26 ` [PATCH v4 4/8] of: property: Add fw_devlink support for optional properties Saravana Kannan
2021-02-09 21:33 ` Rob Herring
2021-02-09 21:54 ` Saravana Kannan
2021-02-10 8:25 ` Geert Uytterhoeven
2021-02-05 22:26 ` [PATCH v4 5/8] driver core: fw_devlink: Handle suppliers that don't use driver core Saravana Kannan
2021-02-05 22:26 ` [PATCH v4 6/8] irqdomain: Mark fwnodes when their irqdomain is added/removed Saravana Kannan
2021-02-05 22:26 ` [PATCH v4 7/8] PM: domains: Mark fwnodes when their powerdomain " Saravana Kannan
2021-02-05 22:26 ` [PATCH v4 8/8] clk: Mark fwnodes when their clock provider " Saravana Kannan
2021-02-08 15:38 ` Rob Herring
2021-02-08 23:34 ` Saravana Kannan
2021-02-10 11:44 ` [PATCH] clk: Mark fwnodes when their clock provider is added Tudor Ambarus
2021-02-10 11:44 ` Tudor Ambarus
2021-02-11 13:00 ` Greg KH
2021-02-13 0:37 ` Stephen Boyd
[not found] ` <CGME20210325133159eucas1p297b769beb681743fb32d362a86cc6e3e@eucas1p2.samsung.com>
2021-03-25 13:31 ` Marek Szyprowski
2021-03-25 15:47 ` Geert Uytterhoeven
2021-03-25 18:25 ` Nicolas Saenz Julienne
2021-03-26 18:13 ` Stephen Boyd
2021-03-26 18:29 ` Geert Uytterhoeven
[not found] ` <161705310317.3012082.15148238105608149214@swboyd.mtv.corp.google.com>
2021-03-29 23:28 ` Saravana Kannan
[not found] ` <161706920822.3012082.10047587064612237296@swboyd.mtv.corp.google.com>
2021-03-30 6:58 ` Geert Uytterhoeven
[not found] ` <161715734080.2260335.881350237641202575@swboyd.mtv.corp.google.com>
2021-03-31 7:05 ` Geert Uytterhoeven [this message]
[not found] ` <161721871083.2260335.2392646934517115770@swboyd.mtv.corp.google.com>
2021-04-05 11:04 ` Nicolas Saenz Julienne
2021-04-21 3:26 ` Guenter Roeck
2021-04-21 7:00 ` Saravana Kannan
2021-02-10 19:13 ` Saravana Kannan
2021-03-30 15:42 ` Guenter Roeck
2021-03-30 16:26 ` Saravana Kannan
[not found] ` <161317679292.1254594.15797939257637374295@swboyd.mtv.corp.google.com>
2021-02-14 21:15 ` [PATCH v4 8/8] clk: Mark fwnodes when their clock provider is added/removed Saravana Kannan
2021-02-06 2:45 ` [PATCH v4 0/8] Make fw_devlink=on more forgiving Saravana Kannan
2021-02-06 19:41 ` Geert Uytterhoeven
2021-02-06 20:47 ` Saravana Kannan
2021-02-08 8:40 ` Marek Szyprowski
2021-02-08 23:57 ` Saravana Kannan
2021-02-10 8:19 ` Tudor.Ambarus
2021-02-10 8:54 ` Saravana Kannan
2021-02-10 10:02 ` Tudor.Ambarus
2021-02-10 19:14 ` Saravana Kannan
2021-02-11 13:00 ` Geert Uytterhoeven
2021-02-11 13:05 ` Geert Uytterhoeven
2021-02-12 2:59 ` Saravana Kannan
2021-02-12 8:14 ` Geert Uytterhoeven
2021-02-12 20:57 ` Saravana Kannan
2021-02-15 12:38 ` Geert Uytterhoeven
2021-02-15 21:26 ` Saravana Kannan
2021-02-16 8:05 ` Geert Uytterhoeven
2021-02-16 18:48 ` Saravana Kannan
2021-02-16 20:31 ` Geert Uytterhoeven
2021-02-17 23:57 ` Saravana Kannan
2021-02-25 9:21 ` Geert Uytterhoeven
2021-02-15 15:16 ` Geert Uytterhoeven
2021-02-15 21:57 ` Saravana Kannan
2021-02-16 12:58 ` Geert Uytterhoeven
2021-02-15 11:19 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXMhiOBSSwrC2A_ijXCaekBMfC8h9PFhqLtNGhtPDba=A@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=claudiu.beznea@microchip.com \
--cc=corbet@lwn.net \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=nsaenzjulienne@suse.de \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tudor.ambarus@microchip.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).