From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54280C432C0 for ; Thu, 28 Nov 2019 17:20:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2873221739 for ; Thu, 28 Nov 2019 17:20:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LwTDbZMB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbfK1RUW (ORCPT ); Thu, 28 Nov 2019 12:20:22 -0500 Received: from mail-il1-f194.google.com ([209.85.166.194]:33762 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726587AbfK1RUW (ORCPT ); Thu, 28 Nov 2019 12:20:22 -0500 Received: by mail-il1-f194.google.com with SMTP id y16so17262594iln.0 for ; Thu, 28 Nov 2019 09:20:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Oie0bM178aUOxU4BJOrM9kVBDCA95ZD+DTy+5sq9Vkc=; b=LwTDbZMB0t4gpW9EXlsp+SpAcTpbl1AAAb4/Uv/C4t6EVxVHJDWskW/H8szBJDaATo n8D2pQGGDxYIavNp3NLeTPxj5vnm0wA+KuP+F8YPzz43s2WIKoNDHql0iYXMvtvb2F2z vNLeQOWcJAlWRwc4gK2yAhU5vo3b9nNP8RHyQHLA6/6iFsAU6JK/rQihBbPpWKz290Bj QxFWH/d5/U0cyPmTFwk3xWTCy6IPKdOer3iMR4zd2yzIXxPs+zClJ73phSMiv/KY92YB jhtn9/nWswqhvz8mF9w4yuws1mwo3cXVvt7gtZ0ZveJDLB/qKHMY8ITV0ooVN3XZuupr lZuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oie0bM178aUOxU4BJOrM9kVBDCA95ZD+DTy+5sq9Vkc=; b=UMIoMaONUwULVxpLzWwHbqgg5yoQasREiwdJxxxMX4VMQlcvSrUP7GQwrgAX05lHXt b0TLF74b14X341AU8dHHij7mOeq4roz91BrHX7r9Cl9BplvQhD0/WjhffSVsCLiTJll5 R9kEYZs5G1DcFB+rLyjTsRcaPUDeE++5DrpOtdMKKHJk+2xmWFJLZA7aonw8/UvDvp4X ANNDI2WdZewbzyB9UTxDKQKJMH/K/CqKuc9SwDnrGHOLNf4Aplsn1a5O45eVDaTC69AP GjEgy/rV79oxApP470cITyFY7+prpJXYL/LTDRdMtW8lX531TAbyikf6+3b306N0t4cv cxuQ== X-Gm-Message-State: APjAAAXMYn9yedLF02hcLg8xE0SYKjVcysGQJcEoeyOhrYlEujl+rKXW Xo7JgpKIpsaV2RNfYAR6TqEx+w1LV6YHu9Ozs8B5gw== X-Google-Smtp-Source: APXvYqwtBfdFeO0UfXhQ4uWy57Am43xaNg5zXNDfE01bsarG3c196FurVM4CPTCCwBIxN4josf68OMIMNTX395okYPE= X-Received: by 2002:a92:1547:: with SMTP id v68mr8134548ilk.58.1574961621511; Thu, 28 Nov 2019 09:20:21 -0800 (PST) MIME-Version: 1.0 References: <20191119231912.12768-1-mike.leach@linaro.org> <20191119231912.12768-4-mike.leach@linaro.org> In-Reply-To: From: Mathieu Poirier Date: Thu, 28 Nov 2019 10:20:10 -0700 Message-ID: Subject: Re: [PATCH v5 03/14] coresight: cti: Add sysfs access to program function regs To: Suzuki Kuruppassery Poulose Cc: Mike Leach , Coresight ML , linux-arm-kernel , devicetree@vger.kernel.org, "open list:DOCUMENTATION" Content-Type: text/plain; charset="UTF-8" Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, 28 Nov 2019 at 03:54, Suzuki Kuruppassery Poulose wrote: > > On 19/11/2019 23:19, Mike Leach wrote: > > Adds in sysfs programming support for the CTI function register sets. > > Allows direct manipulation of channel / trigger association registers. > > > > Reviewed-by: Mathieu Poirier > > Signed-off-by: Mike Leach > > > > +/* > > + * #define CTI_DEBUG_INTEGRATION_CTRL to enable the access to the integration > > + * control registers. Normally only used to investigate connection data. > > + */ > > On a second thought, I have some comments on this symbol. > > Given that the integration control registers may be useful for people to > find the device connections, I strongly feel that this is provided > via a CONFIG symbol rather than a debug symbol within the code. Device connections can be discovered with the dynamic sysfs connection entries added as part of patch 09. In cases where that is not sufficient and people really need to use the integration control registers they are probably instrumenting the code anyway. > > i.e, CONFIG_CTI_DEBUG_INTEGRATION_CTRL, to help the people better. > Codewise this doesn't make much difference, but it certainly makes > it more easier for people to use it. I agree that code-wise it doesn't make much difference but I'm really not convinced it makes the driver easier to use, and one needs to recompile their kernel for production systems anyway. Thanks, Mathieu > > We have used debug symbols elsewhere in the drivers for pure functional > debugging purposes. However I feel this is case is superior. > > > Cheers > Suzuki