Linux-Doc Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v3] docs: proc.rst: meminfo: briefly describe gaps in memory accounting
@ 2021-04-21  6:11 Mike Rapoport
  2021-04-21  7:00 ` Michal Hocko
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Mike Rapoport @ 2021-04-21  6:11 UTC (permalink / raw)
  To: Jonathan Corbet
  Cc: Alexey Dobriyan, Andrew Morton, Eric Dumazet, Matthew Wilcox,
	Michal Hocko, Mike Rapoport, Mike Rapoport, linux-doc,
	linux-fsdevel, linux-kernel, linux-mm, netdev

From: Mike Rapoport <rppt@linux.ibm.com>

Add a paragraph that explains that it may happen that the counters in
/proc/meminfo do not add up to the overall memory usage.

Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
v3:
* Add sentense about counters overlap
* Use wording suggested by Matthew

v2: Link: https://lore.kernel.org/lkml/20210420121354.1160437-1-rppt@kernel.org
* Add brief changelog
* Fix typo
* Update example about network memory usage according to Eric's comment at

https://lore.kernel.org/lkml/CANn89iKprp7WYeZy4RRO5jHykprnSCcVBc7Tk14Ui_MA9OK7Fg@mail.gmail.com

v1: Link: https://lore.kernel.org/lkml/20210420085105.1156640-1-rppt@kernel.org
 Documentation/filesystems/proc.rst | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
index 48fbfc336ebf..0a07a5025571 100644
--- a/Documentation/filesystems/proc.rst
+++ b/Documentation/filesystems/proc.rst
@@ -929,8 +929,15 @@ meminfo
 ~~~~~~~
 
 Provides information about distribution and utilization of memory.  This
-varies by architecture and compile options.  The following is from a
-16GB PIII, which has highmem enabled.  You may not have all of these fields.
+varies by architecture and compile options.  Some of the counters reported
+here overlap.  The memory reported by the non overlapping counters may not
+add up to the overall memory usage and the difference for some workloads
+can be substantial.  In many cases there are other means to find out
+additional memory using subsystem specific interfaces, for instance
+/proc/net/sockstat for TCP memory allocations.
+
+The following is from a 16GB PIII, which has highmem enabled.
+You may not have all of these fields.
 
 ::
 
-- 
2.29.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] docs: proc.rst: meminfo: briefly describe gaps in memory accounting
  2021-04-21  6:11 [PATCH v3] docs: proc.rst: meminfo: briefly describe gaps in memory accounting Mike Rapoport
@ 2021-04-21  7:00 ` Michal Hocko
  2021-04-21 12:37 ` Matthew Wilcox
  2021-04-23 14:27 ` Vlastimil Babka
  2 siblings, 0 replies; 4+ messages in thread
From: Michal Hocko @ 2021-04-21  7:00 UTC (permalink / raw)
  To: Mike Rapoport
  Cc: Jonathan Corbet, Alexey Dobriyan, Andrew Morton, Eric Dumazet,
	Matthew Wilcox, Mike Rapoport, linux-doc, linux-fsdevel,
	linux-kernel, linux-mm, netdev

On Wed 21-04-21 09:11:27, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
> 
> Add a paragraph that explains that it may happen that the counters in
> /proc/meminfo do not add up to the overall memory usage.
> 
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
> v3:
> * Add sentense about counters overlap
> * Use wording suggested by Matthew
> 
> v2: Link: https://lore.kernel.org/lkml/20210420121354.1160437-1-rppt@kernel.org
> * Add brief changelog
> * Fix typo
> * Update example about network memory usage according to Eric's comment at
> 
> https://lore.kernel.org/lkml/CANn89iKprp7WYeZy4RRO5jHykprnSCcVBc7Tk14Ui_MA9OK7Fg@mail.gmail.com
> 
> v1: Link: https://lore.kernel.org/lkml/20210420085105.1156640-1-rppt@kernel.org
>  Documentation/filesystems/proc.rst | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> index 48fbfc336ebf..0a07a5025571 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -929,8 +929,15 @@ meminfo
>  ~~~~~~~
>  
>  Provides information about distribution and utilization of memory.  This
> -varies by architecture and compile options.  The following is from a
> -16GB PIII, which has highmem enabled.  You may not have all of these fields.
> +varies by architecture and compile options.  Some of the counters reported
> +here overlap.  The memory reported by the non overlapping counters may not
> +add up to the overall memory usage and the difference for some workloads
> +can be substantial.  In many cases there are other means to find out
> +additional memory using subsystem specific interfaces, for instance
> +/proc/net/sockstat for TCP memory allocations.
> +
> +The following is from a 16GB PIII, which has highmem enabled.
> +You may not have all of these fields.
>  
>  ::
>  
> -- 
> 2.29.2
> 

-- 
Michal Hocko
SUSE Labs

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] docs: proc.rst: meminfo: briefly describe gaps in memory accounting
  2021-04-21  6:11 [PATCH v3] docs: proc.rst: meminfo: briefly describe gaps in memory accounting Mike Rapoport
  2021-04-21  7:00 ` Michal Hocko
@ 2021-04-21 12:37 ` Matthew Wilcox
  2021-04-23 14:27 ` Vlastimil Babka
  2 siblings, 0 replies; 4+ messages in thread
From: Matthew Wilcox @ 2021-04-21 12:37 UTC (permalink / raw)
  To: Mike Rapoport
  Cc: Jonathan Corbet, Alexey Dobriyan, Andrew Morton, Eric Dumazet,
	Michal Hocko, Mike Rapoport, linux-doc, linux-fsdevel,
	linux-kernel, linux-mm, netdev

On Wed, Apr 21, 2021 at 09:11:27AM +0300, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
> 
> Add a paragraph that explains that it may happen that the counters in
> /proc/meminfo do not add up to the overall memory usage.
> 
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] docs: proc.rst: meminfo: briefly describe gaps in memory accounting
  2021-04-21  6:11 [PATCH v3] docs: proc.rst: meminfo: briefly describe gaps in memory accounting Mike Rapoport
  2021-04-21  7:00 ` Michal Hocko
  2021-04-21 12:37 ` Matthew Wilcox
@ 2021-04-23 14:27 ` Vlastimil Babka
  2 siblings, 0 replies; 4+ messages in thread
From: Vlastimil Babka @ 2021-04-23 14:27 UTC (permalink / raw)
  To: Mike Rapoport, Jonathan Corbet
  Cc: Alexey Dobriyan, Andrew Morton, Eric Dumazet, Matthew Wilcox,
	Michal Hocko, Mike Rapoport, linux-doc, linux-fsdevel,
	linux-kernel, linux-mm, netdev

On 4/21/21 8:11 AM, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
> 
> Add a paragraph that explains that it may happen that the counters in
> /proc/meminfo do not add up to the overall memory usage.
> 
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

Thanks.

> ---
> v3:
> * Add sentense about counters overlap
> * Use wording suggested by Matthew
> 
> v2: Link: https://lore.kernel.org/lkml/20210420121354.1160437-1-rppt@kernel.org
> * Add brief changelog
> * Fix typo
> * Update example about network memory usage according to Eric's comment at
> 
> https://lore.kernel.org/lkml/CANn89iKprp7WYeZy4RRO5jHykprnSCcVBc7Tk14Ui_MA9OK7Fg@mail.gmail.com
> 
> v1: Link: https://lore.kernel.org/lkml/20210420085105.1156640-1-rppt@kernel.org
>  Documentation/filesystems/proc.rst | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> index 48fbfc336ebf..0a07a5025571 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -929,8 +929,15 @@ meminfo
>  ~~~~~~~
>  
>  Provides information about distribution and utilization of memory.  This
> -varies by architecture and compile options.  The following is from a
> -16GB PIII, which has highmem enabled.  You may not have all of these fields.
> +varies by architecture and compile options.  Some of the counters reported
> +here overlap.  The memory reported by the non overlapping counters may not
> +add up to the overall memory usage and the difference for some workloads
> +can be substantial.  In many cases there are other means to find out
> +additional memory using subsystem specific interfaces, for instance
> +/proc/net/sockstat for TCP memory allocations.
> +
> +The following is from a 16GB PIII, which has highmem enabled.
> +You may not have all of these fields.
>  
>  ::
>  
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21  6:11 [PATCH v3] docs: proc.rst: meminfo: briefly describe gaps in memory accounting Mike Rapoport
2021-04-21  7:00 ` Michal Hocko
2021-04-21 12:37 ` Matthew Wilcox
2021-04-23 14:27 ` Vlastimil Babka

Linux-Doc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-doc/0 linux-doc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-doc linux-doc/ https://lore.kernel.org/linux-doc \
		linux-doc@vger.kernel.org
	public-inbox-index linux-doc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-doc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git