From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, mkubecek@suse.cz,
corbet@lwn.net, vladyslavt@nvidia.com, linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next] ethtool: add missing EEPROM to list of messages
Date: Mon, 19 Apr 2021 23:45:17 +0200 [thread overview]
Message-ID: <YH357QLGqz6igLtc@lunn.ch> (raw)
In-Reply-To: <20210419212622.2993451-1-kuba@kernel.org>
On Mon, Apr 19, 2021 at 02:26:22PM -0700, Jakub Kicinski wrote:
> ETHTOOL_MSG_MODULE_EEPROM_GET is missing from the list of messages.
> ETHTOOL_MSG_MODULE_EEPROM_GET_REPLY is sadly a rather long name
> so we need to adjust column length.
>
> Fixes: c781ff12a2f3 ("ethtool: Allow network drivers to dump arbitrary EEPROM data")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Documentation/networking/ethtool-netlink.rst | 70 ++++++++++----------
> 1 file changed, 36 insertions(+), 34 deletions(-)
>
> diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
> index 48cad2fce147..c8814d787072 100644
> --- a/Documentation/networking/ethtool-netlink.rst
> +++ b/Documentation/networking/ethtool-netlink.rst
> @@ -210,45 +210,47 @@ All constants identifying message types use ``ETHTOOL_CMD_`` prefix and suffix
> ``ETHTOOL_MSG_TUNNEL_INFO_GET`` get tunnel offload info
> ``ETHTOOL_MSG_FEC_GET`` get FEC settings
> ``ETHTOOL_MSG_FEC_SET`` set FEC settings
> + ``ETHTOOL_MSG_MODULE_EEPROM_GET`` read SFP module EEPROM
It looks like you used a tab, where as the rest of the table is
spaces?
Andrew
next prev parent reply other threads:[~2021-04-19 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 21:26 [PATCH net-next] ethtool: add missing EEPROM to list of messages Jakub Kicinski
2021-04-19 21:45 ` Andrew Lunn [this message]
2021-04-19 21:50 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH357QLGqz6igLtc@lunn.ch \
--to=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=vladyslavt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).