From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5763C433ED for ; Fri, 23 Apr 2021 14:08:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6ADD061404 for ; Fri, 23 Apr 2021 14:08:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbhDWOJ2 (ORCPT ); Fri, 23 Apr 2021 10:09:28 -0400 Received: from mga14.intel.com ([192.55.52.115]:7602 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbhDWOJ1 (ORCPT ); Fri, 23 Apr 2021 10:09:27 -0400 IronPort-SDR: j/pXUwxbWynoWTmvpKD/BybvFTGtuijWRnNxTscS3fq5XkZMsziwJFxo4RBFSCDwpe5AoKUxXw C7e1weNSI8ug== X-IronPort-AV: E=McAfee;i="6200,9189,9963"; a="195629273" X-IronPort-AV: E=Sophos;i="5.82,245,1613462400"; d="scan'208";a="195629273" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 07:08:49 -0700 IronPort-SDR: WCFB/a5kjM960RwDycgkcNCtazkoWMOJGJwMuHe/qYLdJi+DPDmWkHKGz1RSl9v2M9r8+PmBBu yuOA1OH0Ue5A== X-IronPort-AV: E=Sophos;i="5.82,245,1613462400"; d="scan'208";a="385102517" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 07:08:44 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lZwU5-006Zub-9V; Fri, 23 Apr 2021 17:08:41 +0300 Date: Fri, 23 Apr 2021 17:08:41 +0300 From: Andy Shevchenko To: Rasmus Villemoes Cc: Stephen Boyd , Andrew Morton , linux-kernel@vger.kernel.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , linux-doc@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH v5 05/13] module: Add printk formats to add module build ID to stacktraces Message-ID: References: <20210420215003.3510247-1-swboyd@chromium.org> <20210420215003.3510247-6-swboyd@chromium.org> <161913520061.46595.8469966711677906076@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, Apr 23, 2021 at 03:45:56PM +0200, Rasmus Villemoes wrote: > On 23/04/2021 15.24, Andy Shevchenko wrote: > > On Thu, Apr 22, 2021 at 04:46:40PM -0700, Stephen Boyd wrote: > > >>>> +#include > >>> > >>> What do you need this header for? > >>> > >> > >> For typeof_member(). > > > > Argh... We really need to split this and container_of to something else. Having > > entire kernel.h for that is an overkill. > > > > Yeah, we should have a type-macros.h (or type-helpers or whatever) that > doesn't include any other kernel headers, just stddef.h (which is > compiler-provided) for offsetof(), providing > > typeof_member > sizeof_member > container_of > same_type > type_min > type_max > is_signed_type > __choose_type > > or whatever their names are currently. Put in my TODO list. Not sure when it will go, though. -- With Best Regards, Andy Shevchenko