From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 170A8C43460 for ; Thu, 29 Apr 2021 09:24:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAEBD6144E for ; Thu, 29 Apr 2021 09:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236871AbhD2JZ1 (ORCPT ); Thu, 29 Apr 2021 05:25:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:33476 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235125AbhD2JZ1 (ORCPT ); Thu, 29 Apr 2021 05:25:27 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1619688280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sFsswHYzmnsCtIuWtaEE2puDhfR/SZTmIoW2PDCisco=; b=YHGyFKkt5FLMqBLrnT2gKXkMJrFdXxGIaYTsZwHTkZl/aJrBSyIWADryXxu0HwVHPiX68g rmN+DZf1OlhdUd4aI/utae5zRHaqzTu9b+gp/ClXNvy1rzfYl9xTXY70yup6WHBLQUELlu NxxbuOjqbhatlpjTgDyq0oNC5djBdXE= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EB95FAFDC; Thu, 29 Apr 2021 09:24:39 +0000 (UTC) Date: Thu, 29 Apr 2021 11:24:39 +0200 From: Petr Mladek To: Andy Shevchenko Cc: Jia He , Linus Torvalds , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Jonathan Corbet , Luca Coelho , Kalle Valo , "David S. Miller" , Jakub Kicinski , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Johannes Berg , Linux Documentation List , Linux Kernel Mailing List , "open list:TI WILINK WIRELES..." , netdev , linux-s390@vger.kernel.org Subject: Re: [PATCH 2/4] lib/vsprintf.c: Make %p{D,d} mean as much components as possible Message-ID: References: <20210428135929.27011-1-justin.he@arm.com> <20210428135929.27011-2-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu 2021-04-29 11:52:49, Andy Shevchenko wrote: > On Thu, Apr 29, 2021 at 11:47 AM Petr Mladek wrote: > > > > On Wed 2021-04-28 21:59:27, Jia He wrote: > > > From: Linus Torvalds > > > > > > We have '%pD'(no digit following) for printing a filename. It may not be > > > perfect (by default it only prints one component. > > > > > > %pD4 should be more than good enough, but we should make plain "%pD" mean > > > "as much of the path that is reasonable" rather than "as few components as > > > possible" (ie 1). > > > > Could you please provide link to the discussion where this idea was > > came from? > > https://lore.kernel.org/lkml/20210427025805.GD3122264@magnolia/ Thanks for the link. I see that it was not clear whether the patch was good for %pd behavior. Linus actually suggests to keep %pd behavior as it was before, see https://lore.kernel.org/lkml/CAHk-=wimsMqGdzik187YWLb-ru+iktb4MYbMQG1rnZ81dXYFVg@mail.gmail.com/ Well, I think that this is up to the file system developers to decide. I am not sure if the path would do more harm than good, or vice versa, for dentry names. Best Regards, Petr