From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5997C433ED for ; Fri, 14 May 2021 11:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9088E6145B for ; Fri, 14 May 2021 11:47:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229681AbhENLsc (ORCPT ); Fri, 14 May 2021 07:48:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:60530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbhENLsc (ORCPT ); Fri, 14 May 2021 07:48:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C0F3461451; Fri, 14 May 2021 11:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620992841; bh=cqBDYFIise7BzFH9pyRmTy35CizPahqpg4N2b5yr9vs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BGc4UgXZHB9JW/LqevKrCXznQZ89zsJJmZfIWgQ0zuvb5o6gWseDNDgSIdTW8+HiG TQ9KG4yq1toN4IsIoFqOs9IsCavh25Q/TBpeUGesik32lXyI5g1x/jxPLpIsxDZUOZ 2tZ4HfDapfN2GGumld/cylkNEZMglMC5HasOUOQY= Date: Fri, 14 May 2021 13:47:17 +0200 From: Greg KH To: Luiz Sampaio Cc: zbr@ioremap.net, corbet@lwn.net, rikard.falkeborn@gmail.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v7 0/6] w1: ds2438: adding support for calibration of current measurements Message-ID: References: <20210409031533.442123-1-sampaio.ime@gmail.com> <20210416221739.501090-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416221739.501090-1-sampaio.ime@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, Apr 16, 2021 at 07:17:33PM -0300, Luiz Sampaio wrote: > The following patches aim to make a user able to calibrate the current > measurement of the DS2438. This chip uses a offset register in page1, which > is added to the current register to give the user the current measurement. > If this value is wrong, the user will get an offset current value, even if > the current is zero, for instance. This patch gives support for reading the > page1 registers (including the offset register) and for writing to the > offset register. The DS2438 datasheet shows a calibration routine, and with > this patch, the user can do this quickly by writing the correct value to > the offset register. This patch was tested on real hardware using a power > supply and an electronic load. > Please help to review this series of patches. > > Best regards! > Sampaio > --- > Changes in v7: > - Build test again Can you fix the warning in patch 6/6 that the kernel test robot found, and resend? thanks, greg k-h