From: Petr Mladek <pmladek@suse.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Baoquan He <bhe@redhat.com>, Borislav Petkov <bp@alien8.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Young <dyoung@redhat.com>, Evan Green <evgreen@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Ingo Molnar <mingo@redhat.com>, Jessica Yu <jeyu@kernel.org>,
Jiri Olsa <jolsa@kernel.org>,
kexec@lists.infradead.org,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sasha Levin <sashal@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vivek Goyal <vgoyal@redhat.com>, Will Deacon <will@kernel.org>,
x86@kernel.org, Christoph Hellwig <hch@infradead.org>,
peter enderborg <peter.enderborg@sony.com>
Subject: Re: [PATCH v6 00/13] Add build ID to stacktraces
Date: Tue, 11 May 2021 13:48:06 +0200 [thread overview]
Message-ID: <YJpu9mC8J+Kb6qWg@alley> (raw)
In-Reply-To: <20210511003845.2429846-1-swboyd@chromium.org>
On Mon 2021-05-10 17:38:32, Stephen Boyd wrote:
> This series adds the kernel's build ID[1] to the stacktrace header
> printed in oops messages, warnings, etc. and the build ID for any module
> that appears in the stacktrace after the module name. The goal is to
> make the stacktrace more self-contained and descriptive by including the
> relevant build IDs in the kernel logs when something goes wrong. This
> can be used by post processing tools like script/decode_stacktrace.sh
> and kernel developers to easily locate the debug info associated with a
> kernel crash and line up what line and file things started falling apart
> at.
The entire series looks good to me.
I reviewed carefully only the 5th patch touching printk/kallsyms/module
code. I just scanned over the other patches touching kernel code
and did not notice any obvious problem. I did not check the changes
in decode_stacktrace.sh at all.
I tried to get stacktraces on x86_64 and it worked as expected.
Best Regards,
Petr
next prev parent reply other threads:[~2021-05-11 11:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 0:38 [PATCH v6 00/13] Add build ID to stacktraces Stephen Boyd
2021-05-11 0:38 ` [PATCH v6 05/13] module: Add printk formats to add module " Stephen Boyd
2021-05-11 11:35 ` Petr Mladek
2021-05-11 16:51 ` Stephen Boyd
2021-05-11 11:48 ` Petr Mladek [this message]
2021-05-11 12:36 ` [PATCH v6 00/13] Add " David Laight
2021-05-11 12:52 ` Steven Rostedt
2021-05-11 12:58 ` David Laight
2021-05-11 14:21 ` Petr Mladek
2021-05-11 14:31 ` David Laight
2021-05-11 14:35 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJpu9mC8J+Kb6qWg@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ast@kernel.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dyoung@redhat.com \
--cc=evgreen@chromium.org \
--cc=hch@infradead.org \
--cc=hsinyi@chromium.org \
--cc=jeyu@kernel.org \
--cc=jolsa@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=peter.enderborg@sony.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).