From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6FC0C433B4 for ; Tue, 11 May 2021 11:48:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1229613BD for ; Tue, 11 May 2021 11:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231327AbhEKLtP (ORCPT ); Tue, 11 May 2021 07:49:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:59398 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230400AbhEKLtO (ORCPT ); Tue, 11 May 2021 07:49:14 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1620733687; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E77vEFrSkLVZEEYzBk3YTtVmGYYbCEngbIKXJXgn1lE=; b=FNKlUt0qKP32FkKDSjrlOl6Sj4jbJTnqDhgVkis/5HueyFUMy8THzXQVH+tlqPzA6eAp+4 AXbvT6dCpaGb/pCnMLjaokfdl4GXL5yqkWfD2wmXCC7jZqel7+xnUKJXK3JmahwhZ3Z/72 5KgGPpFq70MJRQXZ0D0W3XZdygmA7AQ= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2EC02B1B5; Tue, 11 May 2021 11:48:07 +0000 (UTC) Date: Tue, 11 May 2021 13:48:06 +0200 From: Petr Mladek To: Stephen Boyd Cc: Andrew Morton , linux-kernel@vger.kernel.org, Alexei Starovoitov , Andy Shevchenko , Baoquan He , Borislav Petkov , Catalin Marinas , Dave Young , Evan Green , Hsin-Yi Wang , Ingo Molnar , Jessica Yu , Jiri Olsa , kexec@lists.infradead.org, Konstantin Khlebnikov , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, Matthew Wilcox , Rasmus Villemoes , Sasha Levin , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , Vivek Goyal , Will Deacon , x86@kernel.org, Christoph Hellwig , peter enderborg Subject: Re: [PATCH v6 00/13] Add build ID to stacktraces Message-ID: References: <20210511003845.2429846-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210511003845.2429846-1-swboyd@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon 2021-05-10 17:38:32, Stephen Boyd wrote: > This series adds the kernel's build ID[1] to the stacktrace header > printed in oops messages, warnings, etc. and the build ID for any module > that appears in the stacktrace after the module name. The goal is to > make the stacktrace more self-contained and descriptive by including the > relevant build IDs in the kernel logs when something goes wrong. This > can be used by post processing tools like script/decode_stacktrace.sh > and kernel developers to easily locate the debug info associated with a > kernel crash and line up what line and file things started falling apart > at. The entire series looks good to me. I reviewed carefully only the 5th patch touching printk/kallsyms/module code. I just scanned over the other patches touching kernel code and did not notice any obvious problem. I did not check the changes in decode_stacktrace.sh at all. I tried to get stacktraces on x86_64 and it worked as expected. Best Regards, Petr