From: Boqun Feng <boqun.feng@gmail.com>
To: Xiongwei Song <sxwjean@me.com>
Cc: peterz@infradead.org, mingo@redhat.com, will@kernel.org,
longman@redhat.com, corbet@lwn.net, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Xiongwei Song <sxwjean@gmail.com>
Subject: Re: [PATCH] docs: lockdep-design: improve readability of the block matrix
Date: Thu, 27 May 2021 11:30:14 +0800 [thread overview]
Message-ID: <YK8SRvhp1+iR2y6G@boqun-archlinux> (raw)
In-Reply-To: <1621868745-23311-1-git-send-email-sxwjean@me.com>
On Mon, May 24, 2021 at 11:05:45PM +0800, Xiongwei Song wrote:
> From: Xiongwei Song <sxwjean@gmail.com>
>
> The block condition matrix is using 'E' as the writer notation, however,
> the writer reminder below the matrix is using 'W', to make them consistent
> and make the matrix more readable, we'd better to use 'W' to represent
> writer.
>
> Suggested-by: Waiman Long <llong@redhat.com>
> Suggested-by: Boqun Feng <boqun.feng@gmail.com>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Regards,
Boqun
> ---
> Documentation/locking/lockdep-design.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
> index 9f3cfca..82f36ca 100644
> --- a/Documentation/locking/lockdep-design.rst
> +++ b/Documentation/locking/lockdep-design.rst
> @@ -453,9 +453,9 @@ There are simply four block conditions:
> Block condition matrix, Y means the row blocks the column, and N means otherwise.
>
> +---+---+---+---+
> - | | E | r | R |
> + | | W | r | R |
> +---+---+---+---+
> - | E | Y | Y | Y |
> + | W | Y | Y | Y |
> +---+---+---+---+
> | r | Y | Y | N |
> +---+---+---+---+
> --
> 2.7.4
>
next prev parent reply other threads:[~2021-05-27 3:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 15:05 [PATCH] docs: lockdep-design: improve readability of the block matrix Xiongwei Song
2021-05-27 3:30 ` Boqun Feng [this message]
2021-05-27 7:04 ` Peter Zijlstra
2021-05-27 13:37 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK8SRvhp1+iR2y6G@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sxwjean@gmail.com \
--cc=sxwjean@me.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).