From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: dri-devel@lists.freedesktop.org,
"Daniel Vetter" <daniel.vetter@intel.com>,
"David Airlie" <airlied@linux.ie>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
linux-doc@vger.kernel.org, "Jonathan Corbet" <corbet@lwn.net>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Alison Wang" <alison.wang@nxp.com>,
"Alyssa Rosenzweig" <alyssa.rosenzweig@collabora.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Anitha Chrisanthus" <anitha.chrisanthus@intel.com>,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Boris Brezillon" <bbrezillon@kernel.org>,
"Brian Starkey" <brian.starkey@arm.com>,
"Chen Feng" <puck.chen@hisilicon.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Christian Gmeiner" <christian.gmeiner@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
"Edmund Dea" <edmund.j.dea@intel.com>,
"Eric Anholt" <eric@anholt.net>,
"Fabio Estevam" <festevam@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Haneen Mohammed" <hamohammed.sa@gmail.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Huang Rui" <ray.huang@amd.com>,
"Hyun Kwon" <hyun.kwon@xilinx.com>,
"Inki Dae" <inki.dae@samsung.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Joel Stanley" <joel@jms.id.au>,
"John Stultz" <john.stultz@linaro.org>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Joonyoung Shim" <jy0922.shim@samsung.com>,
"Jyri Sarha" <jyri.sarha@iki.fi>,
"Kevin Hilman" <khilman@baylibre.com>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Liviu Dudau" <liviu.dudau@arm.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Ludovic Desroches" <ludovic.desroches@microchip.com>,
"Marek Vasut" <marex@denx.de>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Melissa Wen" <melissa.srw@gmail.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Oleksandr Andrushchenko" <oleksandr_andrushchenko@epam.com>,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Philippe Cornu" <philippe.cornu@foss.st.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Qiang Yu" <yuq825@gmail.com>, "Rob Clark" <robdclark@gmail.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Rodrigo Siqueira" <rodrigosiqueiramelo@gmail.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Roland Scheidegger" <sroland@vmware.com>,
"Russell King" <linux@armlinux.org.uk>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Sandy Huang" <hjc@rock-chips.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Sean Paul" <sean@poorly.run>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Stefan Agner" <stefan@agner.ch>,
"Steven Price" <steven.price@arm.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Tian Tao" <tiantao6@hisilicon.com>,
"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
"Tomi Valkeinen" <tomba@kernel.org>,
"VMware Graphics" <linux-graphics-maintainer@vmware.com>,
"Xinliang Liu" <xinliang.liu@linaro.org>,
"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
"Yannick Fertre" <yannick.fertre@foss.st.com>,
"Zack Rusin" <zackr@vmware.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v2] Documentation: gpu: Mention the requirements for new properties
Date: Mon, 24 May 2021 07:04:43 +0300 [thread overview]
Message-ID: <YKsl2xGgTnIuQLaE@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210520142435.267873-1-maxime@cerno.tech>
Hi Maxime,
Thank you for the patch.
On Thu, May 20, 2021 at 04:24:35PM +0200, Maxime Ripard wrote:
> New KMS properties come with a bunch of requirements to avoid each
> driver from running their own, inconsistent, set of properties,
> eventually leading to issues like property conflicts, inconsistencies
> between drivers and semantics, etc.
>
> Let's document what we expect.
>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Alison Wang <alison.wang@nxp.com>
> Cc: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Cc: Brian Starkey <brian.starkey@arm.com>
> Cc: Chen Feng <puck.chen@hisilicon.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Edmund Dea <edmund.j.dea@intel.com>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Haneen Mohammed <hamohammed.sa@gmail.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: "Heiko Stübner" <heiko@sntech.de>
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Inki Dae <inki.dae@samsung.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Jernej Skrabec <jernej.skrabec@siol.net>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Joonyoung Shim <jy0922.shim@samsung.com>
> Cc: Jyri Sarha <jyri.sarha@iki.fi>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Melissa Wen <melissa.srw@gmail.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: "Noralf Trønnes" <noralf@tronnes.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> Cc: Paul Cercueil <paul@crapouillou.net>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Philippe Cornu <philippe.cornu@foss.st.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Qiang Yu <yuq825@gmail.com>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Roland Scheidegger <sroland@vmware.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stefan Agner <stefan@agner.ch>
> Cc: Steven Price <steven.price@arm.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Tian Tao <tiantao6@hisilicon.com>
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: Tomi Valkeinen <tomba@kernel.org>
> Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
> Cc: Xinliang Liu <xinliang.liu@linaro.org>
> Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Cc: Yannick Fertre <yannick.fertre@foss.st.com>
> Cc: Zack Rusin <zackr@vmware.com>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> ---
>
> Changes from v2:
> - Typos and wording reported by Daniel and Alex
> ---
> Documentation/gpu/drm-kms.rst | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst
> index 87e5023e3f55..c28b464dd397 100644
> --- a/Documentation/gpu/drm-kms.rst
> +++ b/Documentation/gpu/drm-kms.rst
> @@ -463,6 +463,25 @@ KMS Properties
> This section of the documentation is primarily aimed at user-space developers.
> For the driver APIs, see the other sections.
>
> +Requirements
> +------------
> +
> +KMS drivers might need to add extra properties to support new features.
> +Each new property introduced in a driver need to meet a few
s/need/needs/
> +requirements, in addition to the one mentioned above.:
s/above./above/
> +
> +- It must be standardized, with some documentation to describe how the
> + property can be used.
> +
> +- It must provide a generic helper in the core code to register that
> + property on the object it attaches to.
> +
> +- Its content must be decoded by the core and provided in the object's
> + associated state structure. That includes anything drivers might want to
> + precompute, like :c:type:`struct drm_clip_rect <drm_clip_rect>` for planes.
Does this effectively mean that we completely forbid driver-specific
properties ? While I agree that we should strive for standardization,
there are two issues that worry me. The first one is simple, we may need
to control features that would be very device-specific, and
standardizing properties doesn't seem to make much sense in that case.
The second issue relates to properties that could be applicable to
multiple devices, but for which we have a single driver. Designing a
standard with a single data point usually leads to a bad design. I'm not
sure how to handle this correctly though, as we certainly don't want
this to be taken as an excuse to create driver-specific properties when
generic properties would make sense.
> +- An IGT test must be submitted where reasonable.
> +
> Property Types and Blob Property Support
> ----------------------------------------
>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-05-24 4:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 14:24 [PATCH v2] Documentation: gpu: Mention the requirements for new properties Maxime Ripard
2021-05-24 4:04 ` Laurent Pinchart [this message]
2021-05-25 10:39 ` Maxime Ripard
2021-05-27 15:14 ` Liviu Dudau
2021-05-27 15:53 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKsl2xGgTnIuQLaE@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alison.wang@nxp.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=andrew@aj.id.au \
--cc=anitha.chrisanthus@intel.com \
--cc=bbrezillon@kernel.org \
--cc=benjamin.gaignard@linaro.org \
--cc=brian.starkey@arm.com \
--cc=bskeggs@redhat.com \
--cc=christian.gmeiner@gmail.com \
--cc=christian.koenig@amd.com \
--cc=chunkuang.hu@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=eric@anholt.net \
--cc=festevam@gmail.com \
--cc=hamohammed.sa@gmail.com \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=hyun.kwon@xilinx.com \
--cc=inki.dae@samsung.com \
--cc=jani.nikula@linux.intel.com \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@siol.net \
--cc=joel@jms.id.au \
--cc=john.stultz@linaro.org \
--cc=jonas@kwiboo.se \
--cc=jonathanh@nvidia.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jy0922.shim@samsung.com \
--cc=jyri.sarha@iki.fi \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kraxel@redhat.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kyungmin.park@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-imx@nxp.com \
--cc=linux@armlinux.org.uk \
--cc=liviu.dudau@arm.com \
--cc=ludovic.desroches@microchip.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime@cerno.tech \
--cc=mcoquelin.stm32@gmail.com \
--cc=melissa.srw@gmail.com \
--cc=mripard@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=noralf@tronnes.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=p.zabel@pengutronix.de \
--cc=patrik.r.jakobsson@gmail.com \
--cc=paul@crapouillou.net \
--cc=philippe.cornu@foss.st.com \
--cc=puck.chen@hisilicon.com \
--cc=ray.huang@amd.com \
--cc=robdclark@gmail.com \
--cc=robert.foss@linaro.org \
--cc=robh@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=sroland@vmware.com \
--cc=stefan@agner.ch \
--cc=steven.price@arm.com \
--cc=sumit.semwal@linaro.org \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=tiantao6@hisilicon.com \
--cc=tomba@kernel.org \
--cc=tomeu.vizoso@collabora.com \
--cc=tzimmermann@suse.de \
--cc=wens@csie.org \
--cc=xinliang.liu@linaro.org \
--cc=yannick.fertre@foss.st.com \
--cc=yuq825@gmail.com \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).