From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 967AAC48BE6 for ; Mon, 14 Jun 2021 10:18:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78105611AB for ; Mon, 14 Jun 2021 10:18:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232752AbhFNKU4 (ORCPT ); Mon, 14 Jun 2021 06:20:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232691AbhFNKUz (ORCPT ); Mon, 14 Jun 2021 06:20:55 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71204C061574; Mon, 14 Jun 2021 03:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NhIEo9sT28glTkM4CxprF+qgzCzmmeIS6U+43P+3xf0=; b=CaSvsj9J4I01ytahIOFo+aG8Jv Wii8P4OUN18F3+xTqrL6LYLIBdU+beXTS3ohY9cnjAOBHka16OM/VG9QAPWYHhbeI6Ygh/+93xFaI EJTw2DzHMYNenFtpJ4mrZ/UmrucjMOYCY9SKLITq5+7XO+v/YeSvY6EbYyAVAvKFNOLKvBJXY8SwN DJaxaq+MJEtg4yREyAJieFeQ2XcUX3WcCvumbVVjuaIK5bTApqvelqF4tLPTkH5k7077lmFUHF8pa gz3AHaspUYnzmM/Y/1cbGrpi9Cih5nAvdo1pO7z4r3ZnPsMDdc4DcQzZFCSmbCFIoiRqApZ8Kxeui 0BmHtICg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsjfs-00706g-Mx; Mon, 14 Jun 2021 10:18:39 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5A7C73001E3; Mon, 14 Jun 2021 12:18:38 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 43BBA2C5DAE9B; Mon, 14 Jun 2021 12:18:38 +0200 (CEST) Date: Mon, 14 Jun 2021 12:18:38 +0200 From: Peter Zijlstra To: Bill Wendling Cc: Kees Cook , Jonathan Corbet , Masahiro Yamada , Linux Doc Mailing List , LKML , Linux Kbuild mailing list , clang-built-linux , Andrew Morton , Nathan Chancellor , Nick Desaulniers , Sami Tolvanen , Fangrui Song , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , andreyknvl@gmail.com, dvyukov@google.com, elver@google.com, johannes.berg@intel.com, oberpar@linux.vnet.ibm.com, mliska@suse.cz Subject: Re: [PATCH v9] pgo: add clang's Profile Guided Optimization infrastructure Message-ID: References: <20210407211704.367039-1-morbo@google.com> <20210612202505.GG68208@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Jun 14, 2021 at 11:43:12AM +0200, Peter Zijlstra wrote: > On Sun, Jun 13, 2021 at 11:07:26AM -0700, Bill Wendling wrote: > > > > > Now, for the "nointr" issue. I'll see if we need an additional change for that. > > > > > > > The GCOV implementation disables profiling in those directories where > > > instrumentation would fail. We do the same. Both clang and gcc seem to > > > treat the no_instrument_function attribute similarly. > > Both seem to emit instrumentation, so they're both, simliarly, *broken*. > > noinstr *MUST* disable all compiler generated instrumentation. Also see: > > https://lkml.kernel.org/r/20210527194448.3470080-1-elver@google.com > > I'll go mark GCOV support as BROKEN for x86. https://lkml.kernel.org/r/YMcssV/n5IBGv4f0@hirez.programming.kicks-ass.net