From: Matthew Wilcox <willy@infradead.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: linux-doc@vger.kernel.org, kernel test robot <lkp@intel.com>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Nick Terrell <terrelln@fb.com>,
Schspa Shi <schspa@gmail.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: zstd: add missing function name in zstd_reclaim_timer_fn() comment
Date: Sun, 17 Apr 2022 04:16:40 +0100 [thread overview]
Message-ID: <YluGmERvtQY9ju7Y@casper.infradead.org> (raw)
In-Reply-To: <20220416081534.28729-1-bagasdotme@gmail.com>
On Sat, Apr 16, 2022 at 03:15:34PM +0700, Bagas Sanjaya wrote:
> kernel test robot reports kernel-doc warning:
>
> >> fs/btrfs/zstd.c:98: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
This is the wrong fix. Static functions should not have kernel-doc
comments. Just delete the second '*' at the head of the comment.
Also, btrfs developers should be testing with W=1. That will catch
these problems before the code is integrated.
next prev parent reply other threads:[~2022-04-17 3:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 8:15 [PATCH] btrfs: zstd: add missing function name in zstd_reclaim_timer_fn() comment Bagas Sanjaya
2022-04-17 3:16 ` Matthew Wilcox [this message]
2022-04-17 5:14 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YluGmERvtQY9ju7Y@casper.infradead.org \
--to=willy@infradead.org \
--cc=bagasdotme@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=schspa@gmail.com \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).