From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11955C282DD for ; Fri, 10 Jan 2020 16:30:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D83C6206ED for ; Fri, 10 Jan 2020 16:30:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728513AbgAJQac (ORCPT ); Fri, 10 Jan 2020 11:30:32 -0500 Received: from mga18.intel.com ([134.134.136.126]:20536 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727928AbgAJQac (ORCPT ); Fri, 10 Jan 2020 11:30:32 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 08:30:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,417,1571727600"; d="scan'208";a="224241394" Received: from nehudak-mobl1.amr.corp.intel.com (HELO [10.251.145.164]) ([10.251.145.164]) by orsmga003.jf.intel.com with ESMTP; 10 Jan 2020 08:30:30 -0800 Subject: Re: [alsa-devel] [PATCH 2/6] soundwire: stream: update state machine and add state checks To: Vinod Koul Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com, Bard liao , Rander Wang , Ranjani Sridharan , Sanyog Kale , Jonathan Corbet , "open list:DOCUMENTATION" References: <20200108175438.13121-1-pierre-louis.bossart@linux.intel.com> <20200108175438.13121-3-pierre-louis.bossart@linux.intel.com> <20200110064838.GY2818@vkoul-mobl> From: Pierre-Louis Bossart Message-ID: Date: Fri, 10 Jan 2020 10:30:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200110064838.GY2818@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org >> - int sdw_prepare_stream(struct sdw_stream_runtime * stream); >> + int sdw_prepare_stream(struct sdw_stream_runtime * stream, bool resume); > > so what does the additional argument of resume do..? > >> diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c >> index 178ae92b8cc1..6aa0b5d370c0 100644 >> --- a/drivers/soundwire/stream.c >> +++ b/drivers/soundwire/stream.c >> @@ -1553,8 +1553,18 @@ int sdw_prepare_stream(struct sdw_stream_runtime *stream) > > and it is not modified here, so is the doc correct or this..? the doc is correct and the code is updated in [PATCH 4/6] soundwire: stream: do not update parameters during DISABLED-PREPARED transition