From: Sourabh Jain <sourabhjain@linux.ibm.com>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: corbet@lwn.net, mahesh@linux.vnet.ibm.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, hbathini@linux.ibm.com
Subject: Re: [PATCH v3 2/4] powerpc/fadump: reorganize /sys/kernel/fadump_* sysfs files
Date: Tue, 3 Dec 2019 16:50:32 +0530 [thread overview]
Message-ID: <a279ce08-89a4-d8e2-1364-b2b29f9a6433@linux.ibm.com> (raw)
In-Reply-To: <20191124184059.GP11661@kitsune.suse.cz>
>>>> DEFINE_SHOW_ATTRIBUTE(fadump_region);
>>>>
>>>> static void fadump_init_files(void)
>>>> @@ -1435,6 +1448,11 @@ static void fadump_init_files(void)
>>>> struct dentry *debugfs_file;
>>>> int rc = 0;
>>>>
>>>> + fadump_kobj = kobject_create_and_add("fadump", kernel_kobj);
>>>> + if (!fadump_kobj) {
>>>> + pr_err("failed to create fadump kobject\n");
>>>> + return;
>>>> + }
>>>> rc = sysfs_create_file(kernel_kobj, &fadump_attr.attr);
>>>> if (rc)
>>>> printk(KERN_ERR "fadump: unable to create sysfs file"
>>>> @@ -1458,6 +1476,26 @@ static void fadump_init_files(void)
>>>> printk(KERN_ERR "fadump: unable to create sysfs file"
>>>> " fadump_release_mem (%d)\n", rc);
>>>> }
>>>> + /* Replicating the following sysfs attributes under FADump kobject.
>>>> + *
>>>> + * - fadump_enabled -> enabled
>>>> + * - fadump_registered -> registered
>>>> + * - fadump_release_mem -> release_mem
>>>> + */
>>>> + rc = sysfs_create_file(fadump_kobj, &enable_attr.attr);
>>>> + if (rc)
>>>> + pr_err("unable to create enabled sysfs file (%d)\n",
>>>> + rc);
>>>> + rc = sysfs_create_file(fadump_kobj, ®ister_attr.attr);
>>>> + if (rc)
>>>> + pr_err("unable to create registered sysfs file (%d)\n",
>>>> + rc);
>>>> + if (fw_dump.dump_active) {
>>>> + rc = sysfs_create_file(fadump_kobj, &release_attr.attr);
>>>> + if (rc)
>>>> + pr_err("unable to create release_mem sysfs file (%d)\n",
>>>> + rc);
>>>> + }
>>>> return;
>>>> }
>>> Hello,
>>>
>>
>> I’m so sorry for taking this long to write you back.
>>
>>> wouldn't it make more sense to create the files in the new location and
>>> add a symlink at the old location?
>>
>> There are APIs which allow to create a symlink for an entire kobject but
>> I did not find a way to create symlink of an individual sysfs file.
>>
>> Do you have any approach in mind to achieve the same?
>
> There is at least one example of plain symlink:
>
> find /sys -type l -xtype f
> /sys/kernel/security/evm
>
> If there is no interface to do one sanely duplicationg the files is
> better than nothing.
Hello Michal,
I found a function (__compat_only_sysfs_link_entry_to_kobj) that adds a symlink
to a kobject.
But the problem is __compat_only_sysfs_link_entry_to_kobj function keeps the
symlink file name similar to sysfs file and has no option to change it.
We can't use the __compat_only_sysfs_link_entry_to_kobj function directly because
our symlink file name must be different from the target file name.
fadump_enabled -> fadump/enabled
But the good thing is we can tweak the __compat_only_sysfs_link_entry_to_kobj
function and allow the caller to change the sysmlink file name.
So I am writing a separate patch that adds a wrapper function around the __compat_only_sysfs_link_entry_to_kobj function which will allow to have a custom symlink file name.
Thanks,
Sourabh Jain
next prev parent reply other threads:[~2019-12-03 11:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 12:23 [PATCH v3 0/4] reorganize and add FADump sysfs files Sourabh Jain
2019-11-09 12:23 ` [PATCH v3 1/4] Documentation/ABI: add ABI documentation for /sys/kernel/fadump_* Sourabh Jain
2019-11-09 12:23 ` [PATCH v3 2/4] powerpc/fadump: reorganize /sys/kernel/fadump_* sysfs files Sourabh Jain
2019-11-09 12:59 ` Michal Suchánek
2019-11-16 14:37 ` Sourabh Jain
2019-11-24 18:40 ` Michal Suchánek
2019-11-27 4:54 ` Sourabh Jain
2019-12-03 11:20 ` Sourabh Jain [this message]
2019-11-23 11:21 ` kbuild test robot
2019-11-09 12:23 ` [PATCH v3 3/4] Documentation/ABI: mark /sys/kernel/fadump_* sysfs files deprecated Sourabh Jain
2019-11-09 12:23 ` [PATCH v3 4/4] powerpc/fadump: sysfs for fadump memory reservation Sourabh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a279ce08-89a4-d8e2-1364-b2b29f9a6433@linux.ibm.com \
--to=sourabhjain@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=hbathini@linux.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).