From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE28C7EE29 for ; Fri, 9 Jun 2023 17:46:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229692AbjFIRqn (ORCPT ); Fri, 9 Jun 2023 13:46:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbjFIRql (ORCPT ); Fri, 9 Jun 2023 13:46:41 -0400 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3A85E4E for ; Fri, 9 Jun 2023 10:46:30 -0700 (PDT) Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-77ada5cacd9so55417039f.3 for ; Fri, 09 Jun 2023 10:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686332790; x=1688924790; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ORN9WVquc1eDa/NSYBsODEMAyXT/sC/8w6SXWS7Qzgo=; b=fzsnU9EoqafeV7Cn73ofchOoBCacaYnZUnIOw7tL8zNyqaxJs4nTNt0evUic6C65tq qE6DW7IgcvWLEivIP6r42+q3oN77yHyRpK5Mj6Cy3c8hZ7HA/sm43fuRoSJ5+H9PJjzu 50HWDhOJy7qrVxtNvrjuuWsaO/EOfdFzpXgnqaAHTZvz2+RwI5iaroHa8Hwt9ol3QoWs jBD5q/6FQIHxrrcegz3/vuEARZdmu2uu5YFkKD5CCVou8U+O9FvAyBwRc5dUTHKg3RtF U9AvH1RKRcXrz7Zq8B7TidkYyvB1rp0prVXkXmJl0IW4iBYwuQvHiM081/3u5XUAyq2O HkFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686332790; x=1688924790; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ORN9WVquc1eDa/NSYBsODEMAyXT/sC/8w6SXWS7Qzgo=; b=N6rU8NrAFikj4p5XBSxmLy6+5cTwXWEPAw76u0vgGRRqVvx4/nbAWphKPza6r5bcEm 0rpkW+s4Eh/m/QIVJfGoMk6MuvOMVaopHi/lufBdY5KMjIGKXTuYlgEw0M2jhzsMAZxP bWu+KMY3rYCm6q1YSJsu0qAPkmjUXGDaokr/M4ANJp5Ibiymx0Xn9X9m6sLZ5kydTK5c +PwUaVfaxHmhvkM4JQtGjhHTnWSrZJOlsyT3hkAI1WBSLwy6PP86lRHffY1/aXDcLziw w+YFWVnLdIb3/3iqzSOEPz0OWX8Ul/X0vHLZYKILF1W5P/cR3Yv3TFDZUCk5G9JSkd9e ejMA== X-Gm-Message-State: AC+VfDxZVb98C1rHJs976tlRwOM7eHEI8cPHgT+moxtSc2pvzf+kIrAK pHvXoi79V5OI2gwpiBmlwsibMA== X-Google-Smtp-Source: ACHHUZ47AG3wAglH5Pw0GaXvZRnB3BfoAgvmfvevkXVlgMtgzr6hM2rkymQ7qMD3eChz4oaVWxieBg== X-Received: by 2002:a05:6602:2747:b0:774:8786:1b59 with SMTP id b7-20020a056602274700b0077487861b59mr2513455ioe.11.1686332790231; Fri, 09 Jun 2023 10:46:30 -0700 (PDT) Received: from [172.22.22.28] ([98.61.227.136]) by smtp.gmail.com with ESMTPSA id a22-20020a5d89d6000000b007747a6d875csm1190529iot.9.2023.06.09.10.46.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 10:46:29 -0700 (PDT) Message-ID: Date: Fri, 9 Jun 2023 12:46:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v13 23/24] virt: gunyah: Add ioeventfd Content-Language: en-US To: Elliot Berman , Srinivas Kandagatla , Prakruthi Deepak Heragu , Jonathan Corbet Cc: Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Bagas Sanjaya , Will Deacon , Andy Gross , Catalin Marinas , Jassi Brar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230509204801.2824351-1-quic_eberman@quicinc.com> <20230509204801.2824351-24-quic_eberman@quicinc.com> <85e7c3ae-0991-0ca9-909c-f38773f63894@linaro.org> <2f60fc9f-a8b2-fe8c-183a-5ee9b276b02d@quicinc.com> From: Alex Elder In-Reply-To: <2f60fc9f-a8b2-fe8c-183a-5ee9b276b02d@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 6/9/23 12:33 PM, Elliot Berman wrote: >>> +static int gh_write_ioeventfd(struct gh_vm_io_handler *io_dev, u64 >>> addr, u32 len, u64 data) >>> +{ >>> +    struct gh_ioeventfd *iofd = container_of(io_dev, struct >>> gh_ioeventfd, io_handler); >> >> Does a write of 0 bytes still signal an event? >> > > From gunyah_ioeventfd perspective, yes. I don't think a write of 0 > bytes is possible, but maybe you are thinking of scenario I'm not? > >>> + >>> +    eventfd_signal(iofd->ctx, 1); >>> +    return 0; >>> +} No, I was just observing that eventfd_signal() is called regardless of the value of len. -Alex