From: Chanwoo Choi <cwchoi00@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 08/22] devfreq: shut up kernel-doc warnings
Date: Thu, 30 Jun 2022 04:31:50 +0900 [thread overview]
Message-ID: <b6abe557-029d-cf2b-db79-40630fafb5f1@gmail.com> (raw)
In-Reply-To: <6a15081e17d78e914526c315d5bb53ea575edf90.1656409369.git.mchehab@kernel.org>
On 22. 6. 28. 18:46, Mauro Carvalho Chehab wrote:
> There are 4 warnings there:
> drivers/devfreq/devfreq.c:707: warning: Function parameter or member 'val' not described in 'qos_min_notifier_call'
> drivers/devfreq/devfreq.c:707: warning: Function parameter or member 'ptr' not described in 'qos_min_notifier_call'
> drivers/devfreq/devfreq.c:717: warning: Function parameter or member 'val' not described in 'qos_max_notifier_call'
> drivers/devfreq/devfreq.c:717: warning: Function parameter or member 'ptr' not described in 'qos_max_notifier_call'
>
> It turns that neither val nor ptr are actually used on those
> function, so document as such.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/22] at: https://lore.kernel.org/all/cover.1656409369.git.mchehab@kernel.org/
>
> drivers/devfreq/devfreq.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 01474daf4548..3020855d8400 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -700,6 +700,8 @@ static int qos_notifier_call(struct devfreq *devfreq)
> /**
> * qos_min_notifier_call() - Callback for QoS min_freq changes.
> * @nb: Should be devfreq->nb_min
> + * @val: not used
> + * @ptr: not used
> */
> static int qos_min_notifier_call(struct notifier_block *nb,
> unsigned long val, void *ptr)
> @@ -710,6 +712,8 @@ static int qos_min_notifier_call(struct notifier_block *nb,
> /**
> * qos_max_notifier_call() - Callback for QoS max_freq changes.
> * @nb: Should be devfreq->nb_max
> + * @val: not used
> + * @ptr: not used
> */
> static int qos_max_notifier_call(struct notifier_block *nb,
> unsigned long val, void *ptr)
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
next prev parent reply other threads:[~2022-06-29 19:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 9:46 [PATCH 00/22] Fix kernel-doc warnings at linux-next Mauro Carvalho Chehab
2022-06-28 9:46 ` [PATCH 01/22] net: cfg80211: fix kernel-doc warnings all over the file Mauro Carvalho Chehab
2022-06-28 9:46 ` [PATCH 02/22] net: mac80211: add a missing comma at kernel-doc markup Mauro Carvalho Chehab
2022-06-28 17:09 ` Jeff Johnson
2022-06-28 9:46 ` [PATCH 03/22] net: mac80211: sta_info: fix a missing kernel-doc struct element Mauro Carvalho Chehab
2022-06-28 9:46 ` [PATCH 04/22] x86/sgx: fix kernel-doc markups Mauro Carvalho Chehab
2022-06-29 2:34 ` Jarkko Sakkinen
2022-07-06 17:15 ` Dave Hansen
2022-06-28 9:46 ` [PATCH 05/22] fscache: fix kernel-doc documentation Mauro Carvalho Chehab
2022-06-28 9:46 ` [PATCH 06/22] fs: attr: update vfs uid/gid parameters at kernel-doc Mauro Carvalho Chehab
2022-06-28 10:17 ` Christian Brauner
2022-06-28 9:46 ` [PATCH 07/22] fs: namei: address some kernel-doc issues Mauro Carvalho Chehab
2022-06-28 9:46 ` [PATCH 08/22] devfreq: shut up kernel-doc warnings Mauro Carvalho Chehab
2022-06-29 19:31 ` Chanwoo Choi [this message]
2022-06-28 9:46 ` [PATCH 09/22] drm: amdgpu: amdgpu_dm: fix kernel-doc markups Mauro Carvalho Chehab
2022-06-28 14:36 ` Alex Deucher
2022-06-28 9:46 ` [PATCH 10/22] drm: amdgpu: amdgpu_device.c: fix a kernel-doc markup Mauro Carvalho Chehab
2022-06-28 14:37 ` Alex Deucher
2022-06-28 9:46 ` [PATCH 11/22] drm: amd: amd_shared.h: Add missing doc for PP_GFX_DCS_MASK Mauro Carvalho Chehab
2022-06-28 14:38 ` Alex Deucher
2022-06-28 9:46 ` [PATCH 12/22] drm: gpu_scheduler: fix a kernel-doc warning Mauro Carvalho Chehab
2022-06-28 14:42 ` Alex Deucher
2022-06-28 9:46 ` [PATCH 13/22] drm: scheduler: add a missing kernel-doc parameter Mauro Carvalho Chehab
2022-06-28 14:42 ` Alex Deucher
2022-06-28 9:46 ` [PATCH 14/22] kfence: fix a " Mauro Carvalho Chehab
2022-06-28 9:48 ` Marco Elver
2022-06-28 9:46 ` [PATCH 15/22] mm: document maple tree pointer at unmap_vmas() at memory.c Mauro Carvalho Chehab
2022-06-29 0:25 ` Liam Howlett
2022-06-28 9:46 ` [PATCH 16/22] genalloc: add a description for start_addr parameter Mauro Carvalho Chehab
2022-06-28 9:46 ` [PATCH 17/22] textsearch: document list inside struct ts_ops Mauro Carvalho Chehab
2022-06-28 9:46 ` [PATCH 18/22] regulator: fix a kernel-doc warning Mauro Carvalho Chehab
2022-06-28 10:35 ` Mark Brown
2022-06-28 11:07 ` Mauro Carvalho Chehab
2022-06-28 11:11 ` Mark Brown
2022-06-28 9:46 ` [PATCH 19/22] dcache: " Mauro Carvalho Chehab
2022-06-28 9:46 ` [PATCH 20/22] usb: typec_altmode: add a missing "@" at a kernel-doc parameter Mauro Carvalho Chehab
2022-06-28 9:55 ` Heikki Krogerus
2022-06-28 9:46 ` [PATCH 21/22] usb: dwc3: document async_callbacks field Mauro Carvalho Chehab
2022-06-28 9:46 ` [PATCH 22/22] usb: dwc3: gadget: fix a kernel-doc warning Mauro Carvalho Chehab
2022-06-29 3:23 ` [PATCH 00/22] Fix kernel-doc warnings at linux-next Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6abe557-029d-cf2b-db79-40630fafb5f1@gmail.com \
--to=cwchoi00@gmail.com \
--cc=corbet@lwn.net \
--cc=cw00.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).