From: Akira Yokosawa <akiyks@gmail.com>
To: Joel Fernandes <joel@joelfernandes.org>,
"Paul E. McKenney" <paulmck@kernel.org>
Cc: Boqun Feng <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org, vpillai@digitalocean.com,
Jonathan Corbet <corbet@lwn.net>,
Alan Stern <stern@rowland.harvard.edu>,
Andrea Parri <parri.andrea@gmail.com>,
Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Nicholas Piggin <npiggin@gmail.com>,
David Howells <dhowells@redhat.com>,
Jade Alglave <j.alglave@ucl.ac.uk>,
Luc Maranget <luc.maranget@inria.fr>,
Daniel Lustig <dlustig@nvidia.com>,
linux-doc@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH 0/3] tools/memory-model, Documentation/litmus-test: Sort out location of litmus test and README
Date: Tue, 12 May 2020 20:50:45 +0900 [thread overview]
Message-ID: <bff04d71-1666-a5a8-54bf-d0c9f8737b47@gmail.com> (raw)
In-Reply-To: <20200512021309.GA197229@google.com>
On Mon, 11 May 2020 22:13:09 -0400, Joel Fernandes wrote:
> On Mon, May 11, 2020 at 10:33:48AM -0700, Paul E. McKenney wrote:
>> On Sun, May 10, 2020 at 04:21:02PM +0900, Akira Yokosawa wrote:
>>> On Sat, 9 May 2020 12:43:30 +0900, Akira Yokosawa wrote:
>>>> Hi Joel,
>>>>
>>>> Sorry for the late response but I've noticed some glitches.
>>>>
>>>> On Sun, 22 Mar 2020 21:57:32 -0400, Joel Fernandes (Google) wrote:
>>>>> Move MP+onceassign+derefonce to the new Documentation/litmus-tests/rcu/
>>>>> directory.
>>>>
>>>> MP+onceassign+derefonce.litmus is called out in
>>>> tools/memory-model/Documentation/recipes.txt as a representative example
>>>> of RCU related litmus test.
>>>>
>>>> So I think it should be kept under tools/memory-model/litmus-tests.
>>>>
>>>> Further RCU-related litmus tests can be added under Documentation/litmus-tests/.
>>>>
>>>> IIUC, this change is not picked up by tip tree yet. So we have time to respin
>>>> the series targeting v5.9.
>>>>
>>>>>
>>>>> More RCU-related litmus tests would be added here.
>>>>>
>>>>> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
>>>>>
>>>>> ---
>>>>> Cc: vpillai@digitalocean.com
>>>>>
>>>>> Documentation/litmus-tests/README | 9 +++++++++
>>>>
>>>> Please note that later patches to add atomic litmus tests under
>>>> Documentation/litmus-tests/ by Boqun put README as
>>>> Documentation/litums-tests/atomic/README.
>>>>
>>>> This patch's location of RCU's README as Documentation/litmus-tests/README
>>>> looks asymmetric to me.
>>>>
>>>> I'm OK with either merging atomic's README with the top-level one or
>>>> moving RCU's README to under Documentation/litmus-tests/rcu.
>>>>
>>>> Joel, Boqum, can you sort out the location of README?
>>>
>>> So something like this?
>>>
>>> Patch 1/3 is an independent typo fix in recipes.txt.
>>> Patch 2/3 reverts the MP+onceassign+derefonce relocation.
>>> Patch 3/3 merges atomic's README into the top-level one.
>>>
>>> This is relative to -rcu's lkmm branch.
>>>
>>> Thoughts?
>>
>> Looks plausible to me, and thank you for reviewing this.
>>
>> Joel, thoughts?
>
> Sorry for the delays (OSPM conference in progress). I'm Ok with moving it
> back to tools/memory-model/.
>
> I think on top of this patch, I'd like to add a reference to the to the
> litmus test in tools/memory-model/ from Documentation/rcu/.
Sounds reasonable to me. But for most people, it never changes its location.
Please find inline comments below.
>
> Just to mention my rationale for Documentation/litmus-tests/rcu/, I was
> basically looking for a central place for RCU related litmus tests in the
> kernel sources and the idea of this new directory came up.
>
> For Akira's series,
> Acked-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Thank you!
>
> And could we add the following patch on top of Akira's series so we still
> maintain a reference to the moved RCU test?>
> ---8<-----------------------
>
> From 52fdb57551cc769d8bd690f4f2b22de36ddece99 Mon Sep 17 00:00:00 2001
> From: "Joel Fernandes (Google)" <joel@joelfernandes.org>
> Date: Mon, 11 May 2020 22:06:46 -0400
> Subject: [PATCH] docs: litmus-tests: Clarify about the RCU pre-initialization
> test
>
> Since this test was moved to tools/memory-model/, make sure that it is
> at least referenced from Documentation/litmus-tests/'s README.
>
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> ---
> Documentation/litmus-tests/README | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/litmus-tests/README b/Documentation/litmus-tests/README
> index ac0b270b456c1..53f09e74734a4 100644
> --- a/Documentation/litmus-tests/README
> +++ b/Documentation/litmus-tests/README
> @@ -11,7 +11,6 @@ tools/memory-model/README.
>
> atomic (/atomic derectory)
> --------------------------
> -
> Atomic-RMW+mb__after_atomic-is-stronger-than-acquire.litmus
> Test that an atomic RMW followed by a smp_mb__after_atomic() is
> stronger than a normal acquire: both the read and write parts of
> @@ -23,8 +22,11 @@ Atomic-RMW-ops-are-atomic-WRT-atomic_set.litmus
>
> RCU (/rcu directory)
> --------------------
> -
I loosely followed the convention of ReST documents in putting these empty
lines. But I don't mind if they are removed.
> RCU+sync+read.litmus
> RCU+sync+free.litmus
> Both the above litmus tests demonstrate the RCU grace period guarantee
> that an RCU read-side critical section can never span a grace period.
> +
> +MP+onceassign+derefonce.litmus (moved to tools/memory-model/litmus-tests/)
As I said above, for those who don't follow developments in the lkmm branch,
MP+onceassign+derefonce.litmus stays in tools/memory-model/litmus-tests/.
So,
+MP+onceassign+derefonce.litmus (under tools/memory-model/litmus-tests/)
looks better to me.
Thanks, Akira
> + Demonstrates that rcu_assign_pointer() and rcu_dereference() to
> + ensure that an RCU reader will not see pre-initialization garbage.
>
next prev parent reply other threads:[~2020-05-12 11:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 1:57 [PATCH v2 1/4] Documentation: LKMM: Move MP+onceassign+derefonce to new litmus-tests/rcu/ Joel Fernandes (Google)
2020-03-23 1:57 ` [PATCH v2 2/4] Documentation: LKMM: Add litmus test for RCU GP guarantee where updater frees object Joel Fernandes (Google)
2020-03-23 1:57 ` [PATCH v2 3/4] Documentation: LKMM: Add litmus test for RCU GP guarantee where reader stores Joel Fernandes (Google)
2020-03-23 1:57 ` [PATCH v2 4/4] MAINTAINERS: Update maintainers for new Documentaion/litmus-tests/ Joel Fernandes (Google)
2020-03-23 6:18 ` Boqun Feng
2020-03-23 8:59 ` Andrea Parri
2020-03-23 17:35 ` Paul E. McKenney
2020-05-09 3:43 ` [PATCH v2 1/4] Documentation: LKMM: Move MP+onceassign+derefonce to new litmus-tests/rcu/ Akira Yokosawa
2020-05-10 7:21 ` [PATCH 0/3] tools/memory-model, Documentation/litmus-test: Sort out location of litmus test and README Akira Yokosawa
2020-05-10 7:23 ` [PATCH 1/3] tools/memory-model: Fix reference to litmus test in recipes.txt Akira Yokosawa
2020-05-10 7:24 ` [PATCH 2/3] Revert "Documentation: LKMM: Move MP+onceassign+derefonce to new litmus-tests/rcu/" Akira Yokosawa
2020-05-10 7:28 ` [PATCH 3/3] Documentation/litmus-tests: Merge atomic's README into top-level one Akira Yokosawa
2020-05-10 12:57 ` [PATCH 0/3] tools/memory-model, Documentation/litmus-test: Sort out location of litmus test and README Andrea Parri
2020-05-11 17:33 ` Paul E. McKenney
2020-05-12 2:13 ` Joel Fernandes
2020-05-12 11:50 ` Akira Yokosawa [this message]
2020-05-12 12:19 ` Joel Fernandes
2020-05-12 14:19 ` Paul E. McKenney
2020-05-12 14:39 ` Akira Yokosawa
2020-05-12 15:40 ` Joel Fernandes
2020-05-12 13:44 ` Alan Stern
2020-05-12 15:07 ` [PATCH 4/3] docs: litmus-tests: Clarify about the RCU pre-initialization test Akira Yokosawa
2020-05-12 15:25 ` Alan Stern
2020-05-12 15:41 ` Joel Fernandes
2020-05-12 16:30 ` Paul E. McKenney
2020-05-12 21:33 ` [PATCH RESEND 0/4] tools/memory-model, Documentation/litmus-test: Sort out, location of litmus test and README Akira Yokosawa
2020-05-12 21:36 ` [PATCH RESEND 1/4] tools/memory-model: Fix reference to litmus test in recipes.txt Akira Yokosawa
2020-05-12 21:37 ` [PATCH RESEND 2/4] Revert "Documentation: LKMM: Move MP+onceassign+derefonce to new litmus-tests/rcu/" Akira Yokosawa
2020-05-12 21:39 ` [PATCH RESEND 3/4] Documentation/litmus-tests: Merge atomic's README into top-level one Akira Yokosawa
2020-05-14 0:46 ` Boqun Feng
2020-05-14 17:16 ` Paul E. McKenney
2020-05-14 22:03 ` Akira Yokosawa
2020-05-14 22:45 ` Paul E. McKenney
2020-05-15 15:01 ` Akira Yokosawa
2020-05-15 15:05 ` Paul E. McKenney
2020-05-16 17:02 ` Paul E. McKenney
2020-05-12 21:40 ` [PATCH RESEND 4/4] docs: litmus-tests: Clarify about the RCU pre-initialization test Akira Yokosawa
2020-05-12 21:43 ` [PATCH 4/3] " Joel Fernandes
2020-05-12 21:49 ` Akira Yokosawa
2020-05-12 22:52 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bff04d71-1666-a5a8-54bf-d0c9f8737b47@gmail.com \
--to=akiyks@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=vpillai@digitalocean.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).