From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D4BBC433E0 for ; Tue, 29 Dec 2020 16:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AE4522227 for ; Tue, 29 Dec 2020 16:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726285AbgL2Qff (ORCPT ); Tue, 29 Dec 2020 11:35:35 -0500 Received: from mga03.intel.com ([134.134.136.65]:16329 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726114AbgL2Qfe (ORCPT ); Tue, 29 Dec 2020 11:35:34 -0500 IronPort-SDR: VaVd5Ys1JKd0Ly9gmiVYspzMBb8YfggZlAMPWIGacHvV9ZvhDQcvGA83Wug6cgMgI2Q6gzSt0f 1/52q6cxYKfg== X-IronPort-AV: E=McAfee;i="6000,8403,9849"; a="176608615" X-IronPort-AV: E=Sophos;i="5.78,458,1599548400"; d="scan'208";a="176608615" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2020 08:34:53 -0800 IronPort-SDR: Wl5EDOps++Sos5Yh78VcJcwz2qfJFTwjnoTuS6PxulCuZ2H6XYQEqKjNjZ5w+VQZcz+Mv3rcID +GA8BBRxgBKA== X-IronPort-AV: E=Sophos;i="5.78,458,1599548400"; d="scan'208";a="347442009" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.251.0.43]) ([10.251.0.43]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2020 08:34:51 -0800 Subject: Re: [PATCH v16 02/26] x86/cet/shstk: Add Kconfig option for user-mode control-flow protection To: Borislav Petkov Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu References: <20201209222320.1724-1-yu-cheng.yu@intel.com> <20201209222320.1724-3-yu-cheng.yu@intel.com> <20201229123910.GB29947@zn.tnic> From: "Yu, Yu-cheng" Message-ID: Date: Tue, 29 Dec 2020 08:34:51 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201229123910.GB29947@zn.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 12/29/2020 4:39 AM, Borislav Petkov wrote: > On Wed, Dec 09, 2020 at 02:22:56PM -0800, Yu-cheng Yu wrote: >> Shadow Stack provides protection against function return address >> corruption. It is active when the processor supports it, the kernel has >> CONFIG_X86_CET_USER, and the application is built for the feature. > ^ > enabled. > >> This is only implemented for the 64-bit kernel. When it is enabled, legacy >> non-Shadow Stack applications continue to work, but without protection. >> >> Signed-off-by: Yu-cheng Yu >> --- >> arch/x86/Kconfig | 22 ++++++++++++++++++++++ >> arch/x86/Kconfig.assembler | 5 +++++ >> 2 files changed, 27 insertions(+) > > Rest looks good, thanks. > Thanks! I will re-base to v5.11-rc1 and send out a new version. -- Yu-cheng