From: Xianting Tian <xianting.tian@linux.alibaba.com>
To: Conor.Dooley@microchip.com, conor@kernel.org
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, anup@brainfault.org, heiko@sntech.de,
guoren@kernel.org, mick@ics.forth.gr,
alexandre.ghiti@canonical.com, bhe@redhat.com, vgoyal@redhat.com,
dyoung@redhat.com, corbet@lwn.net, bagasdotme@gmail.com,
kexec@lists.infradead.org, linux-doc@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
crash-utility@redhat.com, heinrich.schuchardt@canonical.com,
k-hagio-ab@nec.com, hschauhan@nulltrace.org, yixun.lan@gmail.com
Subject: Re: [PATCH V2 1/2] RISC-V: Add arch_crash_save_vmcoreinfo support
Date: Tue, 18 Oct 2022 16:01:41 +0800 [thread overview]
Message-ID: <c60b60c0-59ac-6544-186d-9ac79b742734@linux.alibaba.com> (raw)
In-Reply-To: <642e0529-1df1-86e9-f7de-a6252ba9fd12@microchip.com>
在 2022/10/18 下午3:19, Conor.Dooley@microchip.com 写道:
> On 18/10/2022 03:28, Xianting Tian wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> 在 2022/10/18 上午3:54, Conor Dooley 写道:
>>
>>> On Fri, Oct 14, 2022 at 09:41:38PM +0800, Xianting Tian wrote:
>>>> * Linux Kernel 5.18 ~
>>>> * PGTABLE_LEVELS = 5
>>>> * PAGE_OFFSET = 0xff60000000000000
>>>> * Linux Kernel 5.17 ~
>>>> * PGTABLE_LEVELS = 4
>>>> * PAGE_OFFSET = 0xffffaf8000000000
>>>> * Linux Kernel 4.19 ~
>>>> * PGTABLE_LEVELS = 3
>>>> * PAGE_OFFSET = 0xffffffe000000000
>>>>
>>>> Since these configurations change from time to time and version to version,
>>>> it is preferable to export them via vmcoreinfo than to change the crash's
>>>> code frequently, it can simplify the development of crash tool.
>>>>
>>>> Signed-off-by: Xianting Tian<xianting.tian@linux.alibaba.com>
>>>> ---
>>>> arch/riscv/kernel/Makefile | 1 +
>>>> arch/riscv/kernel/crash_core.c | 29 +++++++++++++++++++++++++++++
>>>> 2 files changed, 30 insertions(+)
>>>> create mode 100644 arch/riscv/kernel/crash_core.c
>>>>
>>>> diff --git a/arch/riscv/kernel/Makefile b/arch/riscv/kernel/Makefile
>>>> index db6e4b1294ba..4cf303a779ab 100644
>>>> --- a/arch/riscv/kernel/Makefile
>>>> +++ b/arch/riscv/kernel/Makefile
>>>> @@ -81,6 +81,7 @@ obj-$(CONFIG_KGDB) += kgdb.o
>>>> obj-$(CONFIG_KEXEC_CORE) += kexec_relocate.o crash_save_regs.o machine_kexec.o
>>>> obj-$(CONFIG_KEXEC_FILE) += elf_kexec.o machine_kexec_file.o
>>>> obj-$(CONFIG_CRASH_DUMP) += crash_dump.o
>>>> +obj-$(CONFIG_CRASH_CORE) += crash_core.o
>>>>
>>>> obj-$(CONFIG_JUMP_LABEL) += jump_label.o
>>>>
>>>> diff --git a/arch/riscv/kernel/crash_core.c b/arch/riscv/kernel/crash_core.c
>>>> new file mode 100644
>>>> index 000000000000..8d7f5ff108da
>>>> --- /dev/null
>>>> +++ b/arch/riscv/kernel/crash_core.c
>>>> @@ -0,0 +1,29 @@
>>>> +// SPDX-License-Identifier: GPL-2.0-only
>>>> +
>>>> +#include <linux/crash_core.h>
>>>> +#include <linux/pagemap.h>
>>>> +
>>>> +void arch_crash_save_vmcoreinfo(void)
>>>> +{
>>>> + VMCOREINFO_NUMBER(VA_BITS);
>>>> + VMCOREINFO_NUMBER(phys_ram_base);
>>>> +
>>>> + vmcoreinfo_append_str("NUMBER(PAGE_OFFSET)=0x%lx\n", PAGE_OFFSET);
>>>> + vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START);
>>>> + vmcoreinfo_append_str("NUMBER(VMALLOC_END)=0x%lx\n", VMALLOC_END);
>>>> + vmcoreinfo_append_str("NUMBER(VMEMMAP_START)=0x%lx\n", VMEMMAP_START);
>>>> + vmcoreinfo_append_str("NUMBER(VMEMMAP_END)=0x%lx\n", VMEMMAP_END);
>>>> +#ifdef CONFIG_64BIT
>>>> + vmcoreinfo_append_str("NUMBER(MODULES_VADDR)=0x%lx\n", MODULES_VADDR);
>>>> + vmcoreinfo_append_str("NUMBER(MODULES_END)=0x%lx\n", MODULES_END);
>>>> +#endif
>>>> +
>>>> + if (IS_ENABLED(CONFIG_64BIT)) {
>>> You've already got a #ifdef CONFIG_64BIT above, is there a reason why
>>> you'd use the IS_ENABLED here rather than merge this with the above
>>> section? I'm a big fan of IS_ENABLED but I'm not sure what it adds here,
>>> maybe you can show me the light :)
>> The IS_ENABLED() check prevents the line from getting executed, but
>> unlike an #ifdef it relies on it to be parsable.
> Hey Xianting,
> Firstly, neither this nor the other version of this message made it to
> the mailing list - and since I usually use lei to get my mails that is
> a bit of a problem :(
Sorry, I don't know why, I just reply via Thunderbird.
But git send-mail is right, I will send V3 soon.
>
> Yeah, I know that that is what IS_ENABLED() does, it's just in this
> situation it does not look very intentional & more like disjoint bits
> of copy-paste. It's fine though, leave it as it is.
OK, thanks
>
> Thanks,
> Conor.
>
>> I wrote this arch_crash_save_vmcoreinfo() func with reference to this: static void __init print_vm_layout(void) // arch/riscv/mm/init.c
>> {
>> pr_notice("Virtual kernel memory layout:\n");
>> print_ml("fixmap", (unsigned long)FIXADDR_START,
>> (unsigned long)FIXADDR_TOP);
>> print_ml("pci io", (unsigned long)PCI_IO_START,
>> (unsigned long)PCI_IO_END);
>> print_ml("vmemmap", (unsigned long)VMEMMAP_START,
>> (unsigned long)VMEMMAP_END);
>> print_ml("vmalloc", (unsigned long)VMALLOC_START,
>> (unsigned long)VMALLOC_END);
>> #ifdef CONFIG_64BIT
>> print_ml("modules", (unsigned long)MODULES_VADDR,
>> (unsigned long)MODULES_END);
>> #endif
>> print_ml("lowmem", (unsigned long)PAGE_OFFSET,
>> (unsigned long)high_memory);
>> if (IS_ENABLED(CONFIG_64BIT)) {
>> #ifdef CONFIG_KASAN
>> print_ml("kasan", KASAN_SHADOW_START, KASAN_SHADOW_END);
>> #endif
>>
>> print_ml("kernel", (unsigned long)KERNEL_LINK_ADDR,
>> (unsigned long)ADDRESS_SPACE_END);
>> }
>> }
>>
>>> Thanks,
>>> Conor.
>>>
>>>
>>>> +#ifdef CONFIG_KASAN
>>>> + vmcoreinfo_append_str("NUMBER(KASAN_SHADOW_START)=0x%lx\n", KASAN_SHADOW_START);
>>>> + vmcoreinfo_append_str("NUMBER(KASAN_SHADOW_END)=0x%lx\n", KASAN_SHADOW_END);
>>>> +#endif
>>>> + vmcoreinfo_append_str("NUMBER(KERNEL_LINK_ADDR)=0x%lx\n", KERNEL_LINK_ADDR);
>>>> + vmcoreinfo_append_str("NUMBER(ADDRESS_SPACE_END)=0x%lx\n", ADDRESS_SPACE_END);
>>>> + }
>>>> +}
>>>> --
>>>> 2.17.1
>>>>
>>>>
next prev parent reply other threads:[~2022-10-18 8:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 13:41 [PATCH V2 0/2] Support VMCOREINFO export for RISCV64 Xianting Tian
2022-10-14 13:41 ` [PATCH V2 1/2] RISC-V: Add arch_crash_save_vmcoreinfo support Xianting Tian
2022-10-17 19:54 ` Conor Dooley
[not found] ` <78420277-215f-55d0-67b8-fbf9208b3d22@linux.alibaba.com>
2022-10-18 7:19 ` Conor.Dooley
2022-10-18 8:01 ` Xianting Tian [this message]
2022-10-14 13:41 ` [PATCH V2 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64 Xianting Tian
2022-10-17 19:40 ` Conor Dooley
2022-10-18 2:41 ` Xianting Tian
2022-10-18 7:13 ` Conor Dooley
2022-10-18 3:19 ` Bagas Sanjaya
2022-10-18 5:32 ` Xianting Tian
2022-10-18 6:06 ` Xianting Tian
2022-10-18 7:20 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c60b60c0-59ac-6544-186d-9ac79b742734@linux.alibaba.com \
--to=xianting.tian@linux.alibaba.com \
--cc=Conor.Dooley@microchip.com \
--cc=alexandre.ghiti@canonical.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=bagasdotme@gmail.com \
--cc=bhe@redhat.com \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=crash-utility@redhat.com \
--cc=dyoung@redhat.com \
--cc=guoren@kernel.org \
--cc=heiko@sntech.de \
--cc=heinrich.schuchardt@canonical.com \
--cc=hschauhan@nulltrace.org \
--cc=k-hagio-ab@nec.com \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mick@ics.forth.gr \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=vgoyal@redhat.com \
--cc=yixun.lan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).