From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1490CEB64DA for ; Thu, 22 Jun 2023 23:56:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230120AbjFVX4p (ORCPT ); Thu, 22 Jun 2023 19:56:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbjFVX4o (ORCPT ); Thu, 22 Jun 2023 19:56:44 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2337DE2; Thu, 22 Jun 2023 16:56:42 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35MNgbS5029631; Thu, 22 Jun 2023 23:56:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=5NZFfx4l5dqawCysO4yk9lFz/3mwWnZoAoVSw/Fj0VY=; b=hKK+9Fa157vTt3ci2RQMdiqZO0XHEd0+eiVEo0mybVmlSHp6Farc5+v3DZLih44cKK/s M95jdm1kuPi+DiKsD1KM1F1yN2o2QeUI5PBApAe3buHdFvGEWS1AZomW2G2BQrzuwLoK +kDkl3QTHVwb3ZCDmqK9MfPV7JoIZA5jdtv65TjRNGO6HmAhYpOuzlQ7B1ZZgLjwvUjn M/4N7sj/VMM8U021F6dQt0cIk44p3pStbzofDSxMTkxo2xECGgaNtGFOJiusUcHppuQD 6u76B2oE1EA3YUvjrXpZWC3gUsyt+i5UbnO4VXuqxQFNIIdsJuhbU1Ur1681fOB6m/vt tg== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rcurrghc9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 23:56:24 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 35MNuN0h010726 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 23:56:23 GMT Received: from [10.71.111.76] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 22 Jun 2023 16:56:21 -0700 Message-ID: Date: Thu, 22 Jun 2023 16:56:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v13 10/24] gunyah: vm_mgr: Add/remove user memory regions Content-Language: en-US From: Elliot Berman To: Will Deacon CC: Alex Elder , Srinivas Kandagatla , Prakruthi Deepak Heragu , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , "Arnd Bergmann" , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , "Bagas Sanjaya" , Andy Gross , "Catalin Marinas" , Jassi Brar , , , , , , References: <20230509204801.2824351-1-quic_eberman@quicinc.com> <20230509204801.2824351-11-quic_eberman@quicinc.com> <20230519115948.GB2637@willie-the-truck> <20230605141839.GD21212@willie-the-truck> <3bd86221-ee2e-d157-009b-11f6ada98537@quicinc.com> In-Reply-To: <3bd86221-ee2e-d157-009b-11f6ada98537@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: PD7O_AwW6snAmWVqgBTYVEXKXNnV1-AV X-Proofpoint-ORIG-GUID: PD7O_AwW6snAmWVqgBTYVEXKXNnV1-AV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-22_17,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 mlxlogscore=830 suspectscore=0 spamscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306220205 Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 6/7/2023 8:54 AM, Elliot Berman wrote: > > > On 6/5/2023 7:18 AM, Will Deacon wrote: >> Hi Elliot, >> >> [+Quentin since he's looked at the MMU notifiers] >> >> Sorry for the slow response, I got buried in email during a week away. >> >> On Fri, May 19, 2023 at 10:02:29AM -0700, Elliot Berman wrote: >>> On 5/19/2023 4:59 AM, Will Deacon wrote: >>>> On Tue, May 09, 2023 at 01:47:47PM -0700, Elliot Berman wrote: >>>>> +    ret = account_locked_vm(ghvm->mm, mapping->npages, true); >>>>> +    if (ret) >>>>> +        goto free_mapping; >>>>> + >>>>> +    mapping->pages = kcalloc(mapping->npages, >>>>> sizeof(*mapping->pages), GFP_KERNEL_ACCOUNT); >>>>> +    if (!mapping->pages) { >>>>> +        ret = -ENOMEM; >>>>> +        mapping->npages = 0; /* update npages for reclaim */ >>>>> +        goto unlock_pages; >>>>> +    } >>>>> + >>>>> +    gup_flags = FOLL_LONGTERM; >>>>> +    if (region->flags & GH_MEM_ALLOW_WRITE) >>>>> +        gup_flags |= FOLL_WRITE; >>>>> + >>>>> +    pinned = pin_user_pages_fast(region->userspace_addr, >>>>> mapping->npages, >>>>> +                    gup_flags, mapping->pages); >>>>> +    if (pinned < 0) { >>>>> +        ret = pinned; >>>>> +        goto free_pages; >>>>> +    } else if (pinned != mapping->npages) { >>>>> +        ret = -EFAULT; >>>>> +        mapping->npages = pinned; /* update npages for reclaim */ >>>>> +        goto unpin_pages; >>>>> +    } >>>> >>>> Sorry if I missed it, but I still don't see where you reject file >>>> mappings >>>> here. >>>> >>> >>> Sure, I can reject file mappings. I didn't catch that was the ask >>> previously >>> and thought it was only a comment about behavior of file mappings. >> >> I thought the mention of filesystem corruption was clear enough! It's >> definitely something we shouldn't allow. >> >>>> This is also the wrong interface for upstream. Please get involved with >>>> the fd-based guest memory discussions [1] and port your series to that. >>>> >>> >>> The user interface design for *shared* memory aligns with >>> KVM_SET_USER_MEMORY_REGION. >> >> I don't think it does. For example, file mappings don't work (as above), >> you're placing additional rlimit requirements on the caller, read-only >> memslots are not functional, the memory cannot be swapped or migrated, >> dirty logging doesn't work etc. pKVM is in the same boat, but that's why >> we're not upstreaming this part in its current form. >> > > I thought pKVM was only holding off on upstreaming changes related to > guest-private memory? > >>> I understood we want to use restricted memfd for giving guest-private >>> memory >>> (Gunyah calls this "lending memory"). When I went through the changes, I >>> gathered KVM is using restricted memfd only for guest-private memory >>> and not >>> for shared memory. Thus, I dropped support for lending memory to the >>> guest >>> VM and only retained the shared memory support in this series. I'd >>> like to >>> merge what we can today and introduce the guest-private memory >>> support in >>> tandem with the restricted memfd; I don't see much reason to delay the >>> series. >> >> Right, protected guests will use the new restricted memfd ("guest mem" >> now, I think?), but non-protected guests should implement the existing >> interface *without* the need for the GUP pin on guest memory pages. Yes, >> that means full support for MMU notifiers so that these pages can be >> managed properly by the host kernel. We're working on that for pKVM, but >> it requires a more flexible form of memory sharing over what we currently >> have so that e.g. the zero page can be shared between multiple entities. > > Gunyah doesn't support swapping pages out while the guest is running and > the design of Gunyah isn't made to give host kernel full control over > the S2 page table for its guests. As best I can tell from reading the > respective drivers, ACRN and Nitro Enclaves both GUP pin guest memory > pages prior to giving them to the guest, so I don't think this > requirement from Gunyah is particularly unusual. > I read/dug into mmu notifiers more and I don't think it matches with Gunyah's features today. We don't allow the host to freely manage VM's pages because it requires the guest VM to have a level of trust on the host. Once a page is given to the guest, it's done for the lifetime of the VM. Allowing the host to replace pages in the guest memory map isn't part of any VM's security model that we run in Gunyah. With that requirement, longterm pinning looks like the correct approach to me. Thanks, Elliot