From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5160C7EE23 for ; Wed, 7 Jun 2023 18:27:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231251AbjFGS1T (ORCPT ); Wed, 7 Jun 2023 14:27:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231626AbjFGS1R (ORCPT ); Wed, 7 Jun 2023 14:27:17 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42A87E79 for ; Wed, 7 Jun 2023 11:26:51 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5149b63151aso1986550a12.3 for ; Wed, 07 Jun 2023 11:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686162401; x=1688754401; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZRj+mE8jCuZmOYVQqkftbO+ddM2GLO7xQ0oXcx+IVPg=; b=pzkOcuk2QH5o8cSqzHedtXSDBcDhlF3m1WDSJvl7OVrVSK0Q3W5DgsoqMvf5fE6X1O JiAdA/oH10Y2IzEdmhHsNm8PNLmX60mlHAlZAIOXaP2bSe8a+0mEOri7GwAahN3I5w+f 1OL1nbq2JFg8rTKxc6LBUiNSYG4iuckRDEIeTaOeihJgbOKV0yrHA8pB6c9bi1DrhM94 tqerLRwLfB06wLXl+kKoTWrJ4q7Zr+C2dRU4lQUXsjOcOb6mq4R8VySKoRElUYe2vN6X DevUHmBVJ+Pq2mmfVm3H5BZBlHQLtIch9DGumt1Ttpem2iJLme0pspfd6gIMqNQYVqXF 8bqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686162401; x=1688754401; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZRj+mE8jCuZmOYVQqkftbO+ddM2GLO7xQ0oXcx+IVPg=; b=j4K6i4OrW6yLzzK0D6sdExH7p8aS0umm+z0skA+QuDr/IIF4acWR0a8MyLO615BYsf uDB4Ma5d1VFMW+w0Tiy2OmV4PJ60AL1AyN+IRti0sEgMX7NG+XToHk70HKItnHp1XMBm +SDBmYzuoeZ6Wn15miLZv0BDVH3WIaObCNzMfRwysxV/UC3G2OLpPzyDUl09oRLD+OaD ejJX4wGIHFK55D8Zr5RqVmgQdYvfU88tOeiTQfuHvJTnSPUP79+RPHofj2fXoF9BbmmQ mFo+OlLSFmcMiv+i3U7OWRYYiS+080nT2G96FeVQDB74m7t1Nu5rWTmX+mN0Q1C6nfcZ PZvQ== X-Gm-Message-State: AC+VfDzWxEwbp/sJ9OVy8Y3bULvZv63GI1mQLXikmfIy/0RNCp/RNT4A FK7v83CeURkVPWAwsxhQ2jGsQA== X-Google-Smtp-Source: ACHHUZ5YUulZzqwNfYTpRRDDYzgUjLAdgZeSBYf9eA5aKTpF9KWdikk8pq/Ts0lAJ7VXnuCh4iWv0Q== X-Received: by 2002:a17:907:3e1e:b0:96f:b58e:7e21 with SMTP id hp30-20020a1709073e1e00b0096fb58e7e21mr7507816ejc.52.1686162401374; Wed, 07 Jun 2023 11:26:41 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id bv2-20020a170906b1c200b009659ad1072fsm7215357ejb.113.2023.06.07.11.26.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 11:26:40 -0700 (PDT) Message-ID: Date: Wed, 7 Jun 2023 20:26:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [v5 3/5] dt-bindings: mfd: Add aspeed pwm-tach binding Content-Language: en-US To: Billy Tsai , Patrick Williams Cc: "jdelvare@suse.com" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "lee@kernel.org" , "thierry.reding@gmail.com" , "u.kleine-koenig@pengutronix.de" , "corbet@lwn.net" , "p.zabel@pengutronix.de" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-doc@vger.kernel.org" References: <20230606094535.5388-1-billy_tsai@aspeedtech.com> <20230606094535.5388-4-billy_tsai@aspeedtech.com> <35bf0a69-bcf6-ae35-eb3c-e74cfcf9c571@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 07/06/2023 08:26, Billy Tsai wrote: >> Missing description. But more important - why do you have such child >> nodes? Your example does not have them. What's the point? Do you expect >> different number of fans per one device (one compatible)? > > In this patch series, I have included examples and descriptions to provide additional information. > The child node is used to enable the channel of this tach controller. Children are not for this. Look for cells examples (e.g. gpio-cells, pwm-cells). It seems this is the same as Nuvoton NCT7362Y, so no. Don't use reg for that purpose. Best regards, Krzysztof