From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 788B6C2D0EA for ; Thu, 9 Apr 2020 09:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DEA520757 for ; Thu, 9 Apr 2020 09:16:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726622AbgDIJP7 (ORCPT ); Thu, 9 Apr 2020 05:15:59 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:59188 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725783AbgDIJP7 (ORCPT ); Thu, 9 Apr 2020 05:15:59 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8A1E04C48F3BE4C6B697; Thu, 9 Apr 2020 17:15:55 +0800 (CST) Received: from [127.0.0.1] (10.173.221.195) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Thu, 9 Apr 2020 17:15:53 +0800 Subject: Re: [PATCH] EDAC, xgene: remove set but not used 'address' To: Robert Richter CC: , , , , , , References: <20200409085237.46642-1-yanaijie@huawei.com> <20200409091016.d3uohmt2o3zwhmro@rric.localdomain> From: Jason Yan Message-ID: <1185c697-026d-74c9-3f67-e95bebdc4c00@huawei.com> Date: Thu, 9 Apr 2020 17:15:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200409091016.d3uohmt2o3zwhmro@rric.localdomain> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.173.221.195] X-CFilter-Loop: Reflected Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org 在 2020/4/9 17:10, Robert Richter 写道: > On 09.04.20 16:52:37, Jason Yan wrote: >> Fix the following gcc warning: >> >> drivers/edac/xgene_edac.c:1486:7: warning: variable ‘address’ set but >> not used [-Wunused-but-set-variable] >> u32 address; >> ^~~~~~~ >> >> Reported-by: Hulk Robot >> Signed-off-by: Jason Yan >> --- >> drivers/edac/xgene_edac.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c >> index e4a1032ba0b5..e5e0fbdeca29 100644 >> --- a/drivers/edac/xgene_edac.c >> +++ b/drivers/edac/xgene_edac.c >> @@ -1483,13 +1483,11 @@ static void xgene_edac_rb_report(struct edac_device_ctl_info *edac_dev) >> return; >> if (reg & STICKYERR_MASK) { >> bool write; >> - u32 address; >> >> dev_err(edac_dev->dev, "IOB bus access error(s)\n"); >> if (regmap_read(ctx->edac->rb_map, RBEIR, ®)) >> return; >> write = reg & WRITE_ACCESS_MASK ? 1 : 0; >> - address = RBERRADDR_RD(reg); > > Please also remove that unused macro. > OK, thanks. Jason > Thanks, > > -Robert > >> if (reg & AGENT_OFFLINE_ERR_MASK) >> dev_err(edac_dev->dev, >> "IOB bus %s access to offline agent error\n", >> -- >> 2.17.2 >> >