From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: x86/mce: suspicious RCU usage in 4.13.4 From: Borislav Petkov Message-Id: <20171101164754.xzzmskl4ngrqc5br@pd.tnic> Date: Wed, 1 Nov 2017 17:47:54 +0100 To: Laura Abbott , "Luck, Tony" Cc: Andi Kleen , Jeremy Cline , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gV2VkLCBOb3YgMDEsIDIwMTcgYXQgMDc6NTY6MjBBTSAtMDcwMCwgTGF1cmEgQWJib3R0IHdy b3RlOgo+IERpZCB0aGVzZSBnZXQgcXVldWVkIHVwIHNvbWV3aGVyZT8gSSBrbm93IGxhc3Qgd2Vl ayB3YXMgT1NTRVUvS3N1bW1pdAo+IHNvIHBlb3BsZSBtYXkgc3RpbGwgYmUgcGxheWluZyBjYXRj aC11cC4KCkFoLCB0aGFua3MgZm9yIHRoZSByZW1pbmRlci4KCi9tZSBnb2VzIGFuZCBkdXN0cyBp dCBvZmYuCgpPaywgaGVyZSBpdCBpcywgaW5qZWN0aW5nIHNvbWUgTUNFcyBpbiBhIGd1ZXN0IHNl ZW1zIHRvIHdvcmsgZmluZSwKbWNlbG9nIGxvZ3MgdGhlbS4KClRvbnk/Ci0tLQpGcm9tOiBCb3Jp c2xhdiBQZXRrb3YgPGJwQHN1c2UuZGU+CkRhdGU6IFdlZCwgMTEgT2N0IDIwMTcgMTU6NDk6MTkg KzAyMDAKU3ViamVjdDogW1BBVENIXSB4ODYvbWNlbG9nOiBHZXQgcmlkIG9mIFJDVSByZW1uYW50 cwoKL2Rldi9tY2Vsb2cgaXMgY2FsbGVkIGluIHByb2Nlc3MgY29udGV4dCBub3cgYXMgcGFydCBv ZiB0aGUgbm90aWZpZXIKY2hhaW4gYW5kIGRvZXNuJ3QgbmVlZCBhbnkgb2YgdGhlIGZhbmN5IFJD VSBhbmQgbG9ja2xlc3MgYWNjZXNzZXMgd2hpY2gKaXQgZGlkIGluIGF0b21pYyBjb250ZXh0LgoK QXhlIGl0IGFsbCBpbiBmYXZvciBvZiBhIHNpbXBsZSBtdXRleCBzeW5jaHJvbml6YXRpb24uCgpS ZXBvcnRlZC1ieTogSmVyZW15IENsaW5lIDxqY2xpbmVAcmVkaGF0LmNvbT4KU2lnbmVkLW9mZi1i eTogQm9yaXNsYXYgUGV0a292IDxicEBzdXNlLmRlPgpMaW5rOiBodHRwczovL2J1Z3ppbGxhLnJl ZGhhdC5jb20vc2hvd19idWcuY2dpP2lkPTE0OTg5NjkKLS0tCiBhcmNoL3g4Ni9rZXJuZWwvY3B1 L21jaGVjay9kZXYtbWNlbG9nLmMgfCAxMjEgKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCA5NCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9hcmNoL3g4Ni9rZXJuZWwvY3B1L21jaGVjay9kZXYtbWNlbG9nLmMgYi9hcmNo L3g4Ni9rZXJuZWwvY3B1L21jaGVjay9kZXYtbWNlbG9nLmMKaW5kZXggMTBjZWM0M2FhYzM4Li43 Zjg1Yjc2ZjQzYmMgMTAwNjQ0Ci0tLSBhL2FyY2gveDg2L2tlcm5lbC9jcHUvbWNoZWNrL2Rldi1t Y2Vsb2cuYworKysgYi9hcmNoL3g4Ni9rZXJuZWwvY3B1L21jaGVjay9kZXYtbWNlbG9nLmMKQEAg LTI0LDE0ICsyNCw2IEBAIHN0YXRpYyBERUZJTkVfTVVURVgobWNlX2NocmRldl9yZWFkX211dGV4 KTsKIHN0YXRpYyBjaGFyIG1jZV9oZWxwZXJbMTI4XTsKIHN0YXRpYyBjaGFyICptY2VfaGVscGVy X2FyZ3ZbMl0gPSB7IG1jZV9oZWxwZXIsIE5VTEwgfTsKIAotI2RlZmluZSBtY2VfbG9nX2dldF9p ZHhfY2hlY2socCkgXAotKHsgXAotCVJDVV9MT0NLREVQX1dBUk4oIXJjdV9yZWFkX2xvY2tfc2No ZWRfaGVsZCgpICYmIFwKLQkJCSAhbG9ja2RlcF9pc19oZWxkKCZtY2VfY2hyZGV2X3JlYWRfbXV0 ZXgpLCBcCi0JCQkgInN1c3BpY2lvdXMgbWNlX2xvZ19nZXRfaWR4X2NoZWNrKCkgdXNhZ2UiKTsg XAotCXNtcF9sb2FkX2FjcXVpcmUoJihwKSk7IFwKLX0pCi0KIC8qCiAgKiBMb2NrbGVzcyBNQ0Ug bG9nZ2luZyBpbmZyYXN0cnVjdHVyZS4KICAqIFRoaXMgYXZvaWRzIGRlYWRsb2NrcyBvbiBwcmlu dGsgbG9ja3Mgd2l0aG91dCBoYXZpbmcgdG8gYnJlYWsgbG9ja3MuIEFsc28KQEAgLTUzLDQzICs0 NSwzMiBAQCBzdGF0aWMgaW50IGRldl9tY2VfbG9nKHN0cnVjdCBub3RpZmllcl9ibG9jayAqbmIs IHVuc2lnbmVkIGxvbmcgdmFsLAogCQkJCXZvaWQgKmRhdGEpCiB7CiAJc3RydWN0IG1jZSAqbWNl ID0gKHN0cnVjdCBtY2UgKilkYXRhOwotCXVuc2lnbmVkIGludCBuZXh0LCBlbnRyeTsKLQotCXdt YigpOwotCWZvciAoOzspIHsKLQkJZW50cnkgPSBtY2VfbG9nX2dldF9pZHhfY2hlY2sobWNlbG9n Lm5leHQpOwotCQlmb3IgKDs7KSB7Ci0KLQkJCS8qCi0JCQkgKiBXaGVuIHRoZSBidWZmZXIgZmls bHMgdXAgZGlzY2FyZCBuZXcgZW50cmllcy4KLQkJCSAqIEFzc3VtZSB0aGF0IHRoZSBlYXJsaWVy IGVycm9ycyBhcmUgdGhlIG1vcmUKLQkJCSAqIGludGVyZXN0aW5nIG9uZXM6Ci0JCQkgKi8KLQkJ CWlmIChlbnRyeSA+PSBNQ0VfTE9HX0xFTikgewotCQkJCXNldF9iaXQoTUNFX09WRVJGTE9XLAot CQkJCQkodW5zaWduZWQgbG9uZyAqKSZtY2Vsb2cuZmxhZ3MpOwotCQkJCXJldHVybiBOT1RJRllf T0s7Ci0JCQl9Ci0JCQkvKiBPbGQgbGVmdCBvdmVyIGVudHJ5LiBTa2lwOiAqLwotCQkJaWYgKG1j ZWxvZy5lbnRyeVtlbnRyeV0uZmluaXNoZWQpIHsKLQkJCQllbnRyeSsrOwotCQkJCWNvbnRpbnVl OwotCQkJfQotCQkJYnJlYWs7Ci0JCX0KLQkJc21wX3JtYigpOwotCQluZXh0ID0gZW50cnkgKyAx OwotCQlpZiAoY21weGNoZygmbWNlbG9nLm5leHQsIGVudHJ5LCBuZXh0KSA9PSBlbnRyeSkKLQkJ CWJyZWFrOworCXVuc2lnbmVkIGludCBlbnRyeTsKKworCW11dGV4X2xvY2soJm1jZV9jaHJkZXZf cmVhZF9tdXRleCk7CisKKwllbnRyeSA9IG1jZWxvZy5uZXh0OworCisJLyoKKwkgKiBXaGVuIHRo ZSBidWZmZXIgZmlsbHMgdXAgZGlzY2FyZCBuZXcgZW50cmllcy4gQXNzdW1lIHRoYXQgdGhlCisJ ICogZWFybGllciBlcnJvcnMgYXJlIHRoZSBtb3JlIGludGVyZXN0aW5nIG9uZXM6CisJICovCisJ aWYgKGVudHJ5ID49IE1DRV9MT0dfTEVOKSB7CisJCXNldF9iaXQoTUNFX09WRVJGTE9XLCAodW5z aWduZWQgbG9uZyAqKSZtY2Vsb2cuZmxhZ3MpOworCQlnb3RvIHVubG9jazsKIAl9CisKKwltY2Vs b2cubmV4dCA9IGVudHJ5ICsgMTsKKwogCW1lbWNweShtY2Vsb2cuZW50cnkgKyBlbnRyeSwgbWNl LCBzaXplb2Yoc3RydWN0IG1jZSkpOwotCXdtYigpOwogCW1jZWxvZy5lbnRyeVtlbnRyeV0uZmlu aXNoZWQgPSAxOwotCXdtYigpOwogCiAJLyogd2FrZSBwcm9jZXNzZXMgcG9sbGluZyAvZGV2L21j ZWxvZyAqLwogCXdha2VfdXBfaW50ZXJydXB0aWJsZSgmbWNlX2NocmRldl93YWl0KTsKIAordW5s b2NrOgorCW11dGV4X3VubG9jaygmbWNlX2NocmRldl9yZWFkX211dGV4KTsKKwogCXJldHVybiBO T1RJRllfT0s7CiB9CiAKQEAgLTE3NywxMyArMTU4LDYgQEAgc3RhdGljIGludCBtY2VfY2hyZGV2 X3JlbGVhc2Uoc3RydWN0IGlub2RlICppbm9kZSwgc3RydWN0IGZpbGUgKmZpbGUpCiAJcmV0dXJu IDA7CiB9CiAKLXN0YXRpYyB2b2lkIGNvbGxlY3RfdHNjcyh2b2lkICpkYXRhKQotewotCXVuc2ln bmVkIGxvbmcgKmNwdV90c2MgPSAodW5zaWduZWQgbG9uZyAqKWRhdGE7Ci0KLQljcHVfdHNjW3Nt cF9wcm9jZXNzb3JfaWQoKV0gPSByZHRzYygpOwotfQotCiBzdGF0aWMgaW50IG1jZV9hcGVpX3Jl YWRfZG9uZTsKIAogLyogQ29sbGVjdCBNQ0UgcmVjb3JkIG9mIHByZXZpb3VzIGJvb3QgaW4gcGVy c2lzdGVudCBzdG9yYWdlIHZpYSBBUEVJIEVSU1QuICovCkBAIC0yMzEsMTQgKzIwNSw5IEBAIHN0 YXRpYyBzc2l6ZV90IG1jZV9jaHJkZXZfcmVhZChzdHJ1Y3QgZmlsZSAqZmlscCwgY2hhciBfX3Vz ZXIgKnVidWYsCiAJCQkJc2l6ZV90IHVzaXplLCBsb2ZmX3QgKm9mZikKIHsKIAljaGFyIF9fdXNl ciAqYnVmID0gdWJ1ZjsKLQl1bnNpZ25lZCBsb25nICpjcHVfdHNjOwotCXVuc2lnbmVkIHByZXYs IG5leHQ7CisJdW5zaWduZWQgbmV4dDsKIAlpbnQgaSwgZXJyOwogCi0JY3B1X3RzYyA9IGttYWxs b2MobnJfY3B1X2lkcyAqIHNpemVvZihsb25nKSwgR0ZQX0tFUk5FTCk7Ci0JaWYgKCFjcHVfdHNj KQotCQlyZXR1cm4gLUVOT01FTTsKLQogCW11dGV4X2xvY2soJm1jZV9jaHJkZXZfcmVhZF9tdXRl eCk7CiAKIAlpZiAoIW1jZV9hcGVpX3JlYWRfZG9uZSkgewpAQCAtMjQ3LDY1ICsyMTYsMjkgQEAg c3RhdGljIHNzaXplX3QgbWNlX2NocmRldl9yZWFkKHN0cnVjdCBmaWxlICpmaWxwLCBjaGFyIF9f dXNlciAqdWJ1ZiwKIAkJCWdvdG8gb3V0OwogCX0KIAotCW5leHQgPSBtY2VfbG9nX2dldF9pZHhf Y2hlY2sobWNlbG9nLm5leHQpOwotCiAJLyogT25seSBzdXBwb3J0cyBmdWxsIHJlYWRzIHJpZ2h0 IG5vdyAqLwogCWVyciA9IC1FSU5WQUw7CiAJaWYgKCpvZmYgIT0gMCB8fCB1c2l6ZSA8IE1DRV9M T0dfTEVOKnNpemVvZihzdHJ1Y3QgbWNlKSkKIAkJZ290byBvdXQ7CiAKKwluZXh0ID0gbWNlbG9n Lm5leHQ7CiAJZXJyID0gMDsKLQlwcmV2ID0gMDsKLQlkbyB7Ci0JCWZvciAoaSA9IHByZXY7IGkg PCBuZXh0OyBpKyspIHsKLQkJCXVuc2lnbmVkIGxvbmcgc3RhcnQgPSBqaWZmaWVzOwotCQkJc3Ry dWN0IG1jZSAqbSA9ICZtY2Vsb2cuZW50cnlbaV07Ci0KLQkJCXdoaWxlICghbS0+ZmluaXNoZWQp IHsKLQkJCQlpZiAodGltZV9hZnRlcl9lcShqaWZmaWVzLCBzdGFydCArIDIpKSB7Ci0JCQkJCW1l bXNldChtLCAwLCBzaXplb2YoKm0pKTsKLQkJCQkJZ290byB0aW1lb3V0OwotCQkJCX0KLQkJCQlj cHVfcmVsYXgoKTsKLQkJCX0KLQkJCXNtcF9ybWIoKTsKLQkJCWVyciB8PSBjb3B5X3RvX3VzZXIo YnVmLCBtLCBzaXplb2YoKm0pKTsKLQkJCWJ1ZiArPSBzaXplb2YoKm0pOwotdGltZW91dDoKLQkJ CTsKLQkJfQotCi0JCW1lbXNldChtY2Vsb2cuZW50cnkgKyBwcmV2LCAwLAotCQkgICAgICAgKG5l eHQgLSBwcmV2KSAqIHNpemVvZihzdHJ1Y3QgbWNlKSk7Ci0JCXByZXYgPSBuZXh0OwotCQluZXh0 ID0gY21weGNoZygmbWNlbG9nLm5leHQsIHByZXYsIDApOwotCX0gd2hpbGUgKG5leHQgIT0gcHJl dik7Ci0KLQlzeW5jaHJvbml6ZV9zY2hlZCgpOwogCi0JLyoKLQkgKiBDb2xsZWN0IGVudHJpZXMg dGhhdCB3ZXJlIHN0aWxsIGdldHRpbmcgd3JpdHRlbiBiZWZvcmUgdGhlCi0JICogc3luY2hyb25p emUuCi0JICovCi0Jb25fZWFjaF9jcHUoY29sbGVjdF90c2NzLCBjcHVfdHNjLCAxKTsKLQotCWZv ciAoaSA9IG5leHQ7IGkgPCBNQ0VfTE9HX0xFTjsgaSsrKSB7CisJZm9yIChpID0gMDsgaSA8IG5l eHQ7IGkrKykgewogCQlzdHJ1Y3QgbWNlICptID0gJm1jZWxvZy5lbnRyeVtpXTsKIAotCQlpZiAo bS0+ZmluaXNoZWQgJiYgbS0+dHNjIDwgY3B1X3RzY1ttLT5jcHVdKSB7Ci0JCQllcnIgfD0gY29w eV90b191c2VyKGJ1ZiwgbSwgc2l6ZW9mKCptKSk7Ci0JCQlzbXBfcm1iKCk7Ci0JCQlidWYgKz0g c2l6ZW9mKCptKTsKLQkJCW1lbXNldChtLCAwLCBzaXplb2YoKm0pKTsKLQkJfQorCQllcnIgfD0g Y29weV90b191c2VyKGJ1ZiwgbSwgc2l6ZW9mKCptKSk7CisJCWJ1ZiArPSBzaXplb2YoKm0pOwog CX0KIAorCW1lbXNldChtY2Vsb2cuZW50cnksIDAsIG5leHQgKiBzaXplb2Yoc3RydWN0IG1jZSkp OworCW1jZWxvZy5uZXh0ID0gMDsKKwogCWlmIChlcnIpCiAJCWVyciA9IC1FRkFVTFQ7CiAKIG91 dDoKIAltdXRleF91bmxvY2soJm1jZV9jaHJkZXZfcmVhZF9tdXRleCk7Ci0Ja2ZyZWUoY3B1X3Rz Yyk7CiAKIAlyZXR1cm4gZXJyID8gZXJyIDogYnVmIC0gdWJ1ZjsKIH0K