From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/2] EDAC: i7core: fix memleaks and use-after-free on probe and remove From: Johan Hovold Message-Id: <20180612124335.6420-2-johan@kernel.org> Date: Tue, 12 Jun 2018 14:43:35 +0200 To: Borislav Petkov Cc: Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable List-ID: TWFrZSBzdXJlIHRvIGZyZWUgYW5kIGRlcmVnaXN0ZXIgdGhlIGFkZHJtYXRjaCBhbmQgY2hhbmNv dW50cyBkZXZpY2VzCmFsbG9jYXRlZCBkdXJpbmcgcHJvYmUgaW4gYWxsIGVycm9yIHBhdGhzLiBB bHNvIGZpeCB1c2UtYWZ0ZXItZnJlZSBpbiBhCnByb2JlIGVycm9yIHBhdGggYW5kIGluIHRoZSBy ZW1vdmUgc3VjY2VzcyBwYXRoIHdoZXJlIHRoZSBkZXZpY2VzIHdlcmUKYmVpbmcgcHV0IGJlZm9y ZSBiZWZvcmUgZGVyZWdpc3RyYXRpb24uCgpGaXhlczogMzU2ZjBhMzA4NjBkICgiaTdjb3JlX2Vk YWM6IGNoYW5nZSB0aGUgbWVtIGFsbG9jYXRpb24gc2NoZW1lIHRvIG1ha2UgRG9jdW1lbnRhdGlv bi9rb2JqZWN0LnR4dCBoYXBweSIpCkNjOiBzdGFibGUgPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ ICAgICAjIDMuNgpDYzogTWF1cm8gQ2FydmFsaG8gQ2hlaGFiIDxtY2hlaGFiQGtlcm5lbC5vcmc+ ClNpZ25lZC1vZmYtYnk6IEpvaGFuIEhvdm9sZCA8am9oYW5Aa2VybmVsLm9yZz4KLS0tCiBkcml2 ZXJzL2VkYWMvaTdjb3JlX2VkYWMuYyB8IDIyICsrKysrKysrKysrKysrKy0tLS0tLS0KIDEgZmls ZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2RyaXZlcnMvZWRhYy9pN2NvcmVfZWRhYy5jIGIvZHJpdmVycy9lZGFjL2k3Y29yZV9lZGFjLmMK aW5kZXggOGM1NTQwMTYwYTIzLi4yM2U0NDFkYmFmNDkgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZWRh Yy9pN2NvcmVfZWRhYy5jCisrKyBiL2RyaXZlcnMvZWRhYy9pN2NvcmVfZWRhYy5jCkBAIC0xMTc3 LDE1ICsxMTc3LDE0IEBAIHN0YXRpYyBpbnQgaTdjb3JlX2NyZWF0ZV9zeXNmc19kZXZpY2VzKHN0 cnVjdCBtZW1fY3RsX2luZm8gKm1jaSkKIAogCXJjID0gZGV2aWNlX2FkZChwdnQtPmFkZHJtYXRj aF9kZXYpOwogCWlmIChyYyA8IDApCi0JCXJldHVybiByYzsKKwkJZ290byBlcnJfcHV0X2FkZHJt YXRjaDsKIAogCWlmICghcHZ0LT5pc19yZWdpc3RlcmVkKSB7CiAJCXB2dC0+Y2hhbmNvdW50c19k ZXYgPSBremFsbG9jKHNpemVvZigqcHZ0LT5jaGFuY291bnRzX2RldiksCiAJCQkJCSAgICAgIEdG UF9LRVJORUwpOwogCQlpZiAoIXB2dC0+Y2hhbmNvdW50c19kZXYpIHsKLQkJCXB1dF9kZXZpY2Uo cHZ0LT5hZGRybWF0Y2hfZGV2KTsKLQkJCWRldmljZV9kZWwocHZ0LT5hZGRybWF0Y2hfZGV2KTsK LQkJCXJldHVybiAtRU5PTUVNOworCQkJcmMgPSAtRU5PTUVNOworCQkJZ290byBlcnJfZGVsX2Fk ZHJtYXRjaDsKIAkJfQogCiAJCXB2dC0+Y2hhbmNvdW50c19kZXYtPnR5cGUgPSAmYWxsX2NoYW5u ZWxfY291bnRzX3R5cGU7CkBAIC0xMTk5LDkgKzExOTgsMTggQEAgc3RhdGljIGludCBpN2NvcmVf Y3JlYXRlX3N5c2ZzX2RldmljZXMoc3RydWN0IG1lbV9jdGxfaW5mbyAqbWNpKQogCiAJCXJjID0g ZGV2aWNlX2FkZChwdnQtPmNoYW5jb3VudHNfZGV2KTsKIAkJaWYgKHJjIDwgMCkKLQkJCXJldHVy biByYzsKKwkJCWdvdG8gZXJyX3B1dF9jaGFuY291bnRzOwogCX0KIAlyZXR1cm4gMDsKKworZXJy X3B1dF9jaGFuY291bnRzOgorCXB1dF9kZXZpY2UocHZ0LT5jaGFuY291bnRzX2Rldik7CitlcnJf ZGVsX2FkZHJtYXRjaDoKKwlkZXZpY2VfZGVsKHB2dC0+YWRkcm1hdGNoX2Rldik7CitlcnJfcHV0 X2FkZHJtYXRjaDoKKwlwdXRfZGV2aWNlKHB2dC0+YWRkcm1hdGNoX2Rldik7CisKKwlyZXR1cm4g cmM7CiB9CiAKIHN0YXRpYyB2b2lkIGk3Y29yZV9kZWxldGVfc3lzZnNfZGV2aWNlcyhzdHJ1Y3Qg bWVtX2N0bF9pbmZvICptY2kpCkBAIC0xMjExLDExICsxMjE5LDExIEBAIHN0YXRpYyB2b2lkIGk3 Y29yZV9kZWxldGVfc3lzZnNfZGV2aWNlcyhzdHJ1Y3QgbWVtX2N0bF9pbmZvICptY2kpCiAJZWRh Y19kYmcoMSwgIlxuIik7CiAKIAlpZiAoIXB2dC0+aXNfcmVnaXN0ZXJlZCkgewotCQlwdXRfZGV2 aWNlKHB2dC0+Y2hhbmNvdW50c19kZXYpOwogCQlkZXZpY2VfZGVsKHB2dC0+Y2hhbmNvdW50c19k ZXYpOworCQlwdXRfZGV2aWNlKHB2dC0+Y2hhbmNvdW50c19kZXYpOwogCX0KLQlwdXRfZGV2aWNl KHB2dC0+YWRkcm1hdGNoX2Rldik7CiAJZGV2aWNlX2RlbChwdnQtPmFkZHJtYXRjaF9kZXYpOwor CXB1dF9kZXZpY2UocHZ0LT5hZGRybWF0Y2hfZGV2KTsKIH0KIAogLyoqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioK