From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF069C04AB5 for ; Thu, 6 Jun 2019 10:03:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89FE52083E for ; Thu, 6 Jun 2019 10:03:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="cAtCEzCX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727959AbfFFKDU (ORCPT ); Thu, 6 Jun 2019 06:03:20 -0400 Received: from mail.skyhub.de ([5.9.137.197]:51288 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726972AbfFFKDU (ORCPT ); Thu, 6 Jun 2019 06:03:20 -0400 Received: from zn.tnic (p200300EC2F1EFA00C5555FEB083E0D5D.dip0.t-ipconnect.de [IPv6:2003:ec:2f1e:fa00:c555:5feb:83e:d5d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id F008C1EC02FE; Thu, 6 Jun 2019 12:03:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1559815398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=gY7wo5tn+Q6xuDLRFIE/jPyAZiFytadxsFIYa94a7Xg=; b=cAtCEzCXTH50n+mSHu26/2RPN9U0/FM0abQbzcs68cQvcwFuwUoHCIoUi4NOe00kr5G8oW af88+35wfOFlo9OMy23Rug6cKERrEBIeHoi/zS7TZGj2Wwuux0p/EROmUW9QX8eJhjc5Mx w7Yjwi4RLHRtXbEUyf+htu9TVGIX+CI= Date: Thu, 6 Jun 2019 12:03:12 +0200 From: Borislav Petkov To: "Hawa, Hanna" Cc: "Herrenschmidt, Benjamin" , "james.morse@arm.com" , "robh+dt@kernel.org" , "Woodhouse, David" , "paulmck@linux.ibm.com" , "mchehab@kernel.org" , "mark.rutland@arm.com" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "nicolas.ferre@microchip.com" , "devicetree@vger.kernel.org" , "Shenhar, Talel" , "linux-kernel@vger.kernel.org" , "Chocron, Jonathan" , "Krupnik, Ronen" , "linux-edac@vger.kernel.org" , "Hanoch, Uri" Subject: Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC Message-ID: <20190606100312.GD26146@zn.tnic> References: <1559211329-13098-1-git-send-email-hhhawa@amazon.com> <1559211329-13098-3-git-send-email-hhhawa@amazon.com> <20190531051400.GA2275@cz.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Jun 06, 2019 at 10:53:42AM +0300, Hawa, Hanna wrote: > Disagree. The various drivers don't depend on each other. > I think we should keep the drivers separated as they are distinct and > independent IP blocks. This topic comes up each time someone submits a new ARM EDAC driver: EDAC can't support different drivers because of the limitations it has. And a single platform driver works - see altera_edac. Again, James has a good write up with example how this can work so be patient. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.