From: Borislav Petkov <bp@alien8.de>
To: James Morse <james.morse@arm.com>
Cc: linux-edac@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rrichter@marvell.com>,
Toshi Kani <toshi.kani@hpe.com>
Subject: Re: [PATCH] EDAC, ghes: Fix grain calculation
Date: Thu, 13 Jun 2019 21:18:43 +0200 [thread overview]
Message-ID: <20190613191843.GG11598@zn.tnic> (raw)
In-Reply-To: <9bda9613-09b3-aa6d-183f-3668ef9a99c6@arm.com>
On Thu, Jun 13, 2019 at 06:06:22PM +0100, James Morse wrote:
> edac_raw_mc_handle_error() prints it out,
Of course it does, sorry for not seeing it. ;-\
> We could replace edac_raw_mc_handle_error()'s use of e->grain with e->grain_bits, which
> would also make Robert's life easier when trying to merge those paths, but that's a more
> invasive change.
>
> I did did it like this to make it the minimum change if it was going as a fix. If we're
> confident that no-one has-noticed/cared this can be papered over as part of Robert's
> series, otherwise it will conflict.
Yeah, lemme take your patch as is and we can still improve on that whole
flow once the dust of all that cleanup settles.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-06-13 19:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 15:22 [PATCH] EDAC, ghes: Fix grain calculation James Morse
2019-05-30 16:50 ` Kani, Toshi
2019-06-12 4:34 ` Borislav Petkov
2019-06-13 17:06 ` James Morse
2019-06-13 19:18 ` Borislav Petkov [this message]
2019-06-13 21:07 ` Robert Richter
2019-06-13 22:41 ` Borislav Petkov
2019-06-14 7:21 ` Robert Richter
2019-06-14 8:39 ` Robert Richter
2019-06-14 10:09 ` Borislav Petkov
2019-06-14 14:40 ` Robert Richter
2019-06-14 15:06 ` Borislav Petkov
2019-06-14 6:32 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613191843.GG11598@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).