From: Borislav Petkov <bp@alien8.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
James Morse <james.morse@arm.com>,
linux-edac@vger.kernel.org
Subject: Re: [PATCH] edac: make edac_debugfs_create_x*() return void
Date: Sat, 15 Jun 2019 11:00:19 +0200 [thread overview]
Message-ID: <20190615090019.GA19758@zn.tnic> (raw)
In-Reply-To: <20190611175433.GA5108@kroah.com>
On Tue, Jun 11, 2019 at 07:54:33PM +0200, Greg Kroah-Hartman wrote:
> The return values of edac_debugfs_create_x16() and
> edac_debugfs_create_x8() are never checked (as they don't need to be),
> so no need to have them return anything, just make the functions return
> void instead.
>
> This is done with the goal of being able to change the debugfs_create_x*
> functions to also not return a value.
>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: James Morse <james.morse@arm.com>
> Cc: <linux-edac@vger.kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/edac/debugfs.c | 12 ++++++------
> drivers/edac/edac_module.h | 18 ++++++++----------
> 2 files changed, 14 insertions(+), 16 deletions(-)
Applied, thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
prev parent reply other threads:[~2019-06-15 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 17:54 [PATCH] edac: make edac_debugfs_create_x*() return void Greg Kroah-Hartman
2019-06-15 9:00 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190615090019.GA19758@zn.tnic \
--to=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).