From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD6BDC73C41 for ; Tue, 9 Jul 2019 12:31:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BF00216FD for ; Tue, 9 Jul 2019 12:31:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725989AbfGIMbH (ORCPT ); Tue, 9 Jul 2019 08:31:07 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2246 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725947AbfGIMbG (ORCPT ); Tue, 9 Jul 2019 08:31:06 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 33CBD1F65E6AF96065CC; Tue, 9 Jul 2019 20:31:02 +0800 (CST) Received: from localhost (10.45.141.82) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.439.0; Tue, 9 Jul 2019 20:31:01 +0800 Date: Tue, 9 Jul 2019 13:30:56 +0100 From: Jonathan Cameron To: "Hawa, Hanna" CC: , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 2/4] edac: Add support for Amazon's Annapurna Labs L1 EDAC Message-ID: <20190709133056.00001c57@huawei.com> In-Reply-To: <45e9ac35-9ffc-8f5f-cbdb-f85453227363@amazon.com> References: <1562500658-14717-1-git-send-email-hhhawa@amazon.com> <1562500658-14717-3-git-send-email-hhhawa@amazon.com> <20190709173229.0000135f@huawei.com> <45e9ac35-9ffc-8f5f-cbdb-f85453227363@amazon.com> Organization: Huawei X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.45.141.82] X-CFilter-Loop: Reflected Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, 9 Jul 2019 14:01:03 +0300 "Hawa, Hanna" wrote: > On 7/9/2019 12:32 PM, Jonathan Cameron wrote: > >> Signed-off-by: Hanna Hawa > > A quick drive by review as I was feeling curious. > > > > Just a couple of trivial queries and observation on the fact it > > might be useful to add a few devm managed functions to cut down > > on edac driver boilerplate. > > > > Thanks, > > > > Jonathan > > > >> +#define ARM_CA57_CPUMERRSR_VALID GENMASK(31, 31) > > For a single bit it's common to use BIT(31) rather than GENMASK to make > > it explicit. > > Will fix. > > > > > > >> + edac_dev->mod_name = dev_name(dev); > > I'd admit I'm not that familiar with edac, but seems odd that a > > module name field would have the dev_name. > > Will fix when I got more inputs. > > > > >> + edac_device_free_ctl_info(edac_dev); > > More a passing observation than a suggestion for this driver, but if there was > > ever a place where it looked like a couple of devm_ allocation functions would > > be useful, this is it;) > > > > edac_dev = devm_device_alloc_ctrl_info(dev, ...) > > ... > > devm_edac_device_add_device(dev, ...) > > I agree. > I can implement the devm_* functions in separate patches as this is not > related to my patches (and not to delay this patches). > Great. Jonathan > > > >