linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Tony Luck <tony.luck@intel.com>,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] drivers/ras: Don't build debugfs.o if no debugfs in config
Date: Thu, 8 Aug 2019 16:20:55 +0200	[thread overview]
Message-ID: <20190808142055.GF20745@zn.tnic> (raw)
In-Reply-To: <77171.1565269299@turing-police>

On Thu, Aug 08, 2019 at 09:01:39AM -0400, Valdis Klētnieks wrote:
> It's needed if somebody applies the patch 2/2 -

It is needed for what?

> and I just got a note from the kbuild test robot saying that
> happened....

Yes, I don't see any issues with 2/2 only applied. I could be missing
some aspect though...

> And if it's that useless, maybe *more* needs to be done to ensure that
> debugfs is enabled if ras is being built - possibly a Kconfig 'select'
> or something....

Or something:

config RAS_CEC
        depends on X86_MCE && MEMORY_FAILURE && DEBUG_FS
						^^^^^^^^
-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2019-08-08 14:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 22:55 [PATCH v2 1/2] drivers/ras: Don't build debugfs.o if no debugfs in config Valdis Klētnieks
2019-08-08  9:31 ` Borislav Petkov
2019-08-08 13:01   ` Valdis Klētnieks
2019-08-08 14:20     ` Borislav Petkov [this message]
2019-08-08 14:35       ` Borislav Petkov
2019-08-08 15:08       ` Valdis Klētnieks
2019-08-08 15:14         ` Borislav Petkov
2019-08-08 15:18           ` Valdis Klētnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190808142055.GF20745@zn.tnic \
    --to=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).