From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2517AC32750 for ; Tue, 13 Aug 2019 08:09:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EAF8A20842 for ; Tue, 13 Aug 2019 08:09:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="Hjlrm8LH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726915AbfHMIJK (ORCPT ); Tue, 13 Aug 2019 04:09:10 -0400 Received: from mail.skyhub.de ([5.9.137.197]:49706 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfHMIJJ (ORCPT ); Tue, 13 Aug 2019 04:09:09 -0400 Received: from zn.tnic (p200300EC2F0D240075AA4C13F769B7E7.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:2400:75aa:4c13:f769:b7e7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 83D2F1EC0716; Tue, 13 Aug 2019 10:09:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1565683748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=TvZfKXBWT9Z9g902906G7WIPUY9iKv6XjXyYLjYmEBc=; b=Hjlrm8LHktrNd92h9p56qukqrVGVOUmod6fAuuDp//GAFXYEeqeorH2Al/euKE4Sc5h8W3 uTOpVGdpGveXaAhq7RIaWFMlcBV0IuuXRGE2t3d/4RQzxs4DnzmJH0JYMp/bVpM8Y3jnFv Tuz6B1EcaIpFK9fI8EnNCZajiGikD14= Date: Tue, 13 Aug 2019 10:09:58 +0200 From: Borislav Petkov To: Robert Richter Cc: James Morse , Mauro Carvalho Chehab , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 03/24] EDAC, ghes: Remove pvt->detail_location string Message-ID: <20190813080958.GC16770@zn.tnic> References: <20190624150758.6695-1-rrichter@marvell.com> <20190624150758.6695-4-rrichter@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190624150758.6695-4-rrichter@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Mon, Jun 24, 2019 at 03:08:59PM +0000, Robert Richter wrote: > The detail_location[] string in struct ghes_edac_pvt is complete s/complete/completely/ > useless and data is just copied around. Put everything into > e->other_detail from the beginning. > > Signed-off-by: Robert Richter > --- > drivers/edac/ghes_edac.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.