From: Russell King - ARM Linux admin <linux@armlinux.org.uk> To: Chris Packham <chris.packham@alliedtelesis.co.nz> Cc: bp@alien8.de, robh+dt@kernel.org, mark.rutland@arm.com, patches@armlinux.org.uk, mchehab@kernel.org, james.morse@arm.com, jlu@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Gregory CLEMENT <gregory.clement@free-electrons.com> Subject: Re: [PATCH v9 1/8] ARM: aurora-l2: add prefix to MAX_RANGE_SIZE Date: Fri, 23 Aug 2019 11:50:20 +0100 Message-ID: <20190823105020.GZ13294@shell.armlinux.org.uk> (raw) In-Reply-To: <20190823104621.GY13294@shell.armlinux.org.uk> On Fri, Aug 23, 2019 at 11:46:21AM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jul 12, 2019 at 03:48:57PM +1200, Chris Packham wrote: > > From: Jan Luebbe <jlu@pengutronix.de> > > > > The macro name is too generic, so add a AURORA_ prefix. > > > > Signed-off-by: Jan Luebbe <jlu@pengutronix.de> > > Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com> > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > > --- > > arch/arm/include/asm/hardware/cache-aurora-l2.h | 2 +- > > I can't apply this series - this file does not exist in my tree, and > from what git tells me, it never has existed. Maybe it's in someone > elses tree? I think the file is in my tree, just as arch/arm/mm/cache-aurora-l2.h which is where it has been since it was originally submitted in 2012. > > > arch/arm/mm/cache-l2x0.c | 4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/include/asm/hardware/cache-aurora-l2.h b/arch/arm/include/asm/hardware/cache-aurora-l2.h > > index c86124769831..dc5c479ec4c3 100644 > > --- a/arch/arm/include/asm/hardware/cache-aurora-l2.h > > +++ b/arch/arm/include/asm/hardware/cache-aurora-l2.h > > @@ -41,7 +41,7 @@ > > #define AURORA_ACR_FORCE_WRITE_THRO_POLICY \ > > (2 << AURORA_ACR_FORCE_WRITE_POLICY_OFFSET) > > > > -#define MAX_RANGE_SIZE 1024 > > +#define AURORA_MAX_RANGE_SIZE 1024 > > > > #define AURORA_WAY_SIZE_SHIFT 2 > > > > diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c > > index 428d08718107..83b733a1f1e6 100644 > > --- a/arch/arm/mm/cache-l2x0.c > > +++ b/arch/arm/mm/cache-l2x0.c > > @@ -1352,8 +1352,8 @@ static unsigned long aurora_range_end(unsigned long start, unsigned long end) > > * since cache range operations stall the CPU pipeline > > * until completion. > > */ > > - if (end > start + MAX_RANGE_SIZE) > > - end = start + MAX_RANGE_SIZE; > > + if (end > start + AURORA_MAX_RANGE_SIZE) > > + end = start + AURORA_MAX_RANGE_SIZE; > > > > /* > > * Cache range operations can't straddle a page boundary. > > -- > > 2.22.0 > > > > > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up > According to speedtest.net: 11.9Mbps down 500kbps up -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply index Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-12 3:48 [PATCH v9 0/8] EDAC drivers for Armada XP L2 and DDR Chris Packham 2019-07-12 3:48 ` [PATCH v9 1/8] ARM: aurora-l2: add prefix to MAX_RANGE_SIZE Chris Packham 2019-08-23 10:46 ` Russell King - ARM Linux admin 2019-08-23 10:50 ` Russell King - ARM Linux admin [this message] 2019-08-26 0:46 ` Chris Packham 2019-08-27 9:13 ` Russell King - ARM Linux admin 2019-08-27 20:56 ` Chris Packham 2019-08-27 21:07 ` Russell King - ARM Linux admin 2019-08-27 21:13 ` Chris Packham 2019-08-27 21:15 ` Russell King - ARM Linux admin 2019-07-12 3:48 ` [PATCH v9 2/8] ARM: aurora-l2: add defines for parity and ECC registers Chris Packham 2019-07-12 3:48 ` [PATCH v9 3/8] ARM: l2x0: support parity-enable/disable on aurora Chris Packham 2019-07-12 3:49 ` [PATCH v9 4/8] dt-bindings: ARM: document marvell,ecc-enable binding Chris Packham 2019-07-12 3:49 ` [PATCH v9 5/8] ARM: l2x0: add marvell,ecc-enable property for aurora Chris Packham 2019-07-12 3:49 ` [PATCH v9 6/8] EDAC: Add missing debugfs_create_x32 wrapper Chris Packham 2019-07-12 3:49 ` [PATCH v9 7/8] EDAC: Add driver for the Marvell Armada XP SDRAM and L2 cache ECC Chris Packham 2019-07-12 3:49 ` [PATCH v9 8/8] EDAC: armada_xp: Add support for more SoCs Chris Packham 2019-07-26 14:51 ` James Morse 2019-07-28 20:52 ` Chris Packham 2019-07-26 14:53 ` [PATCH v9 0/8] EDAC drivers for Armada XP L2 and DDR James Morse 2019-07-28 20:33 ` Chris Packham
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190823105020.GZ13294@shell.armlinux.org.uk \ --to=linux@armlinux.org.uk \ --cc=bp@alien8.de \ --cc=chris.packham@alliedtelesis.co.nz \ --cc=devicetree@vger.kernel.org \ --cc=gregory.clement@free-electrons.com \ --cc=james.morse@arm.com \ --cc=jlu@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=patches@armlinux.org.uk \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-EDAC Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \ linux-edac@vger.kernel.org public-inbox-index linux-edac Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac AGPL code for this site: git clone https://public-inbox.org/public-inbox.git