From: Borislav Petkov <bp@alien8.de>
To: Robert Richter <rrichter@marvell.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] EDAC, mc_sysfs: Change dev_ch_attribute->channel to unsigned int
Date: Mon, 2 Sep 2019 15:04:39 +0200 [thread overview]
Message-ID: <20190902130439.GE9605@zn.tnic> (raw)
In-Reply-To: <20190902123216.9809-3-rrichter@marvell.com>
On Mon, Sep 02, 2019 at 12:33:43PM +0000, Robert Richter wrote:
> Struct member dev_ch_attribute->channel is always used as unsigned
> int. Change type to unsigned int to avoid type casts.
>
> Signed-off-by: Robert Richter <rrichter@marvell.com>
> ---
> drivers/edac/edac_mc_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
> index 640b9419623e..4eb8c5ceb973 100644
> --- a/drivers/edac/edac_mc_sysfs.c
> +++ b/drivers/edac/edac_mc_sysfs.c
> @@ -131,7 +131,7 @@ static const char * const edac_caps[] = {
>
> struct dev_ch_attribute {
> struct device_attribute attr;
> - int channel;
> + unsigned int channel;
> };
>
> #define DEVICE_CHANNEL(_name, _mode, _show, _store, _var) \
> --
Merged this one into 1/5.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-09-02 13:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 12:33 [PATCH 0/5] EDAC: Small cleanups and fixes Robert Richter
2019-09-02 12:33 ` [PATCH 1/5] EDAC: Prefer 'unsigned int' to bare use of 'unsigned' Robert Richter
2019-09-02 12:33 ` [PATCH 2/5] EDAC, mc_sysfs: Change dev_ch_attribute->channel to unsigned int Robert Richter
2019-09-02 13:04 ` Borislav Petkov [this message]
2019-09-02 12:33 ` [PATCH 3/5] EDAC, mc_sysfs: Remove pointless gotos Robert Richter
2019-09-02 12:33 ` [PATCH 4/5] EDAC, mc_sysfs: Make debug messages consistent Robert Richter
2019-09-02 12:33 ` [PATCH 5/5] MAINTAINERS: update EDAC's reviewer entry Robert Richter
2019-09-02 20:17 ` [PATCH 0/5] EDAC: Small cleanups and fixes Mauro Carvalho Chehab
2019-09-04 15:53 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902130439.GE9605@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).