Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Isaac Vaughn <isaac.vaughn@Knights.ucf.edu>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>,
	"trivial@kernel.org" <trivial@kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH] amd64_edac - Add Family 17h Model 70h PCI IDs
Date: Thu, 5 Sep 2019 09:09:17 +0200
Message-ID: <20190905070917.GA19246@zn.tnic> (raw)
In-Reply-To: <BN7PR07MB5186E542BB3AD734262AA345CEBB0@BN7PR07MB5186.namprd07.prod.outlook.com>

On Thu, Sep 05, 2019 at 01:21:40AM +0000, Isaac Vaughn wrote:
> Add the new Family 17h Model 70h PCI IDs (device 18h functions 0, 3, 4, and 6) to the kernel, the hwmon module, and the AMD64 EDAC module.
> 
> Signed-off-by: Isaac Vaughn <isaac.vaughn@knights.ucf.edu>
> ---
> Changes to the amd64_edac were tested on 5.2.11 and the current patch was tested on 5.3.0rc7. Since git's pager has been mangling my indentation, diffs were generated with the '--no-pager' option. (Not sure if this might make output non-standard in some other way.)
> 

That's probably because this is not how you generate patches with git.
Please have a look at one of the countless tutorials on the web how to
do that. The gist of it is, you do:

$ git commit -a -s
 <write commit message, add SOB etc>
$ git format-patch -1 -o /tmp/

and send the filename as an email or you use

$ git send-email -1 ...

depending on what you would like to do. Just note that git send-email
can spam people quickly so I'd suggest using the --dry-run option there
first. :)

The tutorials and the manpages of the respective commands will give you
more detail about what they all do and what options to use.

But before you do that, you need to fix your indentation because that
still is wrong. Use that script checkpatch.pl to verify your patch and
send it only then when it doesn't complain about spaces anymore, see
below.

Oh, and pls add those PCI IDs to drivers/edac/amd64_edac.h, not to
pci_ids.h because they will be used by the amd64_edac driver only for
now so they don't need to go into the system-wide header.

Thanks!

$ ./scripts/checkpatch.pl /tmp/isaac.vaughn.02
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14: 
Add the new Family 17h Model 70h PCI IDs (device 18h functions 0, 3, 4, and 6) to the kernel, the hwmon module, and the AMD64 EDAC module.

WARNING: please, no spaces at the start of a line
#47: FILE: arch/x86/kernel/amd_nb.c:36:
+       { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_M70H_ROOT) },$

WARNING: please, no spaces at the start of a line
#55: FILE: arch/x86/kernel/amd_nb.c:55:
+       { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_M70H_DF_F3) },$

WARNING: please, no spaces at the start of a line
#63: FILE: arch/x86/kernel/amd_nb.c:70:
+       { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_M70H_DF_F4) },$

WARNING: please, no spaces at the start of a line
#75: FILE: drivers/edac/amd64_edac.c:2256:
+       [F17_M70H_CPUS] = {$
...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04 21:13 Isaac Vaughn
2019-09-04 21:53 ` Borislav Petkov
2019-09-04 22:21   ` Ghannam, Yazen
2019-09-05  1:21   ` Isaac Vaughn
2019-09-05  7:09     ` Borislav Petkov [this message]
2019-09-05 13:17       ` Isaac Vaughn
2019-09-05 13:54         ` Borislav Petkov
2019-09-06  1:01           ` [PATCH] Add PCI device IDs for family 17h, model 70h Isaac Vaughn
2019-09-06  1:41             ` Ghannam, Yazen
2019-09-06  1:56           ` Isaac Vaughn
2019-09-06  9:12             ` Borislav Petkov
     [not found]               ` <20190906075729.9e2faf7147da62fc26006833@knights.ucf.edu>
2019-09-06 12:14                 ` Borislav Petkov
2019-09-06 13:02               ` Guenter Roeck
2019-09-06 13:09                 ` Boris Petkov
     [not found]                   ` <B08C8E54-43FA-4E29-8D7D-5F9C4AF20CCF@Knights.ucf.edu>
2019-09-06 14:50                     ` Borislav Petkov
2019-09-06 23:27                       ` Isaac Vaughn
2019-09-06 16:11                   ` Guenter Roeck
2019-09-06 16:22                     ` Borislav Petkov

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190905070917.GA19246@zn.tnic \
    --to=bp@alien8.de \
    --cc=isaac.vaughn@Knights.ucf.edu \
    --cc=linux-edac@vger.kernel.org \
    --cc=trivial@kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org linux-edac@archiver.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/ public-inbox