From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31760C3A5A5 for ; Thu, 5 Sep 2019 07:09:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 046FC21848 for ; Thu, 5 Sep 2019 07:09:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="rieO/8CS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730737AbfIEHJ0 (ORCPT ); Thu, 5 Sep 2019 03:09:26 -0400 Received: from mail.skyhub.de ([5.9.137.197]:33246 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727900AbfIEHJ0 (ORCPT ); Thu, 5 Sep 2019 03:09:26 -0400 Received: from zn.tnic (p200300EC2F0A5F0094A48B587AEA6833.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:5f00:94a4:8b58:7aea:6833]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 445D11EC094F; Thu, 5 Sep 2019 09:09:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1567667365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=+eoI3cFeThY7Pqe9ifks+YyaJN9Ow22rt6IiuYqdpn8=; b=rieO/8CSjBERJfejL634ufPpBS8DgFerRfWvfURLEmcHSppq+bteCqiMb9NSKPARydZRrx PAup0gxpXSMy5WPL1Rg5aAbxz/52A6uxP1gM62uGXgV81wCH+4bIIs31UrQuFNRwXjkdfO /W/ssa0Bi349/M6XY46N4fbwWCcymq0= Date: Thu, 5 Sep 2019 09:09:17 +0200 From: Borislav Petkov To: Isaac Vaughn Cc: Yazen Ghannam , "trivial@kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH] amd64_edac - Add Family 17h Model 70h PCI IDs Message-ID: <20190905070917.GA19246@zn.tnic> References: <20190904215308.GA12374@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Sep 05, 2019 at 01:21:40AM +0000, Isaac Vaughn wrote: > Add the new Family 17h Model 70h PCI IDs (device 18h functions 0, 3, 4, and 6) to the kernel, the hwmon module, and the AMD64 EDAC module. > > Signed-off-by: Isaac Vaughn > --- > Changes to the amd64_edac were tested on 5.2.11 and the current patch was tested on 5.3.0rc7. Since git's pager has been mangling my indentation, diffs were generated with the '--no-pager' option. (Not sure if this might make output non-standard in some other way.) > That's probably because this is not how you generate patches with git. Please have a look at one of the countless tutorials on the web how to do that. The gist of it is, you do: $ git commit -a -s $ git format-patch -1 -o /tmp/ and send the filename as an email or you use $ git send-email -1 ... depending on what you would like to do. Just note that git send-email can spam people quickly so I'd suggest using the --dry-run option there first. :) The tutorials and the manpages of the respective commands will give you more detail about what they all do and what options to use. But before you do that, you need to fix your indentation because that still is wrong. Use that script checkpatch.pl to verify your patch and send it only then when it doesn't complain about spaces anymore, see below. Oh, and pls add those PCI IDs to drivers/edac/amd64_edac.h, not to pci_ids.h because they will be used by the amd64_edac driver only for now so they don't need to go into the system-wide header. Thanks! $ ./scripts/checkpatch.pl /tmp/isaac.vaughn.02 WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #14: Add the new Family 17h Model 70h PCI IDs (device 18h functions 0, 3, 4, and 6) to the kernel, the hwmon module, and the AMD64 EDAC module. WARNING: please, no spaces at the start of a line #47: FILE: arch/x86/kernel/amd_nb.c:36: + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_M70H_ROOT) },$ WARNING: please, no spaces at the start of a line #55: FILE: arch/x86/kernel/amd_nb.c:55: + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_M70H_DF_F3) },$ WARNING: please, no spaces at the start of a line #63: FILE: arch/x86/kernel/amd_nb.c:70: + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_M70H_DF_F4) },$ WARNING: please, no spaces at the start of a line #75: FILE: drivers/edac/amd64_edac.c:2256: + [F17_M70H_CPUS] = {$ ... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette