From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81EA1C5ACAE for ; Wed, 11 Sep 2019 15:40:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5447B2085B for ; Wed, 11 Sep 2019 15:40:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="Rm+awrlF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728658AbfIKPko (ORCPT ); Wed, 11 Sep 2019 11:40:44 -0400 Received: from mail.skyhub.de ([5.9.137.197]:47444 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727581AbfIKPko (ORCPT ); Wed, 11 Sep 2019 11:40:44 -0400 Received: from zn.tnic (p200300EC2F0BA90014C938BBBD6B6EBD.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:a900:14c9:38bb:bd6b:6ebd]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B24551EC0260; Wed, 11 Sep 2019 17:40:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1568216442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=0XkV/Gz/13IJqBOxxhh8TZyo4mSOacc++RqAW+iwqYU=; b=Rm+awrlFXc/u5Sl6OTsLWmDmUyXs+19HWvYRVtZl6m3kvelXHxxph/I0vUx0Z1fYSe0Ka4 uvfPk+iWYyRXW277fmgy4zT7wKAcRMzoo5FDxNamwczHPsw9Fl9/mcQGRNB3c9o8vPaasQ KHvihBjW5AJSvyMHIf5rygWvJKM7T0Y= Date: Wed, 11 Sep 2019 17:40:37 +0200 From: Borislav Petkov To: Xiaochun Lee Cc: tony.luck@intel.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Xiaochun Lee Subject: Re: [PATCH] x86/mce: add a switch of CONFIG_X86_MCELOG_LEGACY Message-ID: <20190911154037.GB27910@zn.tnic> References: <1568215730-11471-1-git-send-email-lixiaochun.2888@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1568215730-11471-1-git-send-email-lixiaochun.2888@163.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Wed, Sep 11, 2019 at 11:28:50PM +0800, Xiaochun Lee wrote: > From: Xiaochun Lee > > Add CONFIG_X86_MCELOG_LEGACY to control the > behavior of several functions be compiled. ... because? Your commit messages structure should look something like this: Problem is A. It happens because of B. Fix it by doing C. (Potentially do D). For more detailed info, see Documentation/process/submitting-patches.rst, Section "2) Describe your changes". -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette